From nobody Fri Mar 08 08:52:41 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Trg0y58Fvz5DBpm; Fri, 8 Mar 2024 08:52:50 +0000 (UTC) (envelope-from thierry@pompo.net) Received: from edna.lautre.net (edna.lautre.net [80.67.160.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "lautre.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Trg0y2TmJz3xH8; Fri, 8 Mar 2024 08:52:50 +0000 (UTC) (envelope-from thierry@pompo.net) Authentication-Results: mx1.freebsd.org; none Received: from graf.pompo.net (graf.pompo.net [82.66.0.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by edna.lautre.net (Postfix) with ESMTPSA id B2A4310F7AC; Fri, 8 Mar 2024 09:52:41 +0100 (CET) Received: by graf.pompo.net (Postfix, from userid 1001) id 682C369F58; Fri, 8 Mar 2024 09:52:41 +0100 (CET) Date: Fri, 8 Mar 2024 09:52:41 +0100 From: Thierry Thomas To: Mathieu Arnold Cc: Fernando =?iso-8859-1?Q?Apestegu=EDa?= , Daniel Engberg , Daniel Engberg , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: ea45a9a53499 - main - cad/PrusaSlicer: Mark BROKEN Message-ID: Mail-Followup-To: Mathieu Arnold , Fernando =?iso-8859-1?Q?Apestegu=EDa?= , Daniel Engberg , Daniel Engberg , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org References: <202403031936.423JaMcm054153@gitrepo.freebsd.org> <0d76f19c6d2e3e2b70a2ccc07c71e1ce@mail.infomaniak.com> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nSPF6jR75E5ArI9R" Content-Disposition: inline In-Reply-To: X-Operating-System: FreeBSD 14.0-STABLE amd64 Organization: Kabbale Eros X-Face: (hRbQnK~Pt7$ct`!fupO(`y_WL4^-Iwn4@ly-.,[4xC4xc;y=\ipKMNm<1J>lv@PP~7Z<.tKjAnXLs: X-PGP: 0xF1C516B3C8359753 X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_RCPT(0.00)[]; ASN(0.00)[asn:20766, ipnet:80.67.160.0/19, country:FR] X-Rspamd-Queue-Id: 4Trg0y2TmJz3xH8 --nSPF6jR75E5ArI9R Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Le jeu. 7 mars 24 =E0 15:15:30 +0100, Mathieu Arnold =E9crivait=A0: > > My main point is this. We should mark ports as BROKEN when *they* are > > broken, not when the dependencies are. >=20 > In this case, the dependency was not broken in the sense that it built > just fine. > We mark ports BROKEN because they don't build, so that the FreeBSD ports > infrastructure does not spend hours trying to build stuff that will > never build. Yes, in this case, it would be rather IGNORE and not BROKEN, but Fernando is right: the faulty port should be marked, not its consumers. And the compilation farm will not even try to build them. But yet better: I would prefer that the committer who pushed this commit be notified, and that without a prompt reaction on his part, it be reverted. --=20 Th. Thomas. --nSPF6jR75E5ArI9R Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJ8BAEBCgBmBQJl6tHYXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRFNTM2QkU4NTM4NTM5OUQwMEI2RkFBNzZG MUM1MTZCM0M4MzU5NzUzAAoJEPHFFrPINZdT5TwQALq79wRnZJRDHBnKX+jbKDpa ifmW4XJcheu3ixk+FCsHtBwgGQSbvZsITLv9zC8qrdHOpmsrbSUnLDvE0NRwI170 1SoLVHrPhT89Fr3X+k27nGjObzM96ueqPOX1aSoXF2QlfxgCZ1l6slUk9M7Dk88+ NXFWuRU/lqgQlYGtHH3/JX9lB7kUozCNfWKuhL+TwSnKVL4cxNmOWwLAT3ZrbJem PkdlSkTCfRc+AZEeycs5BXv+Ti/U0dLGWljcAec3GXsxw2cU5ijqMdS5D5hL2IHJ GRvpVPD3zB6/NuSBn5IVnnumOW3nMBoUXrCWy7+6Abo5s6O5uhMSLurqgbvJ40iF MB78a0R0AQPR+imsbDnALFiRBOU1p4+VWhMaAp8E17fh1cKY66HpzUI5irIR1f3V sDov3G29hUQyxDZZe5S4jykQ52GM7bKDXIzn+OKgOOrVGLJg7TN8uknWlxLTAuJo vLR0ON4H8YmlX3aGF5ECI8/C0rwri8F8NCKffpyWHBer35JnWHWCYEi1m3fO21Dx EVa4LLMy8k0BxxFxv179CizT5YczG4FQnH0+Rqcdzsw+vN5grk6mwl8IukyfmUxU lOtYkVXGMcaIsxF/MRceFuLF6mTrl/xHh04lXj2iRT4Z8F9lzeTwMSOyGtvz8jf+ yNrP6kkl6iAI/RziD8SQ =oeXB -----END PGP SIGNATURE----- --nSPF6jR75E5ArI9R--