From nobody Thu Mar 07 11:22:09 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Tr6N20bqMz5Cny0; Thu, 7 Mar 2024 11:22:26 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Tr6N10VNrz4fdd; Thu, 7 Mar 2024 11:22:25 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-5135e8262e4so837195e87.0; Thu, 07 Mar 2024 03:22:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709810542; x=1710415342; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=TaDPqioxmPhJOjdklmCLVQti70PrIwo1XpHxw/NWdCk=; b=eQTG2ax1PmBv2fxG0MGa/AdOAMDgN2nbF7Sj9R0l1zjIrT5aB7iWG+f67TFOyMPMZk AdPTop4NQFh1aceErf+gnj19UhmQBcX0TvQAdoaCd1uq54wx9QUdYrJWdtGSRgLLy02n GqphDHhlZ3yYWqRouXjSc07pFXVEUVWxAX3VA7/xkhEbplRsaD2iRyXeXCZJn7cPDABF Bu4tEWDKcy+lfK0WhDoQREwBKarSZRSpJCO1B5EyLUZUr92c1LyWs+HlXEwmEfPdYDFR QxkHUsW45XIozSk62ugVLJalng1FgH5QsxAqpbGzPEylxupPnc4cR7ANUCXj1/VEFJoQ 30AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709810542; x=1710415342; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TaDPqioxmPhJOjdklmCLVQti70PrIwo1XpHxw/NWdCk=; b=GZX+Ygi18ZmUiDT34F7quulZK50xgBL3AB9XVf2/Lo0G5sjatykXeTS51oCtuZfIIL fB7lFzAB6wTYV+HqWtr7YEDtbL/gJT6RrtNl63hWgmimHqWBRsUzihV5ASsXA9wvDLOt 1WPPnVqH3mTFe+WcAC+MW9uME5DrUrhgK1fx2bQ5YgozNGOMfn64h+GNgVunwECctJI0 L4RMtO2NonpQ/RvlNCF1oxFL2zTuwAuRroKV44Cw2FYvGlEIW1AtFNV4hK4b03uhQisJ eg4YbYFM7yMBP+CtinFxvmM+LmFVs0bWWfThnbCDWwcw5sdlMppGXSHJ19+d+otwVwQ6 KLgg== X-Forwarded-Encrypted: i=1; AJvYcCUJbIxDCYlWzMcZAIgCrBtw/bDdVg/kliGAwVT1dQFizDBVhUV/A7FB/xzRr9jTCDE40DoEW6YmnCORfq1Oxq1yKhNwsdnM0vZ1MM3YI8qblyOk1vI59Esg7IIJpUHcfbRo4tHfBGfVHr1o3BR4oxKdEFfIkkcBSezIeqL1m3MMUjlNwBYCYr6S88jIUlYuEJTJbbM= X-Gm-Message-State: AOJu0Yw40XUsv8Ru49g1zqy+Fyqyd6XSkx1FGuhS4a/z8lz+F1LGg7Jk 82XiorMx7W0/lFo4Ik9CpxmpPFOfH9XA/vRUkp635EwoBWkHfgImj3u06dDTlpnEKT0XldF3WmL wUyqJcOxbJhj01SECJ02xjUYbty0Xx8K5pMuvCQ== X-Google-Smtp-Source: AGHT+IGy1RT+U+hm/rJMKdWF5GaPVZQmRi9QYmGY2SOojscbOhhebqWLZX5pMl9i103ckVprAFQ6BuNJwWqCNk7IVV8= X-Received: by 2002:a05:6512:2147:b0:513:76ec:2d21 with SMTP id s7-20020a056512214700b0051376ec2d21mr1114935lfr.10.1709810541910; Thu, 07 Mar 2024 03:22:21 -0800 (PST) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202403031936.423JaMcm054153@gitrepo.freebsd.org> <0d76f19c6d2e3e2b70a2ccc07c71e1ce@mail.infomaniak.com> In-Reply-To: <0d76f19c6d2e3e2b70a2ccc07c71e1ce@mail.infomaniak.com> From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= Date: Thu, 7 Mar 2024 12:22:09 +0100 Message-ID: Subject: Re: git: ea45a9a53499 - main - cad/PrusaSlicer: Mark BROKEN To: Daniel Engberg Cc: Daniel Engberg , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000fbdfa40613104931" X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Queue-Id: 4Tr6N10VNrz4fdd --000000000000fbdfa40613104931 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Mar 6, 2024 at 10:34=E2=80=AFPM Daniel Engberg < daniel.engberg.lists@pyret.net> wrote: > On 2024-03-04T18:34:16.000+01:00, Fernando Apestegu=C3=ADa < > fernando.apesteguia@gmail.com> wrote: > > On Sun, Mar 3, 2024 at 8:36=E2=80=AFPM Daniel Engberg > wrote: > > > > > > > The branch main has been updated by diizzy: > > > > > > URL: > > > > https://cgit.FreeBSD.org/ports/commit/?id=3Dea45a9a534994a1bf97a162168902= cebbca1f4c1 > > > > > > commit ea45a9a534994a1bf97a162168902cebbca1f4c1 > > > Author: Daniel Engberg > > > AuthorDate: 2024-03-03 08:29:04 +0000 > > > Commit: Daniel Engberg > > > CommitDate: 2024-03-03 19:26:10 +0000 > > > > > > cad/PrusaSlicer: Mark BROKEN > > > > > > Fails to build, error: no member named 'prior' in namespace > 'boost' > > > > > > Reported by: pkg-fallout > > > --- > > > cad/PrusaSlicer/Makefile | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/cad/PrusaSlicer/Makefile b/cad/PrusaSlicer/Makefile > > > index dc125244df20..936e76216daf 100644 > > > --- a/cad/PrusaSlicer/Makefile > > > +++ b/cad/PrusaSlicer/Makefile > > > @@ -12,6 +12,8 @@ WWW=3D https://www.prusa3d.com/prusaslice= r/ > > > LICENSE=3D AGPLv3 > > > LICENSE_FILE=3D ${WRKSRC}/LICENSE > > > > > > +BROKEN=3D fails to build, error: no member named > 'prior' in > > > namespace 'boost' > > > + > > > > > > > Can we revert this? > > It is an issue with math/cgal and not cad/PrusaSlicer ( > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277480) > > > > Cheers. > > > > > > > > > BUILD_DEPENDS=3D cereal>=3D1.3.0.10:devel/cereal \ > > > cgal>=3D5.0.2:math/cgal \ > > > opencascade>=3D7.7.0:cad/opencascade > > > > Hi, > > It breaks Prusaslicer either way? > > https://pdr2.bofh.network/data/140-diizzy/2024-03-02_16h50m15s/logs/error= s/PrusaSlicer-2.6.0_8.log I just realized I didn't attach the patch to the PR :S It is attached now. With that patch in math/cgal, cad/PrusaSlicer builds fine. My main point is this. We should mark ports as BROKEN when *they* are broken, not when the dependencies are. Otherwise, if/when the dependency is fixed those ports would remain marked as BROKEN unless someone keeps track of what ports where marked that way because of a flaw in the dependency. There are 9 ports depending on math/cgal.I didn't check if any other ports are broken, but any port that includes the same header from math/cgal will fail to build unless they also include boost/next_prior.hpp by any chance The patch in the PR should be upstreamed too and/or math/cgal. > > > Best regards, > Daniel > --000000000000fbdfa40613104931 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Mar 6, 2024 at 10:34=E2=80=AF= PM Daniel Engberg <dan= iel.engberg.lists@pyret.net> wrote:
On 2024-03-04T18:34:16.000+01:00, Fernando Apest= egu=C3=ADa <fernando.apesteguia@gmail.com> wrote:
>=C2=A0 On Sun, Mar 3, 2024 at 8:36=E2=80=AFPM Daniel Engberg <diizzy@freebsd.org>= ; wrote:
>
>
> >=C2=A0 =C2=A0 The branch main has been updated by diizzy:
> >
> >=C2=A0 URL:
> >=C2=A0 = https://cgit.FreeBSD.org/ports/commit/?id=3Dea45a9a534994a1bf97a162168902ce= bbca1f4c1
> >
> >=C2=A0 commit ea45a9a534994a1bf97a162168902cebbca1f4c1
> >=C2=A0 Author:=C2=A0 =C2=A0 =C2=A0Daniel Engberg <diizzy@FreeBS= D.org>
> >=C2=A0 AuthorDate: 2024-03-03 08:29:04 +0000
> >=C2=A0 Commit:=C2=A0 =C2=A0 =C2=A0Daniel Engberg <diizzy@FreeBS= D.org>
> >=C2=A0 CommitDate: 2024-03-03 19:26:10 +0000
> >
> >=C2=A0 =C2=A0 =C2=A0 cad/PrusaSlicer: Mark BROKEN
> >
> >=C2=A0 =C2=A0 =C2=A0 Fails to build, error: no member named 'p= rior' in namespace 'boost'
> >
> >=C2=A0 =C2=A0 =C2=A0 Reported by:=C2=A0 =C2=A0 pkg-fallout
> >=C2=A0 ---
> >=C2=A0 =C2=A0cad/PrusaSlicer/Makefile | 2 ++
> >=C2=A0 =C2=A01 file changed, 2 insertions(+)
> >
> >=C2=A0 diff --git a/cad/PrusaSlicer/Makefile b/cad/PrusaSlicer/Mak= efile
> >=C2=A0 index dc125244df20..936e76216daf 100644
> >=C2=A0 --- a/cad/PrusaSlicer/Makefile
> >=C2=A0 +++ b/cad/PrusaSlicer/Makefile
> >=C2=A0 @@ -12,6 +12,8 @@ WWW=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = https://www.prusa3d.com/prusaslicer/
> >=C2=A0 =C2=A0LICENSE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0AGPLv3
> >=C2=A0 =C2=A0LICENSE_FILE=3D=C2=A0 ${WRKSRC}/LICENSE
> >
> >=C2=A0 +BROKEN=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 fails to build, error: no member named 'prior' in
> >=C2=A0 namespace 'boost'
> >=C2=A0 +
> >
>=C2=A0
> Can we revert this?
> It is an issue with math/cgal and not cad/PrusaSlicer (
> https://bugs.freebsd.org/bugzilla/sho= w_bug.cgi?id=3D277480)
>
> Cheers.
>
>
>
> >=C2=A0 =C2=A0 =C2=A0BUILD_DEPENDS=3D cereal&gt;=3D1.3.0.10:dev= el/cereal \
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 cga= l&gt;=3D5.0.2:math/cgal \
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ope= ncascade&gt;=3D7.7.0:cad/opencascade
>

Hi,

It breaks Prusaslicer either way?
ht= tps://pdr2.bofh.network/data/140-diizzy/2024-03-02_16h50m15s/logs/errors/Pr= usaSlicer-2.6.0_8.log

I just realized I= didn't attach the patch to the PR :S
It is attached now.
=
With that patch in math/cgal, cad/PrusaSlicer builds fine.
=

My main point is this. We should mark ports as BROKEN w= hen *they* are broken, not when the dependencies are.
Otherwise, = if/when the dependency is fixed those ports would remain marked as BROKEN u= nless someone keeps track of what ports where marked that way because of a = flaw in the dependency.
There are 9 ports depending on math/cgal.= I didn't check if any other ports are broken, but any port that include= s the same header from math/cgal will fail to build unless they also includ= e boost/next_prior.hpp by any chance
=C2=A0
The patch i= n the PR should be upstreamed too and/or math/cgal.


Best regards,
Daniel
--000000000000fbdfa40613104931--