Re: git: a995b8b0ab54 - main - multimedia/{mplayer/mencoder}: Move DEBUG from OPTIONS to WITH_DEBUG

On Sun, Mar 03, 2024 at 12:01:41PM +0300, Gleb Popov wrote:
> On Sun, Mar 3, 2024 at 11:56 AM Mathieu Arnold <mat@freebsd.org> wrote:
> >
> > There is no trend, it's a rule, debug must be handled with WITH_DEBUG
> > knob, and not via an option.
> > If there is an option that enable some sort of debugging or verbose
> > thing but that is not supposed to add debugging symbols, then it should
> > not be called DEBUG.
> 
> In that case we need a qa check that prevents adding DEBUG option and
> then we can also introduce a generic DEBUG_VAR helper to get rid of
> ifdefs?

Oh, sorry, I made a mess of things, and I woke up completely, my brain
short circuited for a while.

A DEBUG option is fine, as long as it MUST NOT enable WITH_DEBUG.

WITH_DEBUG is a user facing variable, that MUST NOT be set in a port.

-- 
Mathieu Arnold