Re: git: c2afef5c2587 - main - Features/testing.mk: Introduce the TESTING_UNSAFE knob.

From: Daniel Engberg <daniel.engberg.lists_at_pyret.net>
Date: Fri, 01 Mar 2024 20:20:51 UTC 
On 2024-03-01T20:27:52.000+01:00, Gleb Popov <arrowd@FreeBSD.org>
wrote:

> The branch main has been updated by arrowd:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=c2afef5c2587738b16b52def34edcebe4e421905
> 
> commit c2afef5c2587738b16b52def34edcebe4e421905
> 
> Author:     Gleb Popov <arrowd@FreeBSD.org>
> 
> AuthorDate: 2024-03-01 19:25:37 +0000
> 
> Commit:     Gleb Popov <arrowd@FreeBSD.org>
> 
> CommitDate: 2024-03-01 19:26:53 +0000
> 
>     Features/testing.mk [http://testing.mk]: Introduce the TESTING_UNSAFE knob.
> 
>     
> 
>     Approved by:    tcberner
> 
> ---
> 
>  Mk/Features/testing.mk [http://testing.mk] | 5 ++++-
> 
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Mk/Features/testing.mk [http://testing.mk] b/Mk/Features/testing.mk [http://testing.mk]
> 
> index 15af7e28eb7c..a266f6effe91 100644
> 
> --- a/Mk/Features/testing.mk [http://testing.mk]
> 
> +++ b/Mk/Features/testing.mk [http://testing.mk]
> 
> @@ -4,12 +4,15 @@
> 
>  # - If set, and the port supports it, the software's test suite will be compiled
> 
>  #   and run during the normal building pipeline between 'stage' and 'package'
> 
>  #   stages.
> 
> +# - A port may define TESTING_UNSAFE=yes if its tests are known to fail at the
> 
> +#   moment.
> 
>  
> 
>  .if !defined(_TESTING_MK_INCLUDED)
> 
>  _TESTING_MK_INCLUDED=    yes
> 
>  TESTING_Include_MAINTAINER=    portmgr@FreeBSD.org
> 
>  
> 
> +.  if !defined(TESTING_UNSAFE)
> 
>  _TESTING_PACKAGE_DEP=    test
> 
> +.  endif
> 
>  
> 
>  .endif
> 
> -

Hi,

Thanks for adding this, however this won't work on ports that uses
TEST menu option as far as I can tell which is a relatively common
occurence?

Se also
https://cgit.freebsd.org/ports/tree/Mk/bsd.options.desc.mk#n495

Best regards,

Daniel