Re: git: 1e59715b75bc - main - editors/jove: Revive port

From: Daniel Engberg <daniel.engberg.lists_at_pyret.net>
Date: Sat, 08 Jun 2024 04:26:20 UTC
On 2024-06-08T03:15:14.000+02:00, Neel Chauhan <nc@FreeBSD.org> wrote:

> The branch main has been updated by nc:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=1e59715b75bc96492d56c09cc1cbf0612f1d5235
> 
> commit 1e59715b75bc96492d56c09cc1cbf0612f1d5235
> 
> Author:     Neel Chauhan <nc@FreeBSD.org>
> 
> AuthorDate: 2024-06-06 03:11:53 +0000
> 
> Commit:     Neel Chauhan <nc@FreeBSD.org>
> 
> CommitDate: 2024-06-07 21:15:10 +0000
> 
>     editors/jove: Revive port
> 
> ---
> 
>  MOVED                             |  1 -
> 
>  editors/Makefile                  |  1 +
> 
>  editors/jove/Makefile             | 22 ++++++++++++++++++++++
> 
>  editors/jove/distinfo             |  3 +++
> 
>  editors/jove/files/patch-Makefile | 20 ++++++++++++++++++++
> 
>  editors/jove/pkg-descr            |  3 +++
> 
>  editors/jove/pkg-plist            | 35 +++++++++++++++++++++++++++++++++++
> 
>  7 files changed, 84 insertions(+), 1 deletion(-)
> 
> diff --git a/MOVED b/MOVED
> 
> index f0871f853d45..3129fd11de0c 100644
> 
> --- a/MOVED
> 
> +++ b/MOVED
> 
> @@ -2945,7 +2945,6 @@ editors/edith||2024-01-17|Has expired: Upstream last release was in 2000
> 
>  x11-toolkits/p5-Gtk2-GladeXML||2024-01-17|Has expired: Upstream marked this module as Deprecated
> 
>  x11-toolkits/p5-Gtk2-TrayIcon||2024-01-17|Has expired: Upstream marked this module as Deprecated
> 
>  editors/led||2024-01-17|Has expired: Last upstream release was in 2002 reconsider using editors/nano
> 
> -editors/jove||2024-01-18|Has expired: No upstream update in last 23 years
> 
>  editors/impress||2024-01-18|Has expired: Upstream last release was in 2000
> 
>  biology/sim4||2024-01-18|Has expired: Upstream last update was in 2005
> 
>  x11-wm/w9wm||2024-01-18|Has expired: Last upstream release was in 2002
> 
> diff --git a/editors/Makefile b/editors/Makefile
> 
> index cc3ddba1202b..85045017c039 100644
> 
> --- a/editors/Makefile
> 
> +++ b/editors/Makefile
> 
> @@ -68,6 +68,7 @@
> 
>      SUBDIR += jed
> 
>      SUBDIR += jedit
> 
>      SUBDIR += joe
> 
> +    SUBDIR += jove
> 
>      SUBDIR += jucipp
> 
>      SUBDIR += jupp
> 
>      SUBDIR += kakoune
> 
> diff --git a/editors/jove/Makefile b/editors/jove/Makefile
> 
> new file mode 100644
> 
> index 000000000000..1bb40076a55e
> 
> --- /dev/null
> 
> +++ b/editors/jove/Makefile
> 
> @@ -0,0 +1,22 @@
> 
> +PORTNAME=    jove
> 
> +DISTVERSION=    4.17.5.3 [http://4.17.5.3]
> 
> +CATEGORIES=    editors
> 
> +
> 
> +MAINTAINER=    nc@FreeBSD.org
> 
> +COMMENT=    Jonathan's Own Version of Emacs
> 
> +WWW=        https://github.com/jonmacs/jove
> 
> +
> 
> +LICENSE=    BSD0CLAUSE
> 
> +
> 
> +USES=        groff ncurses
> 
> +
> 
> +USE_GITHUB=    yes
> 
> +GH_ACCOUNT=    jonmacs
> 
> +
> 
> +pre-patch:
> 
> +    ${REINPLACE_CMD} -e 's,/usr/local/,${PREFIX}/,' ${WRKSRC}/Makefile
> 
> +
> 
> +post-install:
> 
> +    @${MKDIR} ${STAGEDIR}/var/lib/jove/tmp
> 
> +
> 
> +.include <bsd.port.mk> [http://bsd.port.mk>];
> 
> diff --git a/editors/jove/distinfo b/editors/jove/distinfo
> 
> new file mode 100644
> 
> index 000000000000..23942e351e29
> 
> --- /dev/null
> 
> +++ b/editors/jove/distinfo
> 
> @@ -0,0 +1,3 @@
> 
> +TIMESTAMP = 1717641168
> 
> +SHA256 (jonmacs-jove-4.17.5.3_GH0.tar.gz) = ca5a5fcf71009c7389d655d1f1ae8139710f6cc531be95581e4b375e67f098d2
> 
> +SIZE (jonmacs-jove-4.17.5.3_GH0.tar.gz) = 548835
> 
> diff --git a/editors/jove/files/patch-Makefile b/editors/jove/files/patch-Makefile
> 
> new file mode 100644
> 
> index 000000000000..d3951097b395
> 
> --- /dev/null
> 
> +++ b/editors/jove/files/patch-Makefile
> 
> @@ -0,0 +1,20 @@
> 
> +--- Makefile.orig    2024-06-06 03:00:44 UTC
> 
> ++++ Makefile
> 
> +@@ -67,7 +67,7 @@ DETCDIR = $(DESTDIR)$(JETCDIR)
> 
> + 
> 
> + JETCDIR = /etc/jove
> 
> + DETCDIR = $(DESTDIR)$(JETCDIR)
> 
> +-JTMPDIR = /var/tmp
> 
> ++JTMPDIR = /var/lib/jove/tmp
> 
> + JRECDIR = /var/lib/jove/preserve
> 
> + DRECDIR = $(DESTDIR)$(JRECDIR)
> 
> + # Install permission for DRECDIR
> 
> +@@ -328,7 +328,7 @@ setmaps.o:    setmaps.c
> 
> + # create a temporary directory to hold some temporary intermediate files that the
> 
> + # Makefile generates, as a precaution against security hole via races (mktemp would be 
> 
> + # better, but we try to keep this Makefile working on old Unix, pre-POSIX, sigh)
> 
> +-TDIR=$(JTMPDIR)/jbuild$$$$
> 
> ++TDIR=/var/tmp/jbuild$$$$
> 
> + TFILE=$(TDIR)/temp
> 
> + 
> 
> + keys.c:    setmaps$(LOCALEXT) keys.txt Makefile .ALWAYS
> 
> diff --git a/editors/jove/pkg-descr b/editors/jove/pkg-descr
> 
> new file mode 100644
> 
> index 000000000000..b011f4fdb1f7
> 
> --- /dev/null
> 
> +++ b/editors/jove/pkg-descr
> 
> @@ -0,0 +1,3 @@
> 
> +Jonathan's Own Version of Emacs (Jove) is a venerable, fast, small Emacs clone
> 
> +that was originally written for 2.8BSD on PDP-11. Many people have been using
> 
> +and contributing to it since 1986. 
> 
> diff --git a/editors/jove/pkg-plist b/editors/jove/pkg-plist
> 
> new file mode 100644
> 
> index 000000000000..5e940b612a82
> 
> --- /dev/null
> 
> +++ b/editors/jove/pkg-plist
> 
> @@ -0,0 +1,35 @@
> 
> +bin/jove
> 
> +bin/teachjove
> 
> +lib/jove/recover
> 
> +man/man1/jove.1
> 
> +man/man1/teachjove.1
> 
> +%%DOCSDIR%%/example.rc
> 
> +%%DOCSDIR%%/jove.man.pdf [http://jove.man.pdf]
> 
> +%%DOCSDIR%%/jove.man.txt [http://jove.man.txt]
> 
> +%%DOCSDIR%%/jove.qref
> 
> +%%DATADIR%%/XTermresource
> 
> +%%DATADIR%%/cmds.txt
> 
> +%%DATADIR%%/jem.txt
> 
> +%%DATADIR%%/jove.rc
> 
> +%%DATADIR%%/jove.rc.3022
> 
> +%%DATADIR%%/jove.rc.sun
> 
> +%%DATADIR%%/jove.rc.sun-cmd
> 
> +%%DATADIR%%/jove.rc.vt100
> 
> +%%DATADIR%%/jove.rc.wyse
> 
> +%%DATADIR%%/jove.rc.xterm
> 
> +%%DATADIR%%/jove.rc.xterm-256color
> 
> +%%DATADIR%%/jove.rc.z29
> 
> +%%DATADIR%%/keychart.3022
> 
> +%%DATADIR%%/keychart.sun
> 
> +%%DATADIR%%/keychart.sun-cmd
> 
> +%%DATADIR%%/keychart.vt100
> 
> +%%DATADIR%%/keychart.wyse
> 
> +%%DATADIR%%/keychart.xterm
> 
> +%%DATADIR%%/keychart.xterm-256color
> 
> +%%DATADIR%%/keychart.z29
> 
> +%%DATADIR%%/teach-jove
> 
> +@mode 777
> 
> +@dir /var/lib/jove/tmp
> 
> +@dir /var/lib/jove/preserve
> 
> +@dir /var/lib/jove
> 
> +@dir /var/lib

Hi,

Any reason why we can't use the official upstream release archive as
recommended by Porters Handbook?
https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github

https://github.com/jonmacs/jove/releases/tag/4.17.5.3 -->
https://github.com/jonmacs/jove/releases/download/4.17.5.3/jove-4.17.5.3.tgz

Best regards,

Daniel