Re: git: 9ad171aaab0a - main - chinese/libchewing: Update to 0.8.5

On 2024-07-24T23:18:12.000+02:00, Po-Chuan Hsieh <sunpoet@FreeBSD.org>
wrote:

> The branch main has been updated by sunpoet:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=9ad171aaab0acf67dbdd9c89d49d6337bd8bc57c
> 
> commit 9ad171aaab0acf67dbdd9c89d49d6337bd8bc57c
> 
> Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> 
> AuthorDate: 2024-07-24 21:15:47 +0000
> 
> Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> 
> CommitDate: 2024-07-24 21:15:47 +0000
> 
>     chinese/libchewing: Update to 0.8.5
> 
>     
> 
>     - Update WWW
> 
>     - Use complete arguments/options
> 
>     - Sort PLIST
> 
>     - Update pkg-descr
> 
>     - Take maintainership
> 
>     
> 
>     Changes:        https://github.com/chewing/libchewing/releases
> 
> ---
> 
>  chinese/libchewing/Makefile  | 23 +++++++++++++----------
> 
>  chinese/libchewing/distinfo  |  6 +++---
> 
>  chinese/libchewing/pkg-descr |  8 +++++++-
> 
>  chinese/libchewing/pkg-plist |  2 +-
> 
>  4 files changed, 24 insertions(+), 15 deletions(-)
> 
> diff --git a/chinese/libchewing/Makefile b/chinese/libchewing/Makefile
> 
> index da49fb64bbad..3e4a8c7521b8 100644
> 
> --- a/chinese/libchewing/Makefile
> 
> +++ b/chinese/libchewing/Makefile
> 
> @@ -1,25 +1,28 @@
> 
>  PORTNAME=    libchewing
> 
> -DISTVERSION=    0.8.4
> 
> +PORTVERSION=    0.8.5
> 
>  CATEGORIES=    chinese textproc
> 
> -MASTER_SITES=    https://github.com/chewing/${PORTNAME}/releases/download/v${DISTVERSION}/
> 
> +MASTER_SITES=    https://github.com/chewing/libchewing/releases/download/v${PORTVERSION}/
> 
>  
> 
> -MAINTAINER=    ports@FreeBSD.org
> 
> +MAINTAINER=    sunpoet@FreeBSD.org
> 
>  COMMENT=    Chewing intelligent phonetic input method library
> 
> -WWW=        https://chewing.im
> 
> +WWW=        https://chewing.im/ \
> 
> +        https://github.com/chewing/libchewing
> 
>  
> 
>  LICENSE=    LGPL21
> 
>  LICENSE_FILE=    ${WRKSRC}/COPYING
> 
>  
> 
>  USES=        cmake:testing localbase:ldflags pathfix pkgconfig sqlite tar:zst
> 
> -USE_LDCONFIG=    yes
> 
> -
> 
> -# Tests when running in parallel
> 
> -# https://github.com/chewing/libchewing/issues/293
> 
> -CMAKE_TESTING_PARALLEL_LEVEL=    1
> 
>  
> 
>  CMAKE_OFF=    BUILD_INFO \
> 
>          BUILD_TESTING \
> 
> +        ENABLE_GCOV \
> 
> +        NO_UNDEFINED \
> 
> +        USE_VALGRIND \
> 
> +        WITH_INTERNAL_SQLITE3 \
> 
>          WITH_RUST
> 
> -CMAKE_ON=    WITH_SQLITE3
> 
> +CMAKE_ON=    BUILD_SHARED_LIBS \
> 
> +        WITH_SQLITE3
> 
> +CMAKE_TESTING_PARALLEL_LEVEL=    1    # https://github.com/chewing/libchewing/issues/293
> 
> +USE_LDCONFIG=    yes
> 
>  
> 
>  .include <bsd.port.mk> [http://bsd.port.mk>];
> 
> diff --git a/chinese/libchewing/distinfo b/chinese/libchewing/distinfo
> 
> index 401a80367dce..afce409cb771 100644
> 
> --- a/chinese/libchewing/distinfo
> 
> +++ b/chinese/libchewing/distinfo
> 
> @@ -1,3 +1,3 @@
> 
> -TIMESTAMP = 1717657425
> 
> -SHA256 (libchewing-0.8.4.tar.zst) = c272e85c9aff03265db08641cac25709b9faf45b4602e04ea6cb39317103b3fa
> 
> -SIZE (libchewing-0.8.4.tar.zst) = 4967750
> 
> +TIMESTAMP = 1721822994
> 
> +SHA256 (libchewing-0.8.5.tar.zst) = 472881fc7df7f1bc90383937c504589d80d542b5f2c4c5c007017c13a21f534e
> 
> +SIZE (libchewing-0.8.5.tar.zst) = 4969263
> 
> diff --git a/chinese/libchewing/pkg-descr b/chinese/libchewing/pkg-descr
> 
> index 825f31a9af7c..97e7507cafe2 100644
> 
> --- a/chinese/libchewing/pkg-descr
> 
> +++ b/chinese/libchewing/pkg-descr
> 
> @@ -1 +1,7 @@
> 
> -Chewing - An Intelligent Chinese Phonetic Input Method for UNIX
> 
> +The Chewing is an intelligent phonetic input method (Zhuyin/Bopomofo) and is one
> 
> +of the most popular choices for Traditional Chinese users. Chewing was inspired
> 
> +by other proprietary intelligent Zhuyin input methods on Microsoft Windows,
> 
> +namely Wang-Xin by Eten, Microsoft New Zhuyin, and Nature Zhuyin (aka Going).
> 
> +The Chewing developer maintains the project as a fully open-source effort,
> 
> +positioning it as a leading libre intelligent phonetic solution among major
> 
> +operating environments.
> 
> diff --git a/chinese/libchewing/pkg-plist b/chinese/libchewing/pkg-plist
> 
> index 32e8481bd0d5..61c6bc9abc80 100644
> 
> --- a/chinese/libchewing/pkg-plist
> 
> +++ b/chinese/libchewing/pkg-plist
> 
> @@ -1,6 +1,6 @@
> 
> +include/chewing/chewing-compat.h
> 
>  include/chewing/chewing.h
> 
>  include/chewing/chewingio.h
> 
> -include/chewing/chewing-compat.h
> 
>  include/chewing/global.h
> 
>  include/chewing/mod_aux.h
> 
>  lib/libchewing.so [http://libchewing.so]

Hi,

Can you please stop doing regression to ports that goes against
Porters Handbook and why add a lot of noise for options that aren't
needed as in not changed from defaults?

https://docs.freebsd.org/en/books/porters-handbook/book/#porting-pkgname
This has been in Porters Handbook for years by now

Any reason as to why NO_UNDEFINED is disabled (this seems to be a
mistake)?

Best regards,

Daniel