From nobody Tue Jul 16 11:46:54 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WNcjt1NxXz5R8ny; Tue, 16 Jul 2024 11:46:58 +0000 (UTC) (envelope-from uzsolt@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WNcjt0k9Yz44fd; Tue, 16 Jul 2024 11:46:58 +0000 (UTC) (envelope-from uzsolt@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1721130418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7XzqxzrtTWwRPAMSjW3hThBlPP+Ontvh99/Vqj2EnFI=; b=t27y5wew0yyPCx6M6LN11Y2rSlLbIJqpN9+8LdCAemvNh7bgc4gUK7shLJZQDxJBs7X3ZA blc78GQl6haCOuxFZyaoXLmrzsM/c9GXS15wOt54tF16xHvvuZpPWIno138u9RjALwysja +SgT8Afm46HAGJ5vVfiYIu3tJSvAmGzUqsRtQFrCTzNCahVgds5Sc8+BwI0Tub8TRV6g3y rA0q1x15hQzbi3mMg62euoRdLkAEv/epODTEkoSfz4yR64Ap2PTVbbena8B1+YWdEo97fG 7iQKuazA7WI0qm7Pm/7A9I+iA6icmwOv53pXIWCZREwN5n4vxAVbby/Obf/XoQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1721130418; a=rsa-sha256; cv=none; b=aUxRIYMlSrSUurUZ0pKu2USIPEhxEEWxmz3jikhXO7f38z58+8nHfO+f0y1L17ly9h32Te 0heN0X5M4BxRffAcpDsgv3gwWkbkMDnACOjAdF3Gy8zZIgrfqHARnvxtfT5WVXfVwFRyfW jkQrSrwV9MGCxD8m/AU4zEOhOPFWI3NiypJepbjiVSvuM13b5VCQt+gk4j0N71oLV50FAX QuZM9KIjYCyBTD8bDnTP72Q3NKmB8Jmf/lAGIv98MqaBOck8/BSOsoQe/MfCQVGkVvKN3D SvwcHMR98ZVyFzael42nilH1S1wmee2a6PjevQAgsaSiiVc0dJXjF69G6wwl6g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1721130418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7XzqxzrtTWwRPAMSjW3hThBlPP+Ontvh99/Vqj2EnFI=; b=pm/Y5+4G8nm874EdLf3nBcY3RMswLejid+3yxOlW3hnaFeEiL5RsKUHrkHrc+iOO+bZDzu H4+zsZOrpmPK9nLSDNt5aQ74lMhTIfpVkoKzPUmP4maQfhBCY8t8jhmjccL40+aaqV+RbJ GmimHYh5C5SI9kYdVWaKRzGT8wJY3+Rxhphu1UC2KqSNIR45qtzTFayzeeLmH/B0FFOc9x TJ9X95vq1qsAWPoVl2nawdXjKw39SuaUYe1QTG7NvJPXdMI0AiGpj81YD4dZfFa7c++7Sr 53T8HgVLstdIxDII/mX/AH4oJ1abX91yDC6PHH1xErj6Ow+eVWoV+KBqoQ0rHw== Received: from bsd-zsolt (62-165-201-173.pool.digikabel.hu [62.165.201.173]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: uzsolt/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4WNcjs2gdyzXH7; Tue, 16 Jul 2024 11:46:57 +0000 (UTC) (envelope-from uzsolt@freebsd.org) Date: Tue, 16 Jul 2024 13:46:54 +0200 From: Zsolt Udvari To: Alexey Dokuchaev Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: d6a461ce6716 - main - games/lolcat: update to 1.5 Message-ID: References: <202407131836.46DIaqMZ075082@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jul 16, 2024 at 08:08:19AM +0000, Alexey Dokuchaev wrote: > PLIST_FILES are handy when there's few of them so it's easier to > keep all things in one place (the Makefile), also makes the diffs > shorter. Another good thing is that they are part of the options > helpers, so one can list one or more FOO_PLIST_FILES_[OFF] while > leaving the main pkg-plist less cluttered (no need for PLIST_SUBs). I'm not sure "keep all things in one place" is the most important. I prefer store everything in its own place and don't mix them, even if the diffs is longer a bit. Cluttered because of PLIST_SUB: yes, it's very ugly, many-many percent sign (I hate too). One possible solution: split the pkg-plist and the conditional parts go into separate files (e.g. pkg-plist.docs contains the documentations, without PLIST_SUB-like prefixes). It's only a beginner committer's opinion, I accept the established habits. Cheers, Zsolt