From nobody Tue Jul 16 11:13:26 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WNbzB6XX4z5R6Vy; Tue, 16 Jul 2024 11:13:26 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WNbzB5sHrz41hR; Tue, 16 Jul 2024 11:13:26 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1721128406; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hLoexyN8CcmgL7+IRzlZf4LDcRXs1++ts7po2Shgg9Y=; b=yUqemZjxgDX2aNOVqLt0L6lp4RyT5CFI0wLJ3NHVWMhq93fYzcfZKlH4y6WQ/w5H/Nf2Yy 6782gwyCTBT8+xJ83A+ZvRxMRJQLkBi0cVS5xz7DEfotJPMJxb7chdNjEIXKV3Wgh/9NWg j6pP2m9R/Rl0zplFRd3VKUf6Oo37GfoqcuB5LRsmZXMMub+xtRUnn33Jmifw13XuRV70J6 HU0GF8VdJ9YYfqzpb58kthW+TqSM+vpkxAYrZgocDAOPBssJfA+Gd/8OWWcvDokPhmRT+Y aBKNnu5U3LhorvkgszYAaQextpsg197jl2ww4N70SzR9s4FhB/q5NUbq1qM/+g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1721128406; a=rsa-sha256; cv=none; b=hrmGoWFeQIZWaRrGVunKuxt8hc1N1zi6AbeCQketw+cU5boY9VR2miwvllQA+JuD7NIWfS o9vIeVo/zPyOvujdMsRL3fNf+kdIL3hLICPavro71ZzcRGGDUbNtJxvJfAjRitT5P4yOXe +YHNqxSxZdFSVupocOodsNwe/w503EGU2NTNPdTYzML2b7F5+9PkflLCyEr/jMUx1a8B5a QZbP/TmIUdF3Uh90W0VEUBJwgxrG+L8xEU/G2VEG2LuugxEyIcTf7++iJxVrZrrxdvJPd1 moXsqxqq4ClCI9l76KUjFVdCGgJbTdiFopd4t//dXJmyS8sHC7BHslih1Ljxzg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1721128406; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hLoexyN8CcmgL7+IRzlZf4LDcRXs1++ts7po2Shgg9Y=; b=gkw0td2SujhKflFS4/fm3nygVOAkonEbFfC0wpl4FF8PhsmVWjWOMsxTXX7jIIMy153Z9R +jH91K+GYA+d7C9fPTtg5zgQakDSrP0x3NhsMFli+j9blXsP/VB60fmTfpb0tQtk9VKK66 EvNK91DVMA/XCLQfRv94ksu4PvnjJdwa132SjHKR3tpKqisXX+IcnQUWAiXSyeEdXLyvfc IoSMYp92dRhrTVw09aKRFDwKdW9mWuVmdoaYN6ApqSuViAZLzhhB3jMmehOBWI0PyewEFs QGlElrmWqCNtPuu730RGkd61o5IFJW6jSAPmGRLrxjEjkHPXv0WnLxUWT7x53g== Received: by freefall.freebsd.org (Postfix, from userid 1033) id AC9DA55AE; Tue, 16 Jul 2024 11:13:26 +0000 (UTC) Date: Tue, 16 Jul 2024 11:13:26 +0000 From: Alexey Dokuchaev To: Gleb Popov Cc: Dirk Meyer , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: a270dbfaa9ce - main - net/miniupnpc: Update to 2.2.8 Message-ID: References: <202407151201.46FC1C3N000509@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jul 16, 2024 at 10:04:49AM +0300, Gleb Popov wrote: > On Tue, Jul 16, 2024 at 9:08???AM Alexey Dokuchaev wrote: > > Also broke `net/dante' and people start getting upset. Dirk could you > > please test changes to your ports when they're dependencies for others > > next time? > > In Dirk's defense, the ABI breakage was introduced by the patch-level > version bump. I don't get it. When one is about to update some port with dependencies, they must ensure that the update doesn't break consumers, and if it does, patch those ports so they build against both current and planned version, retest, and only then push the update, so none the wiser. Instead, Dirk had broken a whole bunch of ports (PR 280304). Luckily, we probably can deal with it without reverting the update as the fix is trivial enough. ./danfe