Re: git: a270dbfaa9ce - main - net/miniupnpc: Update to 2.2.8
Date: Tue, 16 Jul 2024 11:13:26 UTC
On Tue, Jul 16, 2024 at 10:04:49AM +0300, Gleb Popov wrote: > On Tue, Jul 16, 2024 at 9:08???AM Alexey Dokuchaev wrote: > > Also broke `net/dante' and people start getting upset. Dirk could you > > please test changes to your ports when they're dependencies for others > > next time? > > In Dirk's defense, the ABI breakage was introduced by the patch-level > version bump. I don't get it. When one is about to update some port with dependencies, they must ensure that the update doesn't break consumers, and if it does, patch those ports so they build against both current and planned version, retest, and only then push the update, so none the wiser. Instead, Dirk had broken a whole bunch of ports (PR 280304). Luckily, we probably can deal with it without reverting the update as the fix is trivial enough. ./danfe