From nobody Sat Jul 13 16:49:27 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WLvZR6mQJz5Qgxq for ; Sat, 13 Jul 2024 16:49:35 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Received: from smtp-42a9.mail.infomaniak.ch (smtp-42a9.mail.infomaniak.ch [IPv6:2001:1600:7:10::42a9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "relay.mail.infomaniak.ch", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WLvZR451tz4jMV for ; Sat, 13 Jul 2024 16:49:35 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Authentication-Results: mx1.freebsd.org; none Received: from smtp-3-0001.mail.infomaniak.ch (smtp-3-0001.mail.infomaniak.ch [10.4.36.108]) by smtp-4-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4WLvZJ1dqZzJl4; Sat, 13 Jul 2024 18:49:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pyret.net; s=20231006; t=1720889368; bh=uZqpri+vLt14gcan7Jhy4pCNqisHrCafe/pTaO7WNRM=; h=Date:Subject:From:Reply-To:To:Cc:References:In-Reply-To:From; b=kF9iYaoggN0HV63p0RHVdhXaz2qDwhbV4Dw4FPgK+ocYiSJfVWElw80oWKkhWut+1 JBjCSYfqWsednIO0oIoaP0Z+e6LypUsIwl3yNO+9DWvN5bFHYpXJ5KC1YjgDJH33bi JZl96mtnIrS7GY/4s+TPxGuqvyOZFm7NcCmMCJbL2nN+HN5SR90kCOKJkR8g8REAS5 z4ghXfvA912q0X3bCg4vqZMW6129cnWM1DJL1QktaV7aUR8APWh09keK9jDqcIczwN UhsZ9ztJHWC9aOCYYzcigeqEhE/OeLoMUNtVX9T6jB0p6LRGT4byD3XAInKkYDhCaF /09VabhzJOtEg== Received: from unknown by smtp-3-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4WLvZH5HfRzTLk; Sat, 13 Jul 2024 18:49:27 +0200 (CEST) Message-ID: Date: Sat, 13 Jul 2024 18:49:27 +0200 Subject: Re: git: 06601897e5cd - main - framework: reintroduce the feature enabling code From: Daniel Engberg Reply-To: Daniel Engberg To: Mathieu Arnold Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, Baptiste Daroussin , "arrowd@FreeBSD.org" List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="_=_swift_1720889367_b53d715a89f570dc5586e0b6fcddbe74_=_" X-WS-User-Origin: eyJpdiI6IjYzNkpRREViNUI2Yi9NTkJKeXZKY3c9PSIsInZhbHVlIjoidG1YY3ZvZ0NKdU04R3hobDdvZWc0dz09IiwibWFjIjoiNzk1OGM0NWUwYTdjYWI1NGMyMTNlOGVjM2Y2OWRiMDU1ZTBmM2VhYTc2NGI1ZmMwOWM5MDljMGM4ZGUyYWU3MSIsInRhZyI6IiJ9 X-WS-User-Mbox: eyJpdiI6ImlscE9mZnhoNUNaYTd6dzFMQXhkYVE9PSIsInZhbHVlIjoiQ1NhdzdZZUp5Z0VTbldYMlIvOGlDQT09IiwibWFjIjoiNmUxYjQ4NTk2NDk2ZGUzOGY0ZjU0NDcwZjUzOGQ4MTdhZDNjNDBkMTVjY2MzYWVhNWI5M2M0M2Y4NzViNzNhNiIsInRhZyI6IiJ9 X-WS-Location: eJxzKUpMKykGAAfpAmU- X-Mailer: Infomaniak Workspace (1.3.716) References: <202404120754.43C7slbr026326@gitrepo.freebsd.org> <12af8e210220224883a7856115f61be9@mail.infomaniak.com> <6kivt3yarts23vqyv277vqrw6dhswo4hilbdkspvnaz544mtvc@yiyqgdtnp6y7> <457bab3436f42fd12d80beb16e067cf0@mail.infomaniak.com> <4cvwsu7vebcrzorvjygkhzefbnjq2cegtobxbybxpglltsla3k@637dblgngbon> In-Reply-To: <4cvwsu7vebcrzorvjygkhzefbnjq2cegtobxbybxpglltsla3k@637dblgngbon> X-Infomaniak-Routing: alpha X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:29222, ipnet:2001:1600::/32, country:CH] X-Rspamd-Queue-Id: 4WLvZR451tz4jMV --_=_swift_1720889367_b53d715a89f570dc5586e0b6fcddbe74_=_ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2024-07-13T16:30:31.000+02:00, Mathieu Arnold wrote:= >=C2=A0On=C2=A0Sat,=C2=A0Jul=C2=A013,=C2=A02024=C2=A0at=C2=A002:04:48= PM=C2=A0GMT,=C2=A0Daniel=C2=A0Engberg=C2=A0wrote: >>=C2=A0=C2=A0On=C2= =A02024-07-13T08:47:47.000+02:00,=C2=A0Mathieu=C2=A0Arnold >>=C2=A0=C2= =A0 >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0wrote: >>= =C2=A0=C2=A0 >>>=C2=A0=C2=A0=C2=A0On=C2=A0Sat,=C2=A0Jul=C2=A013,=C2=A0202= 4=C2=A0at=C2=A006:11:04AM=C2=A0GMT,=C2=A0Daniel=C2=A0Engberg=C2=A0wrote: = >>>=C2=A0=C2=A0=C2=A0 >>>>=C2=A0=C2=A0=C2=A0=C2=A0Hi, >>>>=C2=A0=C2= =A0=C2=A0=C2=A0 >>>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0This=C2=A0changes=C2= =A0so=C2=A0LTO=C2=A0option=C2=A0is=C2=A0no=C2=A0longer=C2=A0applied=C2= =A0to=C2=A0Rust >>>>=C2=A0=C2=A0=C2=A0=C2=A0(cargo) >>>>=C2=A0=C2=A0= =C2=A0=C2=A0 >>>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0ports >>>>=C2=A0=C2= =A0=C2=A0=C2=A0 >>>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0BY=C2=A0DEFAULT=C2= =A0causing=C2=A0a=C2=A0regresssion,=C2=A0please=C2=A0fix. >>>=C2=A0=C2= =A0=C2=A0 >>>=C2=A0=C2=A0=C2=A0=C2=A0As=C2=A0it=C2=A0has=C2=A0been=C2= =A0three=C2=A0months,=C2=A0nobody=C2=A0complained=C2=A0something=C2=A0was= >>>=C2=A0=C2=A0=C2=A0broken >>>=C2=A0=C2=A0=C2=A0 >>>=C2=A0=C2=A0= =C2=A0=C2=A0so, >>>=C2=A0=C2=A0=C2=A0 >>>=C2=A0=C2=A0=C2=A0=C2=A0I= =C2=A0don't=C2=A0think=C2=A0anything=C2=A0is=C2=A0actually=C2=A0broken. >= >>=C2=A0=C2=A0=C2=A0 >>>=C2=A0=C2=A0=C2=A0=C2=A0LTO=C2=A0as=C2=A0are= =C2=A0a=C2=A0few=C2=A0other=C2=A0features=C2=A0like=C2=A0SSP=C2=A0are=C2= =A0user=C2=A0facing >>>=C2=A0=C2=A0=C2=A0features, >>>=C2=A0=C2=A0= =C2=A0 >>>=C2=A0=C2=A0=C2=A0=C2=A0not=C2=A0a >>>=C2=A0=C2=A0=C2=A0 >>= >=C2=A0=C2=A0=C2=A0=C2=A0porters=C2=A0facing=C2=A0options,=C2=A0it=C2=A0mea= ns,=C2=A0it's=C2=A0up=C2=A0to=C2=A0the=C2=A0person=C2=A0doing >>>=C2= =A0=C2=A0=C2=A0the >>>=C2=A0=C2=A0=C2=A0 >>>=C2=A0=C2=A0=C2=A0=C2=A0bui= lding=C2=A0to=C2=A0choose=C2=A0wether=C2=A0to=C2=A0enable=C2=A0it=C2=A0or= =C2=A0not,=C2=A0it=C2=A0is=C2=A0**not**=C2=A0up >>>=C2=A0=C2=A0=C2=A0to= >>>=C2=A0=C2=A0=C2=A0 >>>=C2=A0=C2=A0=C2=A0=C2=A0the >>>=C2=A0=C2= =A0=C2=A0 >>>=C2=A0=C2=A0=C2=A0=C2=A0person=C2=A0porting=C2=A0the=C2= =A0software=C2=A0to=C2=A0forcefully=C2=A0enable=C2=A0it. >>>=C2=A0=C2= =A0=C2=A0 >>>=C2=A0=C2=A0=C2=A0=C2=A0--=C2=A0 >>>=C2=A0=C2=A0=C2=A0 >= >>=C2=A0=C2=A0=C2=A0=C2=A0Mathieu=C2=A0Arnold >>=C2=A0=C2=A0 >>=C2= =A0=C2=A0=C2=A0Hi, >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0Likely=C2=A0becau= se=C2=A0this=C2=A0pretty=C2=A0much=C2=A0silently=C2=A0went=C2=A0by=C2=A0bec= ause=C2=A0it=C2=A0was >>=C2=A0=C2=A0posted >>=C2=A0=C2=A0 >>=C2=A0= =C2=A0=C2=A0on=C2=A0Phab=C2=A0and=C2=A0you=C2=A0only=C2=A0CCed=C2=A0bapt.= =C2=A0It's=C2=A0been=C2=A0enabled=C2=A0since=C2=A0Jan=C2=A02023 >>=C2= =A0=C2=A0 >>=C2=A0=C2=A0=C2=A0(https://cgit.freebsd.org/ports/commit/Mk/U= ses/cargo.mk?id=3D967022fd812cf67dec264ee4e53bd016b69e7a2b) >>=C2=A0= =C2=A0 >>=C2=A0=C2=A0=C2=A0and=C2=A0tested/discussed=C2=A0here=C2=A0https= ://reviews.freebsd.org/D36736 >>=C2=A0=C2=A0before >>=C2=A0=C2=A0 >>= =C2=A0=C2=A0=C2=A0being=C2=A0enabled/committed.=C2=A0I=C2=A0noticed=C2= =A0it=C2=A0now=C2=A0while=C2=A0updating=C2=A0a=C2=A0Rust >>=C2=A0=C2= =A0 >>=C2=A0=C2=A0=C2=A0(cargo-based)=C2=A0port. >=C2=A0 >=C2=A0Mmmm,= =C2=A0yes,=C2=A0I=C2=A0know=C2=A0about=C2=A0that,=C2=A0and=C2=A0I=C2=A0agre= e,=C2=A0this=C2=A0commits=C2=A0reverts=C2=A0this >=C2=A0 >=C2=A0behavio= r. >=C2=A0 >=C2=A0Because=C2=A0choosing=C2=A0to=C2=A0build=C2=A0with= =C2=A0or=C2=A0without=C2=A0LTO=C2=A0is=C2=A0a=C2=A0user=C2=A0facing >= =C2=A0feature, >=C2=A0 >=C2=A0not=C2=A0a=C2=A0porter=C2=A0facing=C2= =A0feature,=C2=A0so,=C2=A0it=C2=A0has=C2=A0to=C2=A0be=C2=A0set=C2=A0by= =C2=A0people=C2=A0building >=C2=A0the >=C2=A0 >=C2=A0things,=C2=A0not= =C2=A0by=C2=A0the=C2=A0framework=C2=A0or=C2=A0a=C2=A0port. >=C2=A0 >= =C2=A0--=C2=A0 >=C2=A0 >=C2=A0Mathieu=C2=A0Arnold Hi, Given t= hat it was commonly agreed upon as a sane default I don't see how your op= inion in this case weights more. That being said, any option could be def= ined as user facing option some of which are already agreed upon as sane = such as DOCS and EXAMPLES. Best regards, Daniel --_=_swift_1720889367_b53d715a89f570dc5586e0b6fcddbe74_=_ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
On 2024-07-13T16:30:31.000+02:00, Mathieu Arnold <mat@f= reebsd.org> wrote:
On Sat, Jul 13, 2024 at 02:04:48PM GMT, Daniel Engberg wrote:
  On 2024-07-13T08:47:47.000+02:00=
, Mathieu Arnold <mat@freebsd.org>
 wrote:
 
   On Sat, Jul 13, 2024 at 06:11:=
04AM GMT, Daniel Engberg wrote:
=

    Hi,
   
    This changes so LTO option=
 is no longer applied to Rust (cargo)
   ports
=
   
    BY DEFAULT causing a regresssion, please fix.
   
  As it has been three months, nobody=
 complained something was broken
  so,
  
  I don't think anything is actually broken.
  
<=
/div>
  LTO as are a few other features like SSP are user facing featur=
es,
  not a
  
  porters facing o=
ptions, it means, it's up to the person doing the
  
  building to choose wether to enable it or not, it is **not** up to<=
br>
  the
  
  person porting the sof=
tware to forcefully enable it.
  
  -- 
  
  Mathieu Arnold
  
<=
/div>
 Hi,
 
 Likely because this pretty mu=
ch silently went by because it was posted
 on Phab and you on=
ly CCed bapt. It's been enabled since Jan 2023
 being enabled/committed. I noticed it now while updati=
ng a Rust
 (cargo-based) port.
 
Mmmm, yes, I know about that, and I agree, this commits revert=
s this
behavior.

Because choosin=
g to build with or without LTO is a user facing feature,
not =
a porter facing feature, so, it has to be set by people building the
things, not by the framework or a port.

-- 
Mathieu Arnold
H= i,

Given that it was commonly agreed upon as a= sane default I don't see how your opinion in this case weights more. That = being said, any option could be defined as user facing option some of which= are already agreed upon as sane such as DOCS and EXAMPLES.
<= br>
Best regards,
Daniel
--_=_swift_1720889367_b53d715a89f570dc5586e0b6fcddbe74_=_--