From nobody Sat Jul 13 14:30:31 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WLrV2099Cz5QPpw; Sat, 13 Jul 2024 14:30:34 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WLrV16nsFz4V02; Sat, 13 Jul 2024 14:30:33 +0000 (UTC) (envelope-from mat@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1720881034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=++IRFSEkuvZA1UMNeW//bp3On+7L7iAdl0qzLqTFrJ8=; b=VrzEijAad7N5Xr5a7/Ahj0ZBOMsNIN6Yrt+cBVskR/O38d5hgpXsb+nQCw1H/OTUT9/1rF sTgyiw2lP8rrP3XjU/j1BGiAFHjuGmEu8v/APs7I3MZfMV3VtR16D+HIKFPYRmNObkU8v0 z1EkFq3Kh1NOoyRDLjavcMUbjQBoGVJu+Fv+/rxz/XpKCxmbWh6mFFtkqb2ukACUj9frM+ 6p9OJ1bek2157DNWWEuN6IvyQWbvLVs0IY2tsEfUaEMzAIyb/0diAV9hWWJAEhFvL/LY4M Fr2zwZyPeIFaz+xhoJqBL5p5DuaKtJV24XwQ+WQ9Rq94vSnavD+Nt6M3zvzmFA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1720881034; a=rsa-sha256; cv=none; b=yq2u3fCmSvxBhLOrWmgGNBCWW0R7Ju88iE8scCYKWgqL8vREDAa0WDFhojtYXljxalN47o xw1S2ZepxXoJCaBCpYrR2Ku1BFt2qIbhumrF2L8WQeW4nZ8FYNJysDBr0XajegZaMmtpTJ Nk8pu3G+UxaLF0rLBbx2lxAFw3/6yj3ZwKrnkRd595nsyhzlGy9KqDTTD4206+GOvLpXK5 EGFdjrEoCatjgyk52d3tAaKIVtbq5kHKXsLQT42InUTvhtQUL8GF2+Nrc/3kLskhk/4tFE 2rFrKDbHj7kcr9YtXWjIs/iBgEU4z16IRqPBpFHjJH1TGA0iuyoV3BSphzHAXw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1720881034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=++IRFSEkuvZA1UMNeW//bp3On+7L7iAdl0qzLqTFrJ8=; b=Of6VbIkgqOFwYi1zLKXPpiqkRPBdyiJJn/UNVDXcD1IryWJs53xuRXLhSdmvWsHzh+QV3b 2+5iHi9/sG/0qZH8/6pp1RRpmmyaDKfbUEx+SlVHsR//2Fct9V1gHgbGhgJuGvi1HqXQCF D46znJBD/hBA5FwxqNxn1MPQ/GBKWapZcuVzM0VLT2SMLqXZ1cmEiwsc2IGRs5RFVDbl80 c+TC+m/JZlEKBVp4uljFJhm8dLLFH9kWQVmPV6JM15il4jEpBIFHlkQePBj4RqHUsssxgq KVRGuiEho18Jg1HRc1ghbdujMSGRxbmIPntl9xOPWbTJZrSL0mycbnDubcQ/qA== Received: from relay.mat.cc (eqx1.mat.cc [79.143.244.49]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "cow.mat.cc", Issuer "R11" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4WLrV15dyfz1K04; Sat, 13 Jul 2024 14:30:33 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from aching.in.mat.cc (unknown [IPv6:2a01:e0a:836:f670:7832:d9d7:c2af:d611]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by relay.mat.cc (Postfix) with ESMTPSA id CC4B22027B; Sat, 13 Jul 2024 16:30:32 +0200 (CEST) Date: Sat, 13 Jul 2024 16:30:31 +0200 From: Mathieu Arnold To: Daniel Engberg Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, Baptiste Daroussin , "arrowd@FreeBSD.org" Subject: Re: git: 06601897e5cd - main - framework: reintroduce the feature enabling code Message-ID: <4cvwsu7vebcrzorvjygkhzefbnjq2cegtobxbybxpglltsla3k@637dblgngbon> References: <202404120754.43C7slbr026326@gitrepo.freebsd.org> <12af8e210220224883a7856115f61be9@mail.infomaniak.com> <6kivt3yarts23vqyv277vqrw6dhswo4hilbdkspvnaz544mtvc@yiyqgdtnp6y7> <457bab3436f42fd12d80beb16e067cf0@mail.infomaniak.com> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4egqw45pseg2fke7" Content-Disposition: inline In-Reply-To: <457bab3436f42fd12d80beb16e067cf0@mail.infomaniak.com> --4egqw45pseg2fke7 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jul 13, 2024 at 02:04:48PM GMT, Daniel Engberg wrote: > On 2024-07-13T08:47:47.000+02:00, Mathieu Arnold > wrote: >=20 > >=A0On=A0Sat,=A0Jul=A013,=A02024=A0at=A006:11:04AM=A0GMT,=A0Daniel=A0Engb= erg=A0wrote: > >>=A0=A0Hi, > >>=A0=A0 > >>=A0=A0=A0This=A0changes=A0so=A0LTO=A0option=A0is=A0no=A0longer=A0applie= d=A0to=A0Rust=A0(cargo) > >>=A0=A0ports > >>=A0=A0 > >>=A0=A0=A0BY=A0DEFAULT=A0causing=A0a=A0regresssion,=A0please=A0fix. > >=A0 > >=A0As=A0it=A0has=A0been=A0three=A0months,=A0nobody=A0complained=A0someth= ing=A0was=A0broken > >=A0so, > >=A0 > >=A0I=A0don't=A0think=A0anything=A0is=A0actually=A0broken. > >=A0 > >=A0LTO=A0as=A0are=A0a=A0few=A0other=A0features=A0like=A0SSP=A0are=A0user= =A0facing=A0features, > >=A0not=A0a > >=A0 > >=A0porters=A0facing=A0options,=A0it=A0means,=A0it's=A0up=A0to=A0the=A0pe= rson=A0doing=A0the > >=A0 > >=A0building=A0to=A0choose=A0wether=A0to=A0enable=A0it=A0or=A0not,=A0it= =A0is=A0**not**=A0up=A0to > >=A0the > >=A0 > >=A0person=A0porting=A0the=A0software=A0to=A0forcefully=A0enable=A0it. > >=A0 > >=A0--=A0 > >=A0 > >=A0Mathieu=A0Arnold >=20 > Hi, >=20 > Likely because this pretty much silently went by because it was posted > on Phab and you only CCed bapt. It's been enabled since Jan 2023 > (https://cgit.freebsd.org/ports/commit/Mk/Uses/cargo.mk?id=3D967022fd812c= f67dec264ee4e53bd016b69e7a2b) > and tested/discussed here https://reviews.freebsd.org/D36736 before > being enabled/committed. I noticed it now while updating a Rust > (cargo-based) port. Mmmm, yes, I know about that, and I agree, this commits reverts this behavior. Because choosing to build with or without LTO is a user facing feature, not a porter facing feature, so, it has to be set by people building the things, not by the framework or a port. --=20 Mathieu Arnold --4egqw45pseg2fke7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmaSj4VfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb6UiQwAopiCerCaC9PrO4JttiyfdI8koUIbkUnTQZ3L3EnqVI1wvDGXApVhxnV+ XvKgQNnEVtC7gPDRyxc1c7u9DnKA3pu+6fiv0DXD+8lM3psKag5fiXHbTKNrFg/S +QN+Wm6xpk78kUN/PDJyKAPizb/nN3vpqosBSREP7WR/q9LX8mDLiUvtnJmvK2e+ HRnXVnk2bkvt2Pwf6lzyYg1pvzjt5jeXA9RtQIuQ12F8lm11K+0xCqitSP1zpgXf 3uqCkZDQUplwAW3ftDow9qwpzmc/BeqOKDAwxjchWCTT31M6IroKKmIiTobf1BtN 0TJLqmzy+2rfb/d4gPpZm/Hi5AuTv1I/9s4S6h0WXzya2a7p7xeKcjKYhFIXV1PT 4hc/ntw/ZjElejFuRIZosXpWjFpF3MmSFHm1s3QG2MtFb115hK5Yf2rAq20vkX9z BcXaakm746U2B/oFO7MlmCBNS6OTkMg1cG850HquGqDaCos3oYhC01qWlQR+Y8hI 6qxaN3Mm =V2oJ -----END PGP SIGNATURE----- --4egqw45pseg2fke7--