From nobody Sat Jul 13 08:27:37 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WLhRp6pfBz5QGLG; Sat, 13 Jul 2024 08:28:06 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: from mail-ua1-f54.google.com (mail-ua1-f54.google.com [209.85.222.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WLhRp2P9fz57Dd; Sat, 13 Jul 2024 08:28:06 +0000 (UTC) (envelope-from 6yearold@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ua1-f54.google.com with SMTP id a1e0cc1a2514c-81013580bd5so857575241.0; Sat, 13 Jul 2024 01:28:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720859285; x=1721464085; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Es2cpi2yUrSI7NFkjslx01NIFY97wQPb43lALMqwtLU=; b=I711qmCu1R+hueKFr8z/pnZ5GWcams7fs+NQ9ayNOggs703Dn76JYn7g/Y5EA7bdgc 5XB80qyXE92+PRynOpOQCJk/3CxfrtYtK2mlnWhVFxTjcWS4rMbZF3baAc9r4MNNgowl mO4C/KjutZkdsYuMJnDEzM324x3s5ay3Pvq0Z6GnUG0hZuUeRc8ZU81vwvoYbHqE+A3R bBh7ibsD0vtWC7E/tv9MFlyHtQEfi1Vg2ySlopV4yHmuab94W3JvX+5LfgoOnjYbdeH6 /TiSN6mHb+rx50548mQPp1EBSJAjtni6Pi/MPbo7E2Lx8nrm4Ftczagj3rrKpyTw4AKo SxKQ== X-Forwarded-Encrypted: i=1; AJvYcCXxjBp0bj8hmQ9DSAYfh+9FeQjXP+fHkdtPkWHdEPtHGxfzbXr4vu0UqxZ1xTklWdyvPi7udJAAGhUR6BXTUvJ2S6xzVbXCVhXSgu0F7YIkN6QqImRMlX7CwdC0ZqHJf6IaiLY4nh4eRCg8rkzN07g1dIoWd1VmsohowmNnlrujOziBntDmM2mnZRMokowLDV6zU3LPdomvGQnaVoJe+FHPBjp/uOg= X-Gm-Message-State: AOJu0YxmVxYAISvMM3QS0svhodR1gkDPDk1VmruITFqak6i8K5vNwfnP T/y0fDJYA0OHiIKTD/eMydcpmiUw+IBObpL8dqpoA3EtyHIJV0GLmW2N4UglFbg= X-Google-Smtp-Source: AGHT+IFrOYL+6EeXMaf1p9sCi/FhwkRJ1s+4f+BwHfwX+QzNbk5J5vfaFMBkxYyn9f7k2/a/pUqWyQ== X-Received: by 2002:a05:6102:32c2:b0:48f:3e91:12d5 with SMTP id ada2fe7eead31-490320e876dmr13615736137.1.1720859284755; Sat, 13 Jul 2024 01:28:04 -0700 (PDT) Received: from mail-vk1-f176.google.com (mail-vk1-f176.google.com. [209.85.221.176]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-814fffe8f55sm119770241.16.2024.07.13.01.28.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 Jul 2024 01:28:04 -0700 (PDT) Received: by mail-vk1-f176.google.com with SMTP id 71dfb90a1353d-4ef765e6dcaso884885e0c.1; Sat, 13 Jul 2024 01:28:04 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWRMXDgLJUe4pWB/ADY0brB1s9QuRKQQJaEWhQd1KRXcDGL2wkgnx4+iW5mHvEK3dDskTNZuavnx2osomneACSrPUEGOx0qXBoS4LRBntseUkCWLFL40oxzH9RjFy2n2GXlrwvkBqRZvNY8nOqbWdFHFhwXSyMpwYmmLizamAhwr4bbnQdONT1Yb+M5iHNTdPRwYVo0U1H49fFvHNjNv4kfIm6AbIo= X-Received: by 2002:a05:6122:2887:b0:4df:261c:fc0c with SMTP id 71dfb90a1353d-4f33f30ae9amr14584469e0c.13.1720859284219; Sat, 13 Jul 2024 01:28:04 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 References: <202404120754.43C7slbr026326@gitrepo.freebsd.org> <12af8e210220224883a7856115f61be9@mail.infomaniak.com> <6kivt3yarts23vqyv277vqrw6dhswo4hilbdkspvnaz544mtvc@yiyqgdtnp6y7> In-Reply-To: <6kivt3yarts23vqyv277vqrw6dhswo4hilbdkspvnaz544mtvc@yiyqgdtnp6y7> From: Gleb Popov Date: Sat, 13 Jul 2024 11:27:37 +0300 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 06601897e5cd - main - framework: reintroduce the feature enabling code To: Mathieu Arnold Cc: Daniel Engberg , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, Baptiste Daroussin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4WLhRp2P9fz57Dd On Sat, Jul 13, 2024 at 9:47=E2=80=AFAM Mathieu Arnold wr= ote: > > On Sat, Jul 13, 2024 at 06:11:04AM GMT, Daniel Engberg wrote: > > Hi, > > > > This changes so LTO option is no longer applied to Rust (cargo) ports > > BY DEFAULT causing a regresssion, please fix. > > As it has been three months, nobody complained something was broken so, > I don't think anything is actually broken. Funny, this was exactly my argument when you were reverting my implementati= on. > LTO as are a few other features like SSP are user facing features, not a porters facing options, it means, it's up to the person doing the building to choose wether to enable it or not, it is **not** up to the person porting the software to forcefully enable it. I don't agree with that and talked about it in my writeup [1], which seemingly no one in portmgr@ cared to read. [1] https://reviews.freebsd.org/D44789