From nobody Sat Jul 13 04:11:04 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WLZlQ3x9yz5PHJk for ; Sat, 13 Jul 2024 04:11:14 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Received: from smtp-bc0a.mail.infomaniak.ch (smtp-bc0a.mail.infomaniak.ch [IPv6:2001:1600:4:17::bc0a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "relay.mail.infomaniak.ch", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WLZlN0nPCz4gZ7 for ; Sat, 13 Jul 2024 04:11:12 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=pyret.net header.s=20231006 header.b=TvBEGyxZ; dmarc=pass (policy=reject) header.from=pyret.net; spf=pass (mx1.freebsd.org: domain of daniel.engberg.lists@pyret.net designates 2001:1600:4:17::bc0a as permitted sender) smtp.mailfrom=daniel.engberg.lists@pyret.net Received: from smtp-4-0001.mail.infomaniak.ch (smtp-4-0001.mail.infomaniak.ch [10.7.10.108]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4WLZlD6XWWzVJT; Sat, 13 Jul 2024 06:11:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pyret.net; s=20231006; t=1720843864; bh=4eH/wsCNYSoBwIszvORyVF5l+aUWiSbyfpT9ryTPLS0=; h=Date:Subject:From:Reply-To:To:Cc:References:In-Reply-To:From; b=TvBEGyxZJr6AykHKijxGdgpkljCPOLyZWNS+Oa8iIHnY1DZdjVyEZKqxCNa5wKD0N puGjytT5BJbnjkAmOpESk4/Sc2wWmId+WCY+HZ5gsG+i9VYCOTMFVlgpDOA6ebn2H/ C13Y7ygrwZh4C0DZqbRixu0CjZu0wg7yaF/THdbc1QIkhviRFfYcvEnuABrh53dZLq SSXDEf1NPli9zV/Nas5MhN3REEtiigBnrhUlycAnOGDnM9Xq5u2Ksid50HeEaqGrCv hXeV+sHAsA/FWm6kVZ9z+YlP4qE7/NNLBtbzkw7Rkzqf/ehVXKgbAMVZz5t0UAfrbt woZXkruGJA7SA== Received: from unknown by smtp-4-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4WLZlD3RdlzJln; Sat, 13 Jul 2024 06:11:04 +0200 (CEST) Message-ID: <12af8e210220224883a7856115f61be9@mail.infomaniak.com> Date: Sat, 13 Jul 2024 06:11:04 +0200 Subject: Re: git: 06601897e5cd - main - framework: reintroduce the feature enabling code From: Daniel Engberg Reply-To: Daniel Engberg To: Mathieu Arnold Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org, Baptiste Daroussin List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="_=_swift_1720843864_ee7b271ff312a5e000ad236f2a163824_=_" X-WS-User-Origin: eyJpdiI6IkFXdWU2dUhKZlJPZmR2czVhaEVwTVE9PSIsInZhbHVlIjoiMlU0SmRLeHAzUldZN1EvenlUdytlQT09IiwibWFjIjoiMTAyZmMxYzg3OTdlOGYxODFmODkzNGYwMGNlZDdmNGVhNTNlMmYzMTM3YTM1ZDM1Y2IwOGVmOTA0MDllYmMwOCIsInRhZyI6IiJ9 X-WS-User-Mbox: eyJpdiI6InoyZ1daVmVZTDF4aE5IYUdZRGxoSGc9PSIsInZhbHVlIjoiNlVMRS9yWVI1RmV2ekV1anpBNWg5Zz09IiwibWFjIjoiODNhOTJjMjc5ZGI2NGRjMmY1YjNhZDZiNTMzMGE0NmE0MDYwNjVmMmQzYWJlYTBkZjM2M2M3MzE3YTcxYmI0OSIsInRhZyI6IiJ9 X-WS-Location: eJxzKUpMKykGAAfpAmU- X-Mailer: Infomaniak Workspace (1.3.716) References: <202404120754.43C7slbr026326@gitrepo.freebsd.org> In-Reply-To: <202404120754.43C7slbr026326@gitrepo.freebsd.org> X-Infomaniak-Routing: alpha X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.92 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.92)[-0.923]; DMARC_POLICY_ALLOW(-0.50)[pyret.net,reject]; R_DKIM_ALLOW(-0.20)[pyret.net:s=20231006]; R_SPF_ALLOW(-0.20)[+ip6:2001:1600:4:17::/64]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ASN(0.00)[asn:29222, ipnet:2001:1600::/32, country:CH]; DKIM_TRACE(0.00)[pyret.net:+]; RCPT_COUNT_FIVE(0.00)[5]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-ports-main@FreeBSD.org]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_LAST(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; HAS_REPLYTO(0.00)[daniel.engberg.lists@pyret.net]; REPLYTO_EQ_FROM(0.00)[] X-Rspamd-Queue-Id: 4WLZlN0nPCz4gZ7 --_=_swift_1720843864_ee7b271ff312a5e000ad236f2a163824_=_ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2024-04-12T09:54:47.000+02:00, Mathieu Arnold wrote:= >=C2=A0The=C2=A0branch=C2=A0main=C2=A0has=C2=A0been=C2=A0updated= =C2=A0by=C2=A0mat: >=C2=A0 >=C2=A0URL:=C2=A0https://cgit.FreeBSD.org/po= rts/commit/?id=3D06601897e5cd4afcc31f3b508b2cbb2bc7d4a677 >=C2=A0 >= =C2=A0commit=C2=A006601897e5cd4afcc31f3b508b2cbb2bc7d4a677 >=C2=A0 >= =C2=A0Author:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Mathieu=C2=A0Arnold=C2=A0 >=C2=A0 >=C2=A0AuthorDate:=C2=A02024-04-12=C2=A007:49:01= =C2=A0+0000 >=C2=A0 >=C2=A0Commit:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Mathieu= =C2=A0Arnold=C2=A0 >=C2=A0 >=C2=A0CommitDate:=C2=A0202= 4-04-12=C2=A007:53:27=C2=A0+0000 >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0framework:=C2=A0reintroduce=C2=A0the=C2=A0feature=C2=A0enabling=C2= =A0code >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >=C2=A0 >=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0For=C2=A0each=C2=A0feature=C2=A0(see=C2=A0in=C2= =A0Mk/Features)=C2=A0users=C2=A0can=C2=A0now=C2=A0set=C2=A0these=C2=A0varia= bles >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0in=C2=A0their=C2=A0make.con= f.=C2=A0Using=C2=A0LTO=C2=A0as=C2=A0an=C2=A0example. >=C2=A0 >=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0To= =C2=A0enable=C2=A0globally: >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >= =C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0WITH_LTO=3D=C2=A0yes = >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >=C2=A0 >=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0To=C2=A0disable=C2=A0globally=C2=A0(for=C2=A0example=C2= =A0ssp=C2=A0is=C2=A0enabled=C2=A0by=C2=A0default): >=C2=A0 >=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0WITHOUT_LTO=3D=C2=A0=C2=A0yes >=C2=A0 >=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0To=C2=A0enable= =C2=A0for=C2=A0a=C2=A0specific=C2=A0list=C2=A0of=C2=A0ports: >=C2=A0 >= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0WITH_LTO_PORTS=3D=C2=A0lang/perl5.36 >=C2=A0 >=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0To= =C2=A0disable=C2=A0for=C2=A0a=C2=A0specific=C2=A0list=C2=A0of=C2=A0ports:= >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >=C2=A0 >=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0WITHOUT_LTO_PORTS=3D=C2=A0lang/perl5.36 >= =C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >=C2=A0 >=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0Differential=C2=A0Revision:=C2=A0=C2=A0https://reviews.freebsd.= org/D44750 >=C2=A0 >=C2=A0--- >=C2=A0 >=C2=A0=C2=A0Mk/Uses/cargo.mk= =C2=A0[http://cargo.mk]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0|=C2=A0=C2=A04=C2=A0+--- >=C2=A0 >=C2=A0=C2=A0Mk/bsd.= port.mk=C2=A0[http://bsd.port.mk]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A042=C2=A0+++++++++++++++++++++= +++++++++++++-------- >=C2=A0 >=C2=A0=C2=A0net-mgmt/net-snmp/Makefile= =C2=A0|=C2=A0=C2=A02=C2=A0+- >=C2=A0 >=C2=A0=C2=A03=C2=A0files=C2=A0cha= nged,=C2=A036=C2=A0insertions(+),=C2=A012=C2=A0deletions(-) >=C2=A0 >= =C2=A0diff=C2=A0--git=C2=A0a/Mk/Uses/cargo.mk=C2=A0[http://cargo.mk]=C2= =A0b/Mk/Uses/cargo.mk=C2=A0[http://cargo.mk] >=C2=A0 >=C2=A0index=C2= =A0e3b733d35821..8710374e3584=C2=A0100644 >=C2=A0 >=C2=A0---=C2=A0a/Mk/= Uses/cargo.mk=C2=A0[http://cargo.mk] >=C2=A0 >=C2=A0+++=C2=A0b/Mk/Uses/= cargo.mk=C2=A0[http://cargo.mk] >=C2=A0 >=C2=A0@@=C2=A0-139,10=C2=A0+13= 9,8=C2=A0@@=C2=A0CARGO_ENV+=3D=C2=A0\ >=C2=A0 >=C2=A0=C2=A0CARGO_ENV+= =3D=C2=A0=C2=A0=C2=A0=C2=A0RUST_BACKTRACE=3D1 >=C2=A0 >=C2=A0=C2=A0.= =C2=A0=C2=A0endif >=C2=A0 >=C2=A0=C2=A0 >=C2=A0 >=C2=A0-.=C2=A0= =C2=A0if=C2=A0!defined(_WITHOUT_LTO)=C2=A0&&=C2=A0(!defined(WITHOUT_LTO_POR= TS)=C2=A0||=C2=A0${WITHOUT_LTO_PORTS:N${PKGORIGIN}}) >=C2=A0 >=C2=A0+.= =C2=A0=C2=A0if=C2=A0defined(WITH_LTO) >=C2=A0 >=C2=A0=C2=A0_CARGO_MSG= =3D=C2=A0=C2=A0=C2=A0=C2=A0"=3D=3D=3D>=C2=A0=C2=A0=C2=A0Additional=C2=A0opt= imization=C2=A0to=C2=A0port=C2=A0applied" >=C2=A0 >=C2=A0-_WITH_LTO=3D= =C2=A0=C2=A0=C2=A0=C2=A0yes >=C2=A0 >=C2=A0-.undef=C2=A0_WITHOUT_LTO = >=C2=A0 >=C2=A0=C2=A0.=C2=A0=C2=A0endif=C2=A0 Hi, This changes = so LTO option is no longer applied to Rust (cargo) ports BY DEFAULT causi= ng a regresssion, please fix. Best regards, Daniel --_=_swift_1720843864_ee7b271ff312a5e000ad236f2a163824_=_ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
On 2024-04-12T09:54:47.000+02:00, Mathieu Arnold <mat@F= reeBSD.org> wrote:

The branch main has been updated by mat:


commit 06601897e5cd4afcc31f3b508b=
2cbb2bc7d4a677
Author:     Mathieu Arnold <mat@FreeBSD.org>
AuthorDate: 2024-04-12 07:49:01 +0000
Commit:     Ma=
thieu Arnold <mat@FreeBSD.org>
CommitDate: 2024-04-12 07:53:27 +0=
000

    framework: reintroduce the feature ena=
bling code
    
    For each feature (see in Mk=
/Features) users can now set these variables
    in their mak=
e.conf. Using LTO as an example.
    
    To en=
able globally:
    
      WITH_LTO=3D yes
    
    To disable globally (for example ssp is ena=
bled by default):
    
      WITHOUT_LTO=3D  ye=
s
    
    To enable for a specific list of por=
ts:
    
      WITH_LTO_PORTS=3D lang/perl5.36<=
br>
    
    To disable for a specific list of port=
s:
    
      WITHOUT_LTO_PORTS=3D lang/perl5.3=
6
    
    Differential Revision:  https://reviews.f=
reebsd.org/D44750
---
 Mk/Uses/cargo.mk           |  4 +---
=

 Mk/bsd.port=
.mk             | 42 ++++++++++++++++++++++++++++++++++--------
 net-mgmt/net-snmp/Makefile |  2 +-
 3 files changed, =
36 insertions(+), 12 deletions(-)

diff --git a=
/Mk/Uses/cargo.mk b/Mk/U=
ses/cargo.mk
index e3b733d35821..8710374e3584 100644
--- a/Mk/Uses/cargo.mk
+++ b=
/Mk/Uses/cargo.mk
@@ -139,10 +139,8 @@ CARGO_ENV+=3D \
 CARGO_ENV+=3D=
=09RUST_BACKTRACE=3D1
 .  endif
 
-.  if !defined(_WITHOUT_LTO) && (!defined(WITHOUT_LTO_PORTS) || $=
{WITHOUT_LTO_PORTS:N${PKGORIGIN}})
+.  if defined(WITH_LTO)
 _CARGO_MSG=3D=09"=3D=3D=3D>   Additional optimization to p=
ort applied"
-_WITH_LTO=3D=09yes
-.undef _WITHO=
UT_LTO
 .  endif
Hi,<= br>

This changes so LTO option is no longer applie= d to Rust (cargo) ports BY DEFAULT causing a regresssion, please fix.

Best regards,
Daniel
= --_=_swift_1720843864_ee7b271ff312a5e000ad236f2a163824_=_--