From nobody Mon Jan 22 10:46:21 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TJRjj58hyz57drw; Mon, 22 Jan 2024 10:46:49 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: from mail-ua1-f47.google.com (mail-ua1-f47.google.com [209.85.222.47]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TJRjj32xwz4bBs; Mon, 22 Jan 2024 10:46:49 +0000 (UTC) (envelope-from 6yearold@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ua1-f47.google.com with SMTP id a1e0cc1a2514c-7d2dfe83fbcso693733241.0; Mon, 22 Jan 2024 02:46:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705920408; x=1706525208; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y4dyPavw2D6kMo+HsAYI6aGpQ9HW3F+SISDiGJCMiZ0=; b=QxSXSSCvBNS6fWl9/NFAchSHwEFtMBwCW1C/aFOek3Drlzs8k5qxx/CGt22CfPVhBr CHMm5ZzY07kdQjj8fkyIYKy4cd8eaVVsbxoIz544q/Dzl/yIM5yv+ds9qxxiNN/BvsbF /AJ2CfoiS1ebBjULbI/za41+baC/Iq/9J7nwMLohc8AC7vFTmz9LAMBRUpLQYMOz9L8C 8wHVtzqWFhnFaVk+/2uD9RXpxcwtf83gE8PXpanT0QTjTmmg3tOtBHpkGeFNKOIY8ULx FSq0OflRFXwZGxC+BYOMhYA7Kj9SU3Pe2qdzG73vdk1BxlbOeCERfQaWPNHduEb8U30c 6DIw== X-Gm-Message-State: AOJu0YzG31/TPgZ4Azcb0RLD2fzcYJ7ge9iKhMCpy2gUR+RkBnjAJPq7 9SYgJW42A+YlosuQBKsD5YZjI7oKDsp4kxF2bUNVG0bmHTPhKGT7CCsxZRdSCLJUgw== X-Google-Smtp-Source: AGHT+IE0oZRuRd7tjGqKGoN9ort9iZ0DwgSPUQYUW4FR3fWgmgI7a9TAQHW7O9+ljGwmlIYDC4sj/w== X-Received: by 2002:a67:b448:0:b0:469:a69e:1f12 with SMTP id c8-20020a67b448000000b00469a69e1f12mr1189575vsm.1.1705920407895; Mon, 22 Jan 2024 02:46:47 -0800 (PST) Received: from mail-ua1-f54.google.com (mail-ua1-f54.google.com. [209.85.222.54]) by smtp.gmail.com with ESMTPSA id ca15-20020a0561300b0f00b007d2eba3ad17sm559751uab.24.2024.01.22.02.46.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jan 2024 02:46:47 -0800 (PST) Received: by mail-ua1-f54.google.com with SMTP id a1e0cc1a2514c-7d130979108so781994241.1; Mon, 22 Jan 2024 02:46:47 -0800 (PST) X-Received: by 2002:a05:6122:995:b0:4b7:b414:f268 with SMTP id g21-20020a056122099500b004b7b414f268mr1212847vkd.13.1705920407556; Mon, 22 Jan 2024 02:46:47 -0800 (PST) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202401220839.40M8dXYO009970@gitrepo.freebsd.org> In-Reply-To: From: Gleb Popov Date: Mon, 22 Jan 2024 13:46:21 +0300 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: d2e99e0393d6 - main - games/yadex: install the manpage under $PREFIX/share/man. To: Alexey Dokuchaev Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4TJRjj32xwz4bBs X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] On Mon, Jan 22, 2024 at 1:30=E2=80=AFPM Alexey Dokuchaev wrote: > > Not sure I understand: to change default GNU_CONFIGURE_MANPREFIX you'd > either have to fix all ports first (one by one, or better in small > groups, e.g. per-category or per-maintainer), then flip the switch and > drop custom GNU_CONFIGURE_MANPREFIX in indivitual ports (or skip/delay > the drop because they would be redundant, but harmless), no? You want > to change everything in one big commit? While I love to group commits, > that would be a little *too* big, I reckon. > > ./danfe It is not about commit squashing. The problem can be solved incrementally but it introduces more churn in the repository: 1. We go over all affected ports plugging GNU_CONFIGURE_MANPREFIX knobs into them. 2. Flip the switch in bsd.port.mk 3. Remove now useless GNU_CONFIGURE_MANPREFIX knobs from all the ports agai= n. As Mat said, it is easy to do 3 with a proper sed incantation, but I wanted to avoid unnecessary changes in commits. Those can be avoided if the work is being done in another branch, that'd get eventually merged in and keep all the history lean.