From nobody Sun Jan 21 23:53:59 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TJ9DV2tznz581Tf for ; Sun, 21 Jan 2024 23:54:02 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Received: from smtp-42aa.mail.infomaniak.ch (smtp-42aa.mail.infomaniak.ch [84.16.66.170]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "relay.mail.infomaniak.ch", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TJ9DT2lTxz4YTb for ; Sun, 21 Jan 2024 23:54:01 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=pyret.net header.s=20231006 header.b=jCwp9y8o; dmarc=pass (policy=reject) header.from=pyret.net; spf=pass (mx1.freebsd.org: domain of daniel.engberg.lists@pyret.net designates 84.16.66.170 as permitted sender) smtp.mailfrom=daniel.engberg.lists@pyret.net Received: from smtp-3-0000.mail.infomaniak.ch (unknown [10.4.36.107]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4TJ9DR4QltzMqgG6; Mon, 22 Jan 2024 00:53:59 +0100 (CET) Received: from unknown by smtp-3-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4TJ9DR1ZQPz3b; Mon, 22 Jan 2024 00:53:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=pyret.net; s=20231006; t=1705881239; bh=3vu5wuQ3GzJx8QBBC0QmMiqU84XqvwS175ypUhZfSrg=; h=Date:Subject:From:Reply-To:To:Cc:References:In-Reply-To:From; b=jCwp9y8owFp+5EkBd2rG1Zov64CA//tgzXAzVQnYf7Hd+qTOBmSj/d6liskozMGiG zLU5F1Gq/cSfGkEha2Rs/+RdHe/hdxKhL0XOJc/RdnEEvuEcbrB886saBjNlSAJedv +d+BN8OVinpdaLzdxVgAYfWEWRXYr9Mnx4d3Wn5G5saEJqzW6zNRb1T0MJPI9ZKrgd mDBxMIyuPHgSCLVmS3UtH0K2oTzFJmm5w93BcElm5RhZGbSKdUK/uthPonqI76nOPq WbnhbEwJUU+JS/ibL8KxPPlckKG4oUrAFk5Cw6xG9fnPuKkczyzW6gfpkE7TZEj5vG 1QORqtskxbMGw== Message-ID: Date: Mon, 22 Jan 2024 00:53:59 +0100 Subject: Re: git: b430a140c818 - main - net-im/purple-gowhatsapp: add WhatsApp plugin for libpurple From: Daniel Engberg Reply-To: Daniel Engberg To: "Mikhail T." Cc: Kurt Jaeger , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="_=_swift_1705881239_962c28a3d481e905c4ec2202256d46bc_=_" X-WS-User-Origin: eyJpdiI6IjV0aElJczlCVnVaRzZVcVVxU0xlOVE9PSIsInZhbHVlIjoiQ0RIa29LQWt1VXRiZC9OQnRIN0FYQT09IiwibWFjIjoiMjIwYzdmNjBkZTBiZDI2YzQ4MDNlZGJkNTk5OWMxMWY5ZGIzNTdhMmU3ZjIwZGNmNmE1MTdmZGE3ZDJlMTI2MSIsInRhZyI6IiJ9 X-WS-User-Mbox: eyJpdiI6IjN5cnV6bndQdVpQWUlxV1ZvSjNtOFE9PSIsInZhbHVlIjoiL2V3N2RJY1FEbkpVS1lRYTYxZGFFdz09IiwibWFjIjoiMjhmY2I2NjZjNGIyMDhhOGYxOTlmZmUxNjg0MDJlMGZhYzZkNGFmOTdkYTE3MzM4NGNjOTQ4OTEwNTVhMDdjYSIsInRhZyI6IiJ9 X-WS-Location: eJxzKUpMKykGAAfpAmU- X-Mailer: Infomaniak Workspace (1.3.624) References: <202401202030.40KKUApC045320@gitrepo.freebsd.org> <7e07375b-32bc-4778-8977-d87d6e135679@virtual-estates.net> <8ab62f5f-bb62-4633-9d1c-d7a8a8e1fc8a@virtual-estates.net> <13433172-a8cb-494c-a435-fd4d8418a2e6@virtual-estates.net> <21dcca053d36f9bec4005ffb18897f51@mail.infomaniak.com> <7ae9295a-0b05-4589-85d9-440ba373707f@virtual-estates.net> In-Reply-To: <7ae9295a-0b05-4589-85d9-440ba373707f@virtual-estates.net> X-Infomaniak-Routing: alpha X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.30 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; DMARC_POLICY_ALLOW(-0.50)[pyret.net,reject]; RWL_MAILSPIKE_VERYGOOD(-0.20)[84.16.66.170:from]; R_DKIM_ALLOW(-0.20)[pyret.net:s=20231006]; R_SPF_ALLOW(-0.20)[+ip4:84.16.66.168/29]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; RCVD_IN_DNSWL_LOW(-0.10)[84.16.66.170:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; ASN(0.00)[asn:29222, ipnet:84.16.64.0/19, country:CH]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; TAGGED_RCPT(0.00)[t]; DKIM_TRACE(0.00)[pyret.net:+]; MLMMJ_DEST(0.00)[dev-commits-ports-main@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; HAS_REPLYTO(0.00)[daniel.engberg.lists@pyret.net]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_LAST(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; REPLYTO_EQ_FROM(0.00)[] X-Rspamd-Queue-Id: 4TJ9DT2lTxz4YTb --_=_swift_1705881239_962c28a3d481e905c4ec2202256d46bc_=_ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2024-01-21T20:16:19.000+01:00, Mikhail T. w= rote: >=C2=A021.01.24=C2=A013:47,=C2=A0Daniel=C2=A0Engberg: >=C2= =A0 >>=C2=A0=C2=A0While=C2=A0we=C2=A0all=C2=A0do=C2=A0mistakes=C2=A0I'm= =C2=A0asking=C2=A0because=C2=A0it's=C2=A0broken=C2=A0and=C2=A0it's >>= =C2=A0=C2=A0likely=C2=A0not=C2=A0going=C2=A0to=C2=A0be=C2=A0fixed=C2=A0any= =C2=A0time=C2=A0soon. >=C2=A0 >=C2=A0I=C2=A0wonder,=C2=A0how=C2=A0you= =C2=A0estimate=C2=A0this=C2=A0likelihood... >=C2=A0 >>=C2=A0=C2=A0In= =C2=A0reality=C2=A0it=C2=A0adds=C2=A0noise=C2=A0(which=C2=A0we=C2=A0already= =C2=A0have=C2=A0enough=C2=A0of)=C2=A0on >>=C2=A0=C2=A0lists,=C2=A0Poudrie= re=C2=A0builds=C2=A0(because=C2=A0by=C2=A0default=C2=A0we=C2=A0build=C2= =A0all=C2=A0ports) >>=C2=A0=C2=A0takes=C2=A0more=C2=A0time=C2=A0producing= =C2=A0nothing,=C2=A0more=C2=A0time=C2=A0for=C2=A0people=C2=A0to=C2=A0review= >>=C2=A0=C2=A0error=C2=A0logs=C2=A0and=C2=A0so=C2=A0on. >=C2=A0 >= =C2=A0All=C2=A0of=C2=A0this=C2=A0could=C2=A0be=C2=A0silenced=C2=A0with= =C2=A0BROKEN,=C2=A0no? >=C2=A0 >>=C2=A0=C2=A0It=C2=A0boils=C2=A0down= =C2=A0to=C2=A0my=C2=A0time=C2=A0>=C2=A0your=C2=A0time=C2=A0which=C2=A0usual= ly=C2=A0don't=C2=A0translate >>=C2=A0=C2=A0well=C2=A0in=C2=A0team=C2= =A0efforts. >=C2=A0 >=C2=A0No,=C2=A0I=C2=A0don't=C2=A0see=C2=A0it=C2= =A0boiling=C2=A0down=C2=A0to=C2=A0that.=C2=A0To=C2=A0me=C2=A0it=C2=A0seems= =C2=A0like=C2=A0a >=C2=A0simple=C2=A0overreaction.=C2=A0So,=C2=A0a=C2= =A0newly-added=C2=A0port=C2=A0is=C2=A0broken=C2=A0--=C2=A0what's=C2=A0the= >=C2=A0big=C2=A0deal?=C2=A0You'd=C2=A0be=C2=A0right=C2=A0expecting=C2= =A0the=C2=A0committer=C2=A0to=C2=A0=C2=A0examine=C2=A0the >=C2=A0error-lo= g=C2=A0himself...=C2=A0It=C2=A0is=C2=A0just=C2=A0computers=C2=A0working= =C2=A0--=C2=A0so=C2=A0the=C2=A0humans, >=C2=A0present=C2=A0company=C2= =A0included,=C2=A0can=C2=A0do=C2=A0fun=C2=A0things. >=C2=A0 >>=C2=A0= =C2=A0Instead=C2=A0of=C2=A0doing=C2=A0the=C2=A0same=C2=A0thing=C2=A0again= =C2=A0use=C2=A0Poudriere=C2=A0as=C2=A0you're=C2=A0by >>=C2=A0=C2=A0know= =C2=A0well=C2=A0aware=C2=A0that=C2=A0it=C2=A0"should"=C2=A0be=C2=A0used= =C2=A0and=C2=A0you=C2=A0have=C2=A0been >>=C2=A0=C2=A0"warned". >=C2= =A0 >=C2=A0On=C2=A0the=C2=A0contrary=C2=A0--=C2=A0as=C2=A0long=C2=A0as= =C2=A0the=C2=A0"should"=C2=A0remains=C2=A0quoted,=C2=A0I=C2=A0intend >= =C2=A0to=C2=A0do=C2=A0the=C2=A0same=C2=A0thing:_commit,=C2=A0what=C2=A0I= =C2=A0sincerely=C2=A0believe=C2=A0is=C2=A0working >=C2=A0code_.=C2=A0Mat= =C2=A0is=C2=A0already=C2=A0convinced,=C2=A0I=C2=A0MUST=C2=A0follow,=C2= =A0what=C2=A0you=C2=A0acknowledge >=C2=A0is=C2=A0just=C2=A0a=C2=A0recomme= ndation=C2=A0--=C2=A0on=C2=A0the=C2=A0strength=C2=A0of=C2=A0his=C2=A0creati= ng=C2=A0a=C2=A0rule >=C2=A0out=C2=A0of=C2=A0void.=C2=A0Rights=C2=A0not= =C2=A0exercised=C2=A0are=C2=A0rights=C2=A0lost,=C2=A0and=C2=A0all=C2=A0that= =C2=A0:-) >=C2=A0 >>=C2=A0=C2=A0I=C2=A0would=C2=A0also=C2=A0say=C2= =A0that=C2=A0you'd=C2=A0be=C2=A0better=C2=A0off=C2=A0in=C2=A0general=C2= =A0asking=C2=A0for >>=C2=A0=C2=A0suggestions=C2=A0by=C2=A0creating=C2= =A0a=C2=A0PR=C2=A0and=C2=A0or=C2=A0use=C2=A0Phab(ricator)=C2=A0due=C2=A0to= >>=C2=A0=C2=A0quality=C2=A0reasons=C2=A0(to=C2=A0mention=C2=A0it=C2= =A0again,=C2=A0team=C2=A0effort). >=C2=A0 >=C2=A0Believe=C2=A0it=C2= =A0or=C2=A0not,=C2=A0I=C2=A0did=C2=A0ask=C2=A0for=C2=A0suggestions=C2=A0bef= ore=C2=A0committing=C2=A0-- >=C2=A0sending=C2=A0the=C2=A0shar=C2=A0of= =C2=A0the=C2=A0would=C2=A0be=C2=A0port=C2=A0to=C2=A0the=C2=A0committers= =C2=A0of=C2=A0 >=C2=A0[http://go.mk>];=C2=A0(because=C2=A0go@FreeB= SD.mk=C2=A0is=C2=A0blocked=C2=A0to >=C2=A0non-subscribers).=C2=A0Having= =C2=A0received=C2=A0no=C2=A0immediate=C2=A0replies,=C2=A0I=C2=A0figured, = >=C2=A0I'll=C2=A0see,=C2=A0what=C2=A0Poudriere=C2=A0would=C2=A0say=C2=A0--= =C2=A0still=C2=A0don't=C2=A0understand=C2=A0the >=C2=A0scale=C2=A0of= =C2=A0the=C2=A0blowback... >=C2=A0 >>=C2=A0=C2=A0-mi Hi, Seem= s like you didn't test 26fa495285d9d7bcd85794665c45d31e1ed1ccb2 ? http= s://pdr2.bofh.network/data/140-diizzy/2024-01-21_17h43m38s/logs/errors/purp= le-gowhatsapp-1.13.0.log Best regards, Daniel --_=_swift_1705881239_962c28a3d481e905c4ec2202256d46bc_=_ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
On 2024-01-21T20:16:19.000+01:00, Mikhail T. <mi+t@virtual-estates.= net> wrote:
<= blockquote class=3D"ws-ng-quote">
21.01.24 13:47, = Daniel Engberg:
While we all do mis= takes I'm asking because it's broken and it's likely not going to be fixed any time soon.
I wonder, how you estimate this likelihood...

<= /div>
In reality it adds noise (which we alre= ady have enough of) on lists, Poudriere builds (because by default we build all ports) takes more time producing nothing, more time for people to review error logs and so on.
All of this= could be silenced with BROKEN, no?
It boils down to my time > your time which usually don't translate well in team efforts.

No, I don'= t see it boiling down to that. To me it seems like a simple overreaction. So, a newly-added port is broken -- what's the big deal? You'd be right expecting the committer to  examine the error-log himself... It is just computers working -- so the humans, present company included, can do fun things.

Instead of doing the same thing again use Poudriere a= s you're by know well aware that it "should" be used and you have been "warned".
On the contrary -- as long as = the "should" remains quoted, I intend to do the same thing:commit, what I sincerely believe is working code. Mat is already convinced, I must follow, what you acknowledge is just a recommendation -- on the strength of his creating a rule out of void. Rights not exercised are rights lost, and all that :-)

I would also say that you'd be better off in general asking for suggestions by creating a PR and or use Phab(ricator) due to quality reasons (to mention it again, team effort).

Believe it or not, I did ask for suggestions before committing -- sending the shar of the would be port to the committers of <" class=3D"defaultMailLink defaultMailLink" target=3D"_blank">go.m= k>; (because go@FreeBSD.mk is blocked to non-subscribers). Having received no immediate replies, I figured, I'll see, what Poudriere would say -- still don't understand the scale of the blowback...


-mi

=
Hi,

Seems like you didn't test 26fa495285= d9d7bcd85794665c45d31e1ed1ccb2 ?

=
Best regards,
Daniel

--_=_swift_1705881239_962c28a3d481e905c4ec2202256d46bc_=_--