Re: git: ffd93c4ef3fb - main - multimedia/streamlink: update to 6.5.1
- In reply to: Gleb Popov : "Re: git: ffd93c4ef3fb - main - multimedia/streamlink: update to 6.5.1"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Wed, 17 Jan 2024 18:39:42 UTC
17.01.2024 21:13, Gleb Popov пишет: > On Wed, Jan 17, 2024 at 8:31 PM Daniel Engberg > <daniel.engberg.lists@pyret.net> wrote: >> Hi, >> >> I've noticed this a few times regarding your commits, please start using the "--author" when committing patches. >> >> See "Example 4. Commit Log for a Commit Based on a PR" in Committers Guide for more information. >> >> Best regards, >> Daniel >> > Thanks for noticing this, Daniel, this is an oversight on my part. > > Vladimir, make sure you put proper attribution for the commits you're > pushing. Otherwise it looks as if you did the job of updating the port > (I actually also thought that!). For some reason, I thought that it was enough to indicate the PR, which indicated the author of the patch. And that using "--author" is necessary only if there is no link to the PR or the author of the PR is someone else. I will know that in this case it is also necessary to use "--author". Also I missed maintainer from "Approved by:"… -- Best regards, Vladimir Druzenko