From nobody Wed Feb 28 08:47:37 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Tl7KY0hQWz5Cwvd; Wed, 28 Feb 2024 08:48:01 +0000 (UTC) (envelope-from i.h8.git@BSDforge.com) Received: from udns.ultimatedns.net (udns.ultimatedns.net [24.113.41.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "ultimatedns.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Tl7KW5jttz4FQK; Wed, 28 Feb 2024 08:47:59 +0000 (UTC) (envelope-from i.h8.git@BSDforge.com) Authentication-Results: mx1.freebsd.org; none Received: from ultimatedns.net (localhost [127.0.0.1]) by udns.ultimatedns.net (8.16.1/8.16.1) with ESMTP id 41S8lbs7048372; Wed, 28 Feb 2024 00:47:43 -0800 (PST) (envelope-from i.h8.git@BSDforge.com) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Date: Wed, 28 Feb 2024 00:47:37 -0800 From: Chris To: Mathieu Arnold Cc: "Jason E. Hale" , Gleb Popov , Daniel Engberg , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 36c21f98ff44 - main - benchmarks/ttcp: Update to 1.13 In-Reply-To: <7wtjaex6ht2sqsm26atlimduwcydcfs57hihspupjknfjz2ljs@w4fiirdt2djw> References: <030d157421488bff9ba33907668ba385@BSDforge.com> <7wtjaex6ht2sqsm26atlimduwcydcfs57hihspupjknfjz2ljs@w4fiirdt2djw> User-Agent: UDNSMS/17.0 Message-ID: <9bec2572dac3452df066367cd1ac47d7@BSDforge.com> X-Sender: i.h8.git@BSDforge.com Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:11404, ipnet:24.113.0.0/16, country:US] X-Rspamd-Queue-Id: 4Tl7KW5jttz4FQK On 2024-02-27 21:25, Mathieu Arnold wrote: > On Tue, Feb 27, 2024 at 10:57:36PM -0500, Jason E. Hale wrote: >> On Tue, Feb 27, 2024 at 5:14 PM Chris wrote: >> > >> > On 2024-02-27 00:44, Mathieu Arnold wrote: >> > > On Tue, Feb 27, 2024 at 12:25:35AM -0800, Chris wrote: >> > >> On 2024-02-26 22:28, Mathieu Arnold wrote: >> > >> > On Mon, Feb 26, 2024 at 08:48:02AM -0800, Chris wrote: >> > >> > > On 2024-02-25 04:37, Gleb Popov wrote: >> > >> > > > On Sun, Feb 25, 2024 at 3:34 PM Daniel Engberg >> > >> > > > wrote: >> > >> > > > > Hi, >> > >> > > > > >> > >> > > > > URL(s) for how we fetch releases/archives from Codeberg >> > >> > > > >> > >> > > > Ah, sorry, I just wasn't aware we're standardizing on this. Out of >> > >> > > > curiosity, what's the rationale behind the >> > >> > > > "${ACCOUNTNAME}/${PROJECTNAME}/archive/${DISTVERSIONFULL}${EXTRACT_SUFX}?dummy=/" >> > >> > > As I indicated in the pr(1) (276759) when you brought this up. The above >> > >> > > does not work: >> > >> > > >> > >> > > # make -DBATCH fetch >> > >> > > => ttcp-1.13.tar.gz doesn't seem to exist in /usr/ports/distfiles/. >> > >> > > => Attempting to fetch >> > >> > > https://codeberg.org///archive/1.13.tar.gz?dummy=/ttcp-1.13.tar.gz >> > >> > > fetch: https://codeberg.org///archive/1.13.tar.gz?dummy=/ttcp-1.13.tar.gz: >> > >> > > Not Found >> > >> > > >> > >> > > Using *any* form of DIST(VERSION)PREFIX/SUFFIX/NAME is no closer to >> > >> > > returning anything >> > >> > >> > >> > Well, this is because the port is missing DISTVERSIONPREFIX=ttcp- as the >> > >> > tag is ttcp-1.13, and not 1.13. >> > >> Thanks for the reply, Mathieu. >> > >> That causes it to attempt to fetch ttcp-ttcp-1.13.tar.gz >> > >> >> > >> PORTNAME= ttcp >> > >> PORTVERSION= 1.13 >> > >> DISTVERSIONPREFIX=ttcp- >> > >> CATEGORIES= benchmarks net >> > >> MASTER_SITES= https://codeberg.org/BSDforge/archive/${DISTVERSIONFULL}${EXTRACT_SUFX}?dummy=/ >> > > >> > > MASTER_SITES= https://codeberg.org/BSDforge/ttcp/archive/${DISTVERSIONFULL}${EXTRACT_SUFX}?dummy=/ >> > ... >> > => ttcp-ttcp-1.13.tar.gz is spelled incorrectly. >> > thanks for trying. :) >> >> Please disregard my previous message. >> >> Simply setting: >> >> MASTER_SITES= >> https://codeberg.org/BSDforge/ttcp/archive/${PORTNAME}-${DISTVERSIONFULL}${EXTRACT_SUFX}?dummy=/ >> >> fixes the issue for me. I was taken a bit off-guard with ${PORTNAME} >> being a part of the tagname, which is rather unusual, but it fetches >> nicely from codeberg with this string. > > Please, no, set DISTVERSIONPREFIX=${PORTNAME}-, don't change the url > template. I can wrap my head around that. Thanks. I'll use that in all my Codeberg hosted ports going forward. Thanks, Mathieu! :) Now. If we could only add Codeberg to bsd.sites.mk. We could even add expansions like CB_ACCOUNT, CB_PROJECT, MASTERSITES= CB... :) --Chris