Re: git: 48437516330b - main - www/nghttp2: Remove unnecessary substitution

On Thu, 22 Feb 2024 at 11:01, Nuno Teixeira <eduardo@freebsd.org> wrote:
>
> Hello,
>
> What's going on?
>
> -DISTVERSION=   1.59.0
> +PORTVERSION=   1.59.0
>
> Should Porter's Handbook be fixed?

Or veteran committers should update their knowledge :)

Less jokingly, the problem with DISTVERSION/PORTVERSION is that the
Porters's Handbook and ports framework are out of sync. Somebody has
decided that DISTVERSION is higher than PORTVERION (makes sense for
me, if you want my opinion) and has commited update to the handbook.
However, the framework has not been changed, it checks for PORTVERION
first, while DISTVERSION is derived from PORTVERION.

If we want to switch to DISTVERSION and deprecate PORTVERSION, we
should update the framework and docs and CHANGES and notify people
before upcoming change and after. This applies to other changes in the
ports framework.

Cheers,
Max