Re: git: e2b4eb57621f - main - graphics/pngcrush: Mark BROKEN and set expiration date to 2024-02-29

On 2024-02-08 17:47, Daniel Engberg wrote:
> On 2024-02-09T02:31:19.000+01:00, Moin Rahman <bofh@freebsd.org>
> wrote:
> 
>>>   On Feb 9, 2024, at 2:25 AM, Chris <i.h8.git@BSDforge.com> wrote:
>>>   
>>>    On 2024-02-08 14:11, Daniel Engberg wrote:
>>>   
>>>>    The branch main has been updated by diizzy:
>>>>    
>>>>     URL:
>>>>    https://cgit.FreeBSD.org/ports/commit/?id=e2b4eb57621f1c96f678c210fe7d2474c904e295
>>>>    
>>>>     commit e2b4eb57621f1c96f678c210fe7d2474c904e295
>>>>    
>>>>     Author: Daniel Engberg <diizzy@FreeBSD.org>
>>>>    
>>>>     AuthorDate: 2024-02-08 22:08:52 +0000
>>>>    
>>>>     Commit: Daniel Engberg <diizzy@FreeBSD.org>
>>>>    
>>>>     CommitDate: 2024-02-08 22:09:19 +0000
>>>>    
>>>>     graphics/pngcrush: Mark BROKEN and set expiration date to
>>>>    2024-02-29
>>>>    
>>>>     Fails to build with libpng 1.6.41 due to usage of undocumented
>>>>    feature to
>>>>    
>>>>     disable Adler32 checksums.
>>>>    
>>>>     Last release in 2017 and dead upstream, redirect users to
>>>>    graphics/oxipng
>>>>    
>>>>     or graphics/pngquant
>>>   
>>>    This port is not broken. Please reverse this.
>>>   
>>>    If you, or anyone has an issue with the port. Use the bug
>>>   reporting channel.
>>>   
>>>    That's what it is designed for.
>>>   
>>>>    Reference:
>>>>    
>>>>     https://github.com/pnggroup/libpng/commit/269b753496180cdb3082d87b0cd907905593dee5
>>>>    
>>>>     PR: 276649
>>>>    
>>>>     Reviewed by: Anton Saietskii <vsasjason@gmail.com> (maintainer)
>>>>    
>>>>     ---
>>>>    
>>>>     graphics/pngcrush/Makefile | 3 +++
>>>>    
>>>>     1 file changed, 3 insertions(+)
>>>>    
>>>>     diff --git a/graphics/pngcrush/Makefile
>>>>    b/graphics/pngcrush/Makefile
>>>>    
>>>>     index 63e8ab2869d4..b38e9e664acc 100644
>>>>    
>>>>     --- a/graphics/pngcrush/Makefile
>>>>    
>>>>     +++ b/graphics/pngcrush/Makefile
>>>>    
>>>>     @@ -14,6 +14,9 @@ LICENSE_NAME= Pngcrush License
>>>>    
>>>>     LICENSE_FILE= ${WRKSRC}/LICENSE
>>>>    
>>>>     LICENSE_PERMS= dist-mirror pkg-mirror auto-accept
>>>>    
>>>>     +BROKEN= Depends on undocumented feature to disable Adler32
>>>>    checksums, consider
>>>>    
>>>>     graphics/oxipng or graphics/pngquant
>>>>    
>>>>     +EXPIRATION_DATE=2024-02-29
>>>>    
>>>>     +
>>>>    
>>>>     LIB_DEPENDS= libpng.so:graphics/png
>>>>    [http://libpng.so:graphics/png]
>>>>    
>>>>     USES= cpe localbase:ldflags tar:xz
>>  
>>  Do you have a log that it builds with the newest libpng?
> 
> https://pdr2.bofh.network/data/132-diizzy/2024-02-08_19h28m49s/logs/errors/pngcrush-1.8.13.log
> 
> That's a fresh build
> 
> Best regards,
> 
> Daniel
Lastly, the commit log lists:
Anton Saietskii <vsasjason@gmail.com> (maintainer)
Which is incorrect. I am the maintainer.