From nobody Fri Feb 09 03:05:49 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TWJdq34kMz58kFd; Fri, 9 Feb 2024 03:06:07 +0000 (UTC) (envelope-from i.h8.git@BSDforge.com) Received: from udns.ultimatedns.net (udns.ultimatedns.net [24.113.41.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "ultimatedns.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TWJdq0CvFz4GKl; Fri, 9 Feb 2024 03:06:06 +0000 (UTC) (envelope-from i.h8.git@BSDforge.com) Authentication-Results: mx1.freebsd.org; none Received: from ultimatedns.net (localhost [127.0.0.1]) by udns.ultimatedns.net (8.16.1/8.16.1) with ESMTP id 41935oWS084216; Thu, 8 Feb 2024 19:06:05 -0800 (PST) (envelope-from i.h8.git@BSDforge.com) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Date: Thu, 08 Feb 2024 19:05:49 -0800 From: Chris To: Daniel Engberg Cc: Moin Rahman , Daniel Engberg , ports-committers , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: e2b4eb57621f - main - graphics/pngcrush: Mark BROKEN and set expiration date to 2024-02-29 In-Reply-To: References: <202402082211.418MBK2t091444@gitrepo.freebsd.org> <9b6a0d96cb2fe54d6702727c9b1d882e@BSDforge.com> User-Agent: UDNSMS/17.0 Message-ID: X-Sender: i.h8.git@BSDforge.com Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4TWJdq0CvFz4GKl X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:11404, ipnet:24.113.0.0/16, country:US] On 2024-02-08 17:47, Daniel Engberg wrote: > On 2024-02-09T02:31:19.000+01:00, Moin Rahman > wrote: > >>>   On Feb 9, 2024, at 2:25 AM, Chris  wrote: >>>    >>>    On 2024-02-08 14:11, Daniel Engberg wrote: >>>    >>>>    The branch main has been updated by diizzy: >>>>     >>>>     URL: >>>>    https://cgit.FreeBSD.org/ports/commit/?id=e2b4eb57621f1c96f678c210fe7d2474c904e295 >>>>     >>>>     commit e2b4eb57621f1c96f678c210fe7d2474c904e295 >>>>     >>>>     Author: Daniel Engberg  >>>>     >>>>     AuthorDate: 2024-02-08 22:08:52 +0000 >>>>     >>>>     Commit: Daniel Engberg  >>>>     >>>>     CommitDate: 2024-02-08 22:09:19 +0000 >>>>     >>>>     graphics/pngcrush: Mark BROKEN and set expiration date to >>>>    2024-02-29 >>>>     >>>>     Fails to build with libpng 1.6.41 due to usage of undocumented >>>>    feature to >>>>     >>>>     disable Adler32 checksums. >>>>     >>>>     Last release in 2017 and dead upstream, redirect users to >>>>    graphics/oxipng >>>>     >>>>     or graphics/pngquant >>>    >>>    This port is not broken. Please reverse this. >>>    >>>    If you, or anyone has an issue with the port. Use the bug >>>   reporting channel. >>>    >>>    That's what it is designed for. >>>    >>>>    Reference: >>>>     >>>>     https://github.com/pnggroup/libpng/commit/269b753496180cdb3082d87b0cd907905593dee5 >>>>     >>>>     PR: 276649 >>>>     >>>>     Reviewed by: Anton Saietskii  (maintainer) >>>>     >>>>     --- >>>>     >>>>     graphics/pngcrush/Makefile | 3 +++ >>>>     >>>>     1 file changed, 3 insertions(+) >>>>     >>>>     diff --git a/graphics/pngcrush/Makefile >>>>    b/graphics/pngcrush/Makefile >>>>     >>>>     index 63e8ab2869d4..b38e9e664acc 100644 >>>>     >>>>     --- a/graphics/pngcrush/Makefile >>>>     >>>>     +++ b/graphics/pngcrush/Makefile >>>>     >>>>     @@ -14,6 +14,9 @@ LICENSE_NAME= Pngcrush License >>>>     >>>>     LICENSE_FILE= ${WRKSRC}/LICENSE >>>>     >>>>     LICENSE_PERMS= dist-mirror pkg-mirror auto-accept >>>>     >>>>     +BROKEN= Depends on undocumented feature to disable Adler32 >>>>    checksums, consider >>>>     >>>>     graphics/oxipng or graphics/pngquant >>>>     >>>>     +EXPIRATION_DATE=2024-02-29 >>>>     >>>>     + >>>>     >>>>     LIB_DEPENDS= libpng.so:graphics/png >>>>    [http://libpng.so:graphics/png] >>>>     >>>>     USES= cpe localbase:ldflags tar:xz >>   >>  Do you have a log that it builds with the newest libpng? > > https://pdr2.bofh.network/data/132-diizzy/2024-02-08_19h28m49s/logs/errors/pngcrush-1.8.13.log The problem indicated in your log is addressable and belonged in a pr(1). Not a commit log. Where I would have created a patch to fix it. One I could also upstreamed to the project. Please reverse this commit and create a pr(1) for this. So we can properly address it. > > That's a fresh build > > Best regards, > > Daniel