Re: git: 06dbf1df62a4 - main - audio/alsa-plugins: convert options to subpackages

I would stop adding more subpackages, until we have fixed those small
annoying bugs.
Dogfooding has already surfaced a few issues, so it's time to fix those
issues before adding more stuff.

On Sat, Feb 3, 2024 at 11:52 AM Jan Beich <jbeich@freebsd.org> wrote:

> Max Brazhnikov <makc@freebsd.org> writes:
>
> > On Sat, 03 Feb 2024 07:06:28 +0100 Jan Beich wrote:
> >
> >> Charlie Li <vishwin@freebsd.org> writes:
> >>
> >> > Jan Beich wrote:
> >> >
> >> >> The branch main has been updated by jbeich:
> >> >> URL:
> >> >>
> https://cgit.FreeBSD.org/ports/commit/?id=06dbf1df62a4f54da4cadecbbc0be5f33902eb1c
> >> >> commit 06dbf1df62a4f54da4cadecbbc0be5f33902eb1c
> >> >> Author:     Jan Beich <jbeich@FreeBSD.org>
> >> >> AuthorDate: 2024-01-30 16:18:28 +0000
> >> >> Commit:     Jan Beich <jbeich@FreeBSD.org>
> >> >> CommitDate: 2024-02-02 13:44:56 +0000
> >> >>      audio/alsa-plugins: convert options to subpackages
> >> >>           Reduce heavy dependencies for consumers e.g.,
> >> >>      - chromium -> pipewire -> alsa-plugins -> pulseaudio
> >> >>      - wine -> alsa-plugins -> pulseaudio
> >> >>
> >> > At least my poudriere wants to delete and rebuild every run because it
> >> > thinks a new dependency is always missing.
> >>
> >> See https://github.com/freebsd/poudriere/issues/1113
> >
> > Can we please stop adding new subpackages until this issue is fixed?
>
> - this change has high ROI: disable PULSEAUDIO by default vs. "batteries
> included"
> - not much of an issue for the package cluster due to high churn on
> /latest set
> - shouldn't impact unsupervised or portmsater builds (options are still
> there)
> - SUBPACKAGES require dogfooding[1] to test tools and avoid regressions
>
> [1] https://reviews.freebsd.org/D43079 was far too simple
>     https://reviews.freebsd.org/D43445 was actually incorrect
>