From nobody Thu Dec 26 10:47:09 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YJlgf2WNJz5hgS6; Thu, 26 Dec 2024 10:47:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YJlgf07CHz46qy; Thu, 26 Dec 2024 10:47:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735210030; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eThAJpoLDwo98HvbJx2OTgt8ud2pKzG1zPGduA9DxxM=; b=J+LfKrYvoN541aTOpmYRYZvPREuDwEZNy3MYXNmu4g99moW/LTD9ggcZIAYDUyb0txHHHF 428G1XJM7SXFBaqC1c4zeBir5mCxy/ORL7xesi89hD3FBgBjro8LRAk7HY1laSm2m0dXuM kpGBCpluYUdr6ABOIS4YcNtgW3aVtV+0hIk/Q6CXHIx7VweA6tlgWlh9AX3ydREGR6ILLI shEUdAjYC8OhHQ53TFf43AHWimv+BrBjVfOJkwUdrjjEsiW/clAd7/GfThavSqlOIAFzJH SRpbBZSjcxkYPzstc5dHSL5iLfjR7N6DXEb8I6ozoXBWt83jqEKoJlThroX/DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735210030; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eThAJpoLDwo98HvbJx2OTgt8ud2pKzG1zPGduA9DxxM=; b=R7f0RzTePxj01oboMDZU9jSfIL+T9xKz52jf7R/j02HQnj/ScZsy3OIarKDXG0UbINH7i4 Tc9KrDpGqH0pqQxaQ+3c+XP/P/JQr73jFJejZDliHzgv0VFN5VzMjVsIfC7fRH4W5TywRl OxvuNEm/15JZEt1QeZqep/7kNTsfa45yarVbtkBANhpdStvnO2iFYBTOKVLfhVsHCA5Woy UTNNx2BOhlDvTY8/sebdCXXj3YDaQU5Fv2/E8RKUYOsqeSzUoZy1X9xrAVBPs8m8+l4Hkm XCEvEKcnF6xOo3qzz2AB1CXzv5XSoBw3g8Tweypad65kHqplIt4rXkKpCgSQGg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1735210030; a=rsa-sha256; cv=none; b=jiJR2hcos0tnhmaYQvktF+WHMkWl/8SKFMjEnUyxP3EPrsSapS4KaF3ia9GnntX+pG3GJU 2+1A+B6tMRh5Fk0+x64LJSxh0QYMJsGhrkjjbG3sLg+Fve7eSttZJYGnDiMa+Ty2TEh2B7 AIE4hHXjOJVqVan5d85CpYjEh+ENuQPF10QrSqK3RXPORaPEQ2KDb77kgYCsV1wt5zEURc pNlBGvD1eo5bTsTZEnD+BQeKHQp2dXwQstkN52WSFwnIyraisRLLmZ4afI9RQEIwvlMxcI XWYWMshTvr4qfSUYfljslpazlAbMst7sn87vIi65X4A/oxqDsVIQ+06F8dy+UQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YJlgd6m1SzrTL; Thu, 26 Dec 2024 10:47:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4BQAl94b039504; Thu, 26 Dec 2024 10:47:09 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4BQAl9v0039501; Thu, 26 Dec 2024 10:47:09 GMT (envelope-from git) Date: Thu, 26 Dec 2024 10:47:09 GMT Message-Id: <202412261047.4BQAl9v0039501@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org From: Robert Clausecker Subject: git: 147aeb1ee48f - main - lang/ratfor: fix build on platforms where char is unsigned List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: fuz X-Git-Repository: ports X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 147aeb1ee48f8aeb8e4892e3271a3231388a412c Auto-Submitted: auto-generated The branch main has been updated by fuz: URL: https://cgit.FreeBSD.org/ports/commit/?id=147aeb1ee48f8aeb8e4892e3271a3231388a412c commit 147aeb1ee48f8aeb8e4892e3271a3231388a412c Author: Robert Clausecker AuthorDate: 2024-12-25 00:07:07 +0000 Commit: Robert Clausecker CommitDate: 2024-12-26 10:46:28 +0000 lang/ratfor: fix build on platforms where char is unsigned Turns out the code anticipates this problem and has support for using "signed char" over "char" where "char" is unsigned by default. Use "signed char" unconditionally to fix the port on all platforms. While we are at it, pet portclippy. PR: 258628, 283509 Approved by: bofh MFH: 2024Q4 --- lang/ratfor/Makefile | 17 ++++++----------- lang/ratfor/files/patch-Makefile | 2 +- 2 files changed, 7 insertions(+), 12 deletions(-) diff --git a/lang/ratfor/Makefile b/lang/ratfor/Makefile index 3c13978b5f1f..0b4dee9b243f 100644 --- a/lang/ratfor/Makefile +++ b/lang/ratfor/Makefile @@ -1,6 +1,6 @@ PORTNAME= ratfor PORTVERSION= 1985.06 -PORTREVISION= 16 +PORTREVISION= 17 CATEGORIES= lang MASTER_SITES= LOCAL/obrien \ http://sepwww.stanford.edu/sep/prof/ @@ -12,20 +12,15 @@ COMMENT= Rational FORTRAN compiler LICENSE= PD LICENSE_FILE= ${WRKSRC}/README -BROKEN_aarch64= ./ratfor -o test.f test.r keeps creating huge output file -BROKEN_armv6= ./ratfor -o test.f test.r keeps creating huge output file -BROKEN_armv7= ./ratfor -o test.f test.r keeps creating huge output file -BROKEN_powerpc= ./ratfor -o test.f test.r keeps creating huge output file -BROKEN_powerpc64= ./ratfor -o test.f test.r keeps creating huge output file -BROKEN_powerpc64le= ./ratfor -o test.f test.r keeps creating huge output file -BROKEN_powerpcspe= ./ratfor -o test.f test.r keeps creating huge output file +USES= fortran + +ALL_TARGET= all tests -NO_WRKSUBDIR= yes EXTRACT_CMD= ${CAT} EXTRACT_BEFORE_ARGS= EXTRACT_AFTER_ARGS= | ${SH} -ALL_TARGET= all tests -USES= fortran + +NO_WRKSUBDIR= yes PLIST_FILES= bin/ratfor bin/ratfor77 share/man/man1/ratfor.1.gz diff --git a/lang/ratfor/files/patch-Makefile b/lang/ratfor/files/patch-Makefile index 4ce15b7de3a4..b686e9ab66b8 100644 --- a/lang/ratfor/files/patch-Makefile +++ b/lang/ratfor/files/patch-Makefile @@ -5,7 +5,7 @@ # -CFLAGS+= -DF77 -DS_CHAR="char" -+CFLAGS+= -DF77 -DS_CHAR="char" -Wno-error=return-type ++CFLAGS+= -DF77 -DS_CHAR="signed char" -Wno-error=return-type #CFLAGS+= -DS_CHAR="char" OBJS= rat4.o lookup.o getopt.o