From nobody Fri Aug 30 07:25:53 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ww8pR515Bz5TFyr; Fri, 30 Aug 2024 07:26:23 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: from mail-vk1-f174.google.com (mail-vk1-f174.google.com [209.85.221.174]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ww8pR3CjBz4LlH; Fri, 30 Aug 2024 07:26:23 +0000 (UTC) (envelope-from 6yearold@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-vk1-f174.google.com with SMTP id 71dfb90a1353d-4fce700765aso484263e0c.2; Fri, 30 Aug 2024 00:26:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725002782; x=1725607582; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j00uLpU0MCJGq3iDrECY8uxG8Dc4T3oswWW3Pzrme88=; b=Steg8l6JxpDVEaxWWilDfqz5rhSuhuKab1V2yRQntCDDtITXP5y63kjBVPOkVr23BD Arli7gxc+YNOy2Ru3xhJfjIMOmEpSLzzmo2akADBomP7hBhzgMpp4anEnBd2BKuDTkZN UGdkQ0BftjbAKXQdWfj4tVj9Cfcr0+jlwLB/8xmwzkIgSfRWJHrI1UarFiw5pGxF+3xj rP98Ma0CN5TnVoogoGy1aIaOBnBjnpK93C6/Tk1LGYsU+qzn+FyY8cTKpmfqb9Oh3R1S 6d6L29h23Ku4qrCGIwP1fMJM1BNxgx1cDBxciUbJ+81aclFd9q+0jZ/Zj1v7GnfIvYdF 9pwg== X-Forwarded-Encrypted: i=1; AJvYcCUNHjmNjEt7H4qU6X9qIoydXOaqwQUSqyExnkNmGCGpccfHbRWdMWp/T9vfKiC5dK/LFSMEbODrj3NOcOwRvALzb0ow1FtqAw==@freebsd.org, AJvYcCV0lrN11eQ5LkiJ9UXzxEp81ekuMF7DhZfnHwEtIntQadGmGifQ7dAjRHW1WRi1tN6881EbscUz8YT6jH6obKKH/OhFeiw=@freebsd.org X-Gm-Message-State: AOJu0YwDGbm331IqjnKBsyphxMHuS0kwOJsMXtRuaTvfVetYm50uPS6R PIX3pB7BCArgZraaltlUTwnSNCJxZNlmodOQ8BAhQI/GAwBxtlD7YjafB9ta X-Google-Smtp-Source: AGHT+IG6zYwX9bF6Oapr/dOO9lb3YdTQgPga3/b9ZLmrBwlDhEhhg0KTP7YknLsIf14LVeV4Dh9qKg== X-Received: by 2002:a05:6122:da8:b0:4f6:ad39:dab1 with SMTP id 71dfb90a1353d-4ffe4a7e888mr5942811e0c.5.1725002782006; Fri, 30 Aug 2024 00:26:22 -0700 (PDT) Received: from mail-vk1-f181.google.com (mail-vk1-f181.google.com. [209.85.221.181]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-500712a474esm389056e0c.29.2024.08.30.00.26.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Aug 2024 00:26:21 -0700 (PDT) Received: by mail-vk1-f181.google.com with SMTP id 71dfb90a1353d-4fee7fa19c8so451644e0c.0; Fri, 30 Aug 2024 00:26:21 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVkzPhR1a+oKGPbFF4NMOev28lgvlBKEOCrz8y1LW/GO2RvqtLI4y0/gLvUJ/y9fiF1A2mCIyoV7DOg7u+/0waGMSsWKc2KaQ==@freebsd.org, AJvYcCWcjCQJpb8HUaNt6QYd9as/RG+xXmXWbuV1OkTPMoPEVPwSKqOaTekNq8WQV7JYRsFle+6TlAH2QUx9CR8cA94QODUG1Ww=@freebsd.org X-Received: by 2002:a05:6122:3b0a:b0:4f6:a5ed:eb11 with SMTP id 71dfb90a1353d-4ffe4bbb00dmr5286428e0c.8.1725002781409; Fri, 30 Aug 2024 00:26:21 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 References: <202408292017.47TKHMcD004669@gitrepo.freebsd.org> In-Reply-To: <202408292017.47TKHMcD004669@gitrepo.freebsd.org> From: Gleb Popov Date: Fri, 30 Aug 2024 10:25:53 +0300 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 35db13a201c4 - main - audio/pulseaudio-module-sndio: Fix build with poudriere To: Nicola Vitale Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4Ww8pR3CjBz4LlH On Thu, Aug 29, 2024 at 11:17=E2=80=AFPM Nicola Vitale = wrote: > > The branch main has been updated by nivit: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3D35db13a201c4e9314accbf05= 1083265e45dee758 > > commit 35db13a201c4e9314accbf051083265e45dee758 > Author: Nicola Vitale > AuthorDate: 2024-08-29 20:07:37 +0000 > Commit: Nicola Vitale > CommitDate: 2024-08-29 20:07:37 +0000 > > audio/pulseaudio-module-sndio: Fix build with poudriere > > As pointed out by arrowd@, the previous patch doesn't work in poudrie= re > "because the pkg-config executable isn't there at the time the variab= le > value is evaluated". So put the variables in the standard position in > the Makefile and fix the regular expression of sed(1). It still doesn't work, unfortunately - the order in which variables are defined doesn't matter here. The root of the problem is that pkg-config is called during the fetch stage, but it gets checked for as a dependency and installed during the later build stage. It works if you already have pkg-config installed, but in the Poudriere case we always start from an empty system. I think this should be solved by extracting the variable containing the Pulseaudio version into a separate file Makefile.version, which is then included into both ports. I did a similar thing here: https://github.com/freebsd/freebsd-ports/commit/fc94b4e3dde63313c7f915630c4= 96fe3d50e19a0