From nobody Thu Aug 29 12:42:37 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wvgss379bz5Mtgr; Thu, 29 Aug 2024 12:42:41 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta002.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wvgss0Mybz4Z8x; Thu, 29 Aug 2024 12:42:40 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4003a.ext.cloudfilter.net ([10.228.9.183]) by cmsmtp with ESMTPS id jckYsWKLOMArNjeU4sttJC; Thu, 29 Aug 2024 12:42:40 +0000 Received: from spqr.komquats.com ([70.66.152.170]) by cmsmtp with ESMTPSA id jeU2sO1G8E0IVjeU3scEI2; Thu, 29 Aug 2024 12:42:39 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=cI9DsUeN c=1 sm=1 tr=0 ts=66d06cbf a=y8EK/9tc/U6QY+pUhnbtgQ==:117 a=y8EK/9tc/U6QY+pUhnbtgQ==:17 a=kj9zAlcOel0A:10 a=yoJbH4e0A30A:10 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=ZnlKyOwOOvErxwVJtToA:9 a=CjuIK1q_8ugA:10 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 9ACA0E10; Thu, 29 Aug 2024 05:42:37 -0700 (PDT) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 6E277483; Thu, 29 Aug 2024 05:42:37 -0700 (PDT) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Mathieu Arnold cc: Cy Schubert , Gleb Popov , Cy Schubert , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: ccc21de09381 - main - devel/binutils: Add devel/elfutils dependency options In-reply-to: <2ypgfpzxn7m4jzzbacyvrlw7htj5iyg7zwdb7mjcbknfjr3ee4@ipqdfyay3s4m> References: <202408281603.47SG35Q9035605@gitrepo.freebsd.org> <20240828180439.22B0730E@slippy.cwsent.com> <2ypgfpzxn7m4jzzbacyvrlw7htj5iyg7zwdb7mjcbknfjr3ee4@ipqdfyay3s4m> Comments: In-reply-to Mathieu Arnold message dated "Thu, 29 Aug 2024 07:44:33 +0200." List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 29 Aug 2024 05:42:37 -0700 Message-Id: <20240829124237.6E277483@slippy.cwsent.com> X-CMAE-Envelope: MS4xfBsF+EZejWZ+HkX14WMFu1HlllvV6/+Cx9zrDzSSJE6Ar71GvQDy4pDi23undCRaZ/OSHALlJkEIDCpZ2pz+M1LwDuG0sVyab3RZELdx3hWEpgZieyub to0LfiqMCJjxyVTOgdhVjrunFjOA6WjjoQSgYPnJyVeOqnYoKo+yp/RQZ8E3RtD20uPjJAyUpNAmvs7oDERo/9/oN6RQ87fTComhQma8+sCHPo3XVIi26z1I 8SXZx2mKzyjE/wy2O/IyKkJaWABKJWUFzwmZhobxcmh0zow20UOYVNkhDg1dcBorobLfPoevs5CQrp7QLvT5F+hJ/gU1uG5159/QMpqJRMkUJYZoWeu5uvO0 F4rmkgIx7Vt5Ri2XplEwzPQNffzKW+q8wawfvW+hPAOGXvgj/Lk= X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Rspamd-Queue-Id: 4Wvgss0Mybz4Z8x In message <2ypgfpzxn7m4jzzbacyvrlw7htj5iyg7zwdb7mjcbknfjr3ee4@ipqdfyay3s4m> , M athieu Arnold writes: > > > --t2cwj7kshsfy5exo > Content-Type: text/plain; charset=us-ascii > Content-Disposition: inline > Content-Transfer-Encoding: quoted-printable > > On Wed, Aug 28, 2024 at 11:04:39AM GMT, Cy Schubert wrote: > > In message ail.c > > om> > > , Gleb Popov writes: > > > On Wed, Aug 28, 2024 at 7:03=3DE2=3D80=3DAFPM Cy Schubert rg> wrote: > > > > > > > > +# In case devel/elfutils has been previously installed. > > > > +.if ${PORT_OPTIONS:MELFU_AUTO} && exists(${LOCALBASE}/lib/libdebugin= > fod.=3D > > > so) > > > > +LIB_DEPENDS+=3D3D libdebuginfod.so:devel/elfutils > > > > +.endif > > > > > > Hmm, this looks strange to me. LIB_DEPENDS is used to pull in > > > libraries that are missing, but then the "exists" condition will > > > always be false. > >=20 > > Correct. The condition will always be false when building with poudriere= > =20 > > but for those building the port by hand, and have manually installed=20 > > devel/elfutils prior to building and installing manually the condition wi= > ll=20 > > then be true. > >=20 > > Much committers' dismay some users don't use binary packages, you and I a= > s=20 > > committers prefer people use binary packages. But unfortunately this is n= > ot=20 > > always the case. The PR was submitted by a person who builds his ports by= > =20 > > hand. > > It would be better to disable the finding of libdebuginfod in LOCALBASE, > so that everyone has the same binutils, and nobody gets a possibly > different behavior. In other words, just let it auto-detect? -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0