Re: git: ccc21de09381 - main - devel/binutils: Add devel/elfutils dependency options
Date: Wed, 28 Aug 2024 18:04:39 UTC
In message <CALH631nFVYyks4DB+T8+C8r5Y6GHT4Su8mzhDaJ8BQ1=PMVZPA@mail.gmail.c om> , Gleb Popov writes: > On Wed, Aug 28, 2024 at 7:03=E2=80=AFPM Cy Schubert <cy@freebsd.org> wrote: > > > > +# In case devel/elfutils has been previously installed. > > +.if ${PORT_OPTIONS:MELFU_AUTO} && exists(${LOCALBASE}/lib/libdebuginfod.= > so) > > +LIB_DEPENDS+=3D libdebuginfod.so:devel/elfutils > > +.endif > > Hmm, this looks strange to me. LIB_DEPENDS is used to pull in > libraries that are missing, but then the "exists" condition will > always be false. Correct. The condition will always be false when building with poudriere but for those building the port by hand, and have manually installed devel/elfutils prior to building and installing manually the condition will then be true. Much committers' dismay some users don't use binary packages, you and I as committers prefer people use binary packages. But unfortunately this is not always the case. The PR was submitted by a person who builds his ports by hand. -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: https://FreeBSD.org NTP: <cy@nwtime.org> Web: https://nwtime.org e^(i*pi)+1=0