git: 9d7a750da6e7 - main - sysutils/htop: simplify Makefile

From: Vladimir Druzenko <vvd_at_FreeBSD.org>
Date: Thu, 22 Aug 2024 12:20:55 UTC
The branch main has been updated by vvd:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9d7a750da6e7b15b07f31b21e8bbe7b6d4178b24

commit 9d7a750da6e7b15b07f31b21e8bbe7b6d4178b24
Author:     Siva Mahadevan <me@svmhdvn.name>
AuthorDate: 2024-08-22 12:09:45 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-08-22 12:09:45 +0000

    sysutils/htop: simplify Makefile
    
    This change cleans up the Makefile to follow Porter's Handbook guidance.
    Here is the rationale for each change:
    * As per https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github,
      ports are urged to move to using Github releases instead of git tags.
      This change replaces USE_GITHUB with MASTER_SITES to statically point
      to htop release tarballs. This also requires the addition of USES=tar:xz
    * Remove USES=autoreconf because the release tarball doesn't need to run it
    * Remove USES=compiler:c11 since upstream https://github.com/htop-dev/htop
      states that a C99 compiler is needed.
    * Add USES=desktop-file-utils as the port installs htop.desktop
    * htop does not exist in the official NVD CPE dictionary, so as per
      https://docs.freebsd.org/en/books/porters-handbook/book/#uses-cpe, we
      should "not ever make up CPE data." Thus, USES=cpe is removed until an
      entry is contributed to the CPE dictionary
    * USES={libtool,localbase,pkgconfig,python:build,shebangfix} are not
      necessary for a successful build and run with the GH release tarball.
    * GNU_CONFIGURE_MANPREFIX was unnecessary since default value in
      Mk/bsd.port.mk is same ${PREFIX}/share
    
    PR:             280820
    Approved by:    Hung-Yi Chen <gaod@hychen.org> (maintainer)
---
 sysutils/htop/Makefile | 10 +++-------
 sysutils/htop/distinfo |  6 +++---
 2 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/sysutils/htop/Makefile b/sysutils/htop/Makefile
index 260bc3b87484..d2bb415f5b3a 100644
--- a/sysutils/htop/Makefile
+++ b/sysutils/htop/Makefile
@@ -1,7 +1,8 @@
 PORTNAME=	htop
 DISTVERSION=	3.3.0
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	sysutils
+MASTER_SITES=	https://github.com/${PORTNAME}-dev/${PORTNAME}/releases/download/${DISTVERSION}/
 
 MAINTAINER=	gaod@hychen.org
 COMMENT=	Better top(1) - interactive process viewer
@@ -10,14 +11,9 @@ WWW=		https://htop.dev/
 LICENSE=	GPLv2
 LICENSE_FILE=	${WRKSRC}/COPYING
 
-USES=		autoreconf compiler:c11 cpe libtool localbase \
-		ncurses pkgconfig python:build shebangfix
-
-USE_GITHUB=	yes
-GH_ACCOUNT=	htop-dev
+USES=		desktop-file-utils ncurses tar:xz
 
 GNU_CONFIGURE=	yes
-GNU_CONFIGURE_MANPREFIX=${PREFIX}/share
 CONFIGURE_ARGS=	--enable-unicode
 
 PLIST_FILES=	bin/htop \
diff --git a/sysutils/htop/distinfo b/sysutils/htop/distinfo
index d21bc33fcf9e..14506e79169a 100644
--- a/sysutils/htop/distinfo
+++ b/sysutils/htop/distinfo
@@ -1,3 +1,3 @@
-TIMESTAMP = 1707274617
-SHA256 (htop-dev-htop-3.3.0_GH0.tar.gz) = 1e5cc328eee2bd1acff89f860e3179ea24b85df3ac483433f92a29977b14b045
-SIZE (htop-dev-htop-3.3.0_GH0.tar.gz) = 406012
+TIMESTAMP = 1723667246
+SHA256 (htop-3.3.0.tar.xz) = a69acf9b42ff592c4861010fce7d8006805f0d6ef0e8ee647a6ee6e59b743d5c
+SIZE (htop-3.3.0.tar.xz) = 337956