From nobody Sun Aug 18 09:03:15 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WmqXK2X7pz5SkG7; Sun, 18 Aug 2024 09:03:45 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: from mail-vs1-f41.google.com (mail-vs1-f41.google.com [209.85.217.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WmqXJ2N15z47xV; Sun, 18 Aug 2024 09:03:44 +0000 (UTC) (envelope-from 6yearold@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of 6yearold@gmail.com designates 209.85.217.41 as permitted sender) smtp.mailfrom=6yearold@gmail.com Received: by mail-vs1-f41.google.com with SMTP id ada2fe7eead31-4928da539c3so987597137.1; Sun, 18 Aug 2024 02:03:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723971823; x=1724576623; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tqB8aUUbxFzMp/8Z+cF4rqGN+YLnlGUMEcbdG1UqhRM=; b=N7p0LJVYnqn3PgcaBAYFz0ppQ2rAd2OdZK9CcUYQUdtGvr0VEKIiNrUVZMdZtTE3Ns mEFHvsVh3Ul2Ap8bUi966AXPj2rL1H52qeuqJXmpMm/tyNfUQ3V5yyF72LxxrOTOiBZG 0uHtqR7JMRP8UPYhEdWQqO/jo7bjktb71pR7xDsryvzRXCGU2X8BcA/EUZTBx1GAMIpt JwOWRXNi1q/Gzt19XZC9IG+wFEUYEW1zwHGsY4ZW9K44uR4/6jCYWeWg6vrx3g+6Jc5n 4uvRXkT5UNgZxIAIvuBDEPeksNccRPBzicg1ZhHYQaKr3q/zB7cykWzXwz2RkO94cimx ovVQ== X-Forwarded-Encrypted: i=1; AJvYcCXqlCOqU82u5mDD4N8Q29HwNqbqbuLU7ExFW7extLj3OMT2qhqwN8neEXy9yr2py4Qt1jxdlHoCXRcUyeuMrXJSCOQU5KpRbPh3Ae/+nU6ITJc+MymifNG0B5AnmGslp1f+uJYuCkYthZzR/VuXNMdfAA+yr6i++OTNuBRusZ21q+bNQ3X+a74vNvC4kDC/jlO+KIg= X-Gm-Message-State: AOJu0Yw7DBkOo1Rthiu+Vhl63UAIUmsEXMbH/m2uMpM1j9z96HZnwQ8E gbXDbWo/9OKGeNC9VGucKLIsErFbn5olUrTS2yU9yNLpPm9w/3taMx8BF/1e X-Google-Smtp-Source: AGHT+IETAtc3d+MpPZdMNirH2duajAwx98/MVrCrJY21j4HCNLdUgOM29YtTGk0taRXxj+VLZXq++A== X-Received: by 2002:a05:6102:32d2:b0:48f:e8f9:5d9f with SMTP id ada2fe7eead31-497798c86c6mr6491168137.7.1723971822517; Sun, 18 Aug 2024 02:03:42 -0700 (PDT) Received: from mail-vk1-f176.google.com (mail-vk1-f176.google.com. [209.85.221.176]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-4976ff9f102sm991594137.31.2024.08.18.02.03.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Aug 2024 02:03:42 -0700 (PDT) Received: by mail-vk1-f176.google.com with SMTP id 71dfb90a1353d-4fc7bd8763cso380107e0c.2; Sun, 18 Aug 2024 02:03:42 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVTPSJrm/th3zVsgVEBLY+yPrhzUUNq6lqkkn35IsnXz53K0seZ18ZCz1qe9W+FM6mEkxSN8ehJ+9spVjuchsO3SuKaqORDEHvjYQjDXTgXW5WEq6UDxjrt+nv7GxnNQXU3hsmTjhqFGOnPgJCa+MWtWzdN/56dx1l5o8BfBH9Pr+V2kWXNxS+rQOVC8de8sxWRwT8= X-Received: by 2002:a05:6122:2a10:b0:4eb:499a:2453 with SMTP id 71dfb90a1353d-4fc6c96497dmr6962546e0c.8.1723971821942; Sun, 18 Aug 2024 02:03:41 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 References: <202408170839.47H8d1f6010111@gitrepo.freebsd.org> <7ad037a5-a92c-455e-b54c-9287e4fe5749@gmail.com> <2daca6fb-a217-4ed0-bafb-8c08c53423a0@gmail.com> In-Reply-To: <2daca6fb-a217-4ed0-bafb-8c08c53423a0@gmail.com> From: Gleb Popov Date: Sun, 18 Aug 2024 12:03:15 +0300 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: d191d48e545e - main - x11/kitty: Fix pkg-plist when DOCS option is off To: Nicola Vitale Cc: Nicola Vitale , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.81 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-0.99)[-0.989]; NEURAL_HAM_SHORT(-0.92)[-0.925]; FORGED_SENDER(0.30)[arrowd@freebsd.org,6yearold@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_THREE(0.00)[3]; FREEMAIL_TO(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; RCVD_IN_DNSWL_NONE(0.00)[209.85.221.176:received,209.85.217.41:from]; MLMMJ_DEST(0.00)[dev-commits-ports-all@freebsd.org,dev-commits-ports-main@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_NEQ_ENVFROM(0.00)[arrowd@freebsd.org,6yearold@gmail.com]; MISSING_XM_UA(0.00)[]; R_DKIM_NA(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.217.41:from]; TAGGED_RCPT(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_FIVE(0.00)[5] X-Rspamd-Queue-Id: 4WmqXJ2N15z47xV On Sun, Aug 18, 2024 at 11:14=E2=80=AFAM Nicola Vitale wrote: > > For sure, but no one completely follows the handbook I'd say that this is bad and we all should try better. If you're pointing fingers specifically at me, I'm always open to comments on my stuff. > and in fact many of you control every single commit that others do. And for that I'd say that this isn't bad at all. How's post-commit review worse than no review at all?