Re: git: d191d48e545e - main - x11/kitty: Fix pkg-plist when DOCS option is off
Date: Sun, 18 Aug 2024 05:47:06 UTC
On Sat, Aug 17, 2024 at 11:57:53PM GMT, Gleb Popov wrote: > On Sat, Aug 17, 2024 at 4:41 PM Nicola Vitale > <nicola.stanislao.vitale@gmail.com> wrote: > > > > Hi, > > > > thanks for the advice, but [1] the option MANPAGES is not present in the Porter's Handbook, and the section 5.12 (Man pages) says only that "manual pages must be placed in pkg-plist along with the rest of the files". This distinction between man pages and other docs is misleading in my opinion. "What are docs?" [2] > > > > Furthermore, x11/kitty is not the only one that uses %%PORTDOCS%%/share/man in pkg-plist, and NO_INSTALL_MANPAGES was removed a long time ago. > > Hum, it looks you're right. The `portgrep -o MANPAGES | wc -l` gives > only 204. It seems that MANPAGES option is indeed getting demoted. Well, not at all. Man pages have to always be installed when they are present in the distfiles. The MANPAGES option is only present when man pages need to be generated during the build, and the maintainer decided the tools needed were heavy and that it should be possible to disable building the man pages. (For example, you need doxygen, or some other big tool) > > [1] I don't remember swearing allegiance to the Porter's Handb...Bible. ;-) > > I believe, every Ports committer has to follow Porter's Handbook. Let > portmgr@ correct me if I'm wrong. You are correct, every ports committer must follow the porter's handbook. It defines a set of rules and guidelines that we all must follow so that all ports are written in the same way, and anyone can work on any port. You don't have to swear allegiance on it, it is a packaged deal, you become a committer, so you have to follow its rules, it's not optional. -- Mathieu Arnold