From nobody Wed Aug 07 16:47:11 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WfGL829qWz5SkvJ; Wed, 07 Aug 2024 16:47:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WfGL80kLTz43sX; Wed, 7 Aug 2024 16:47:12 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1723049232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9mTD9GBeoAeDrz+GLfbHIlyFsYitL8UJ8VLdZ22godk=; b=dlzKsyg4oGz39/fJHpgdxGuCwh2by4NTW/PndyX48PLyDPPaAlVAj3iQtR1Sot+qhX1UVY trPluje2weWOYLpmCavF4pjtrlOid758pEvty6Ri3+v/239p77P3ytSI2vrazPd4PBeLDL hk3ANHY+pVzm6fi8JWhp/mXLpvAQEWuSdnr7pRq5tN07X+wNMDKzW1oXRq/FgBog1SbhX5 IufRbztZ+EO8GY+DNGN4GhKwS4n8bgHugFQIexph9SRN3Cr58PPeW7aATsIR9zPqIAqNgb R69wXOwXIhKFMMh7FEs0lyXq0OUPoriJZ8NqNyRY2ZIH8vgJqKKFpGfzzPS1vg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1723049232; a=rsa-sha256; cv=none; b=VKsr/6+irOvgefp76HhsPv6GIc2LYTtzKivhRxhLuuQ86Kj3FmfWngm6SqOtNSRTOb34pj H9Knj1S4NZbBKitZevpg4RhLAQ5wkXlpvHp6ok5v5wI9dici0UUPEDR7GZwFm8efrf7so8 UXJEDn7lQHkM+9kvaQR91iH4yi8zXeP1VFsLLYgxGyZ7iELHqdkOMOyOfn2gByx2NA3qqn WuLS1XPYTjyHYxDKQbg8n8iI8be3BcbyOFhsH41BCK8gwdGargl2/OonnutoPirwrTL6Uh SmyZBuH+aly7PAfW3IaUGvkZs/LOTAbuh+1n+QDO4kso9rJBiNK+/v1Dul5eig== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1723049232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9mTD9GBeoAeDrz+GLfbHIlyFsYitL8UJ8VLdZ22godk=; b=tdpLCZS+vDEPNcacZGyEJ3RygUtxfhLtc2SIMJVRU6N6GWaiFFzrYqyqbxhxAEXE3UX3Lc BRMKwavKULuGmONOUplE8BjPtBCtMwCLu713psNLKL86Nkf7bjfrhg4diI0hwqvI1uiug/ N/mrSSNLZclhDEXiDQpgsjhTeFnxib9eluCHDQtPVpMOvnxwBFmFlwfrQlJaLtXIrFIEMj iVI0kRDQ0nPtgFswigx3upRhY4hXJRoats1CDeHtohc4gMI2mNm/goSBdal86FYSKbK6Id 6OJbShFmbklGtMavo5/H8PLF0+0nGGci182n2NsxnCGTAXqlYkRfptDLNLmAJw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WfGL80Fdyzy3y; Wed, 7 Aug 2024 16:47:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 477GlBRp042098; Wed, 7 Aug 2024 16:47:11 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 477GlBqP042095; Wed, 7 Aug 2024 16:47:11 GMT (envelope-from git) Date: Wed, 7 Aug 2024 16:47:11 GMT Message-Id: <202408071647.477GlBqP042095@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org From: Dimitry Andric Subject: git: 4c37f9f5f253 - main - java/openjdk17: fix build with clang 19 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: ports X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4c37f9f5f253a5701fa94ddfc00520889bca9ea4 Auto-Submitted: auto-generated The branch main has been updated by dim: URL: https://cgit.FreeBSD.org/ports/commit/?id=4c37f9f5f253a5701fa94ddfc00520889bca9ea4 commit 4c37f9f5f253a5701fa94ddfc00520889bca9ea4 Author: Dimitry Andric AuthorDate: 2024-08-01 16:05:22 +0000 Commit: Dimitry Andric CommitDate: 2024-08-07 16:44:49 +0000 java/openjdk17: fix build with clang 19 Clang 19 has a number of new warnings, and because java/openjdk17 compiles with -Werror by default, it results in errors similar to: /wrkdirs/usr/ports/java/openjdk17/work/jdk17u-jdk-17.0.12-7-1/src/hotspot/os/posix/signals_posix.cpp:1681:20: error: cast from 'void (*)(int, siginfo_t *, ucontext_t *)' (aka 'void (*)(int, __siginfo *, __ucontext *)') to 'void (*)(int)' converts to incompatible function type [-Werror,-Wcast-function-type-mismatch] 1681 | act.sa_handler = (void (*)(int)) SR_handler; | ^~~~~~~~~~~~~~~~~~~~~~~~~~ I propose to disable warnings-as-errors for this port, similar to what is already done for openjdk8 and openjdk11. It does not make sense to have this on by default, unless you are an upstream maintainer. PR: 280561 Approved by: glewis (maintainer) MFH: 2024Q3 --- java/openjdk17/Makefile | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/java/openjdk17/Makefile b/java/openjdk17/Makefile index a07a8f217518..f93a39d7ddb3 100644 --- a/java/openjdk17/Makefile +++ b/java/openjdk17/Makefile @@ -139,11 +139,7 @@ CONFIGURE_ARGS+= --with-extra-ldflags="-Wl,-rpath=${LOCALBASE}/lib/gcc${GCC_DEFA --with-extra-cxxflags="-Wl,-rpath=${LOCALBASE}/lib/gcc${GCC_DEFAULT}" .else MAKE_ENV+= USE_CLANG=true -EXTRA_CFLAGS+= -Wno-unused-but-set-parameter -EXTRA_CFLAGS+= -Wno-bitwise-instead-of-logical -EXTRA_CFLAGS+= -Wno-deprecated-non-prototype -CONFIGURE_ARGS+= --with-extra-cflags="${EXTRA_CFLAGS}" -CONFIGURE_ARGS+= --with-extra-cxxflags="${EXTRA_CFLAGS}" +CONFIGURE_ARGS+= --disable-warnings-as-errors .endif .if ${ARCH} == aarch64 || ${ARCH:Mpowerpc64*}