From nobody Tue Aug 06 21:49:54 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wdn6261Vpz5SjTZ for ; Tue, 06 Aug 2024 21:50:02 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Received: from www121.sakura.ne.jp (www121.sakura.ne.jp [153.125.133.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wdn621Jtxz4cL7; Tue, 6 Aug 2024 21:50:01 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Authentication-Results: mx1.freebsd.org; none Received: from kalamity.joker.local (123-1-21-232.area1b.commufa.jp [123.1.21.232]) (authenticated bits=0) by www121.sakura.ne.jp (8.17.1/8.17.1/[SAKURA-WEB]/20201212) with ESMTPA id 476Lns0q091042; Wed, 7 Aug 2024 06:49:55 +0900 (JST) (envelope-from junchoon@dec.sakura.ne.jp) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=dec.sakura.ne.jp; s=s2405; t=1722980996; bh=AKWsF4OJY9qZOnIiIjyC9XP33c6PkFh/qA1X4JH7ZDc=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=GVf6jIsezVzKrL5uj1B3x91wwedQatW5Ej4ALsUfdxn3Rm2nHbkKmp7uJqDgkSBJ8 2CY+U8a9ctEaP5hbt/jWGbzvDlVmIlxCQTSl3w/dHMVZhJEmnyLUGGeEA3aC9doND3 Zc5MnR6ML+wZrn87ygNT3Ad+fiO7aGnQxdX7eZEs= Date: Wed, 7 Aug 2024 06:49:54 +0900 From: Tomoaki AOKI To: Vladimir Druzenko Cc: Florian Walpen , dev-commits-ports-main@freebsd.org Subject: Re: git: 183213847e99 - main - audio/jack: Option for new OSS driver backend Message-Id: <20240807064954.17e31706b190c9e9a50f9c96@dec.sakura.ne.jp> In-Reply-To: References: <20240807021950.4049f07f9690d88f72392216@dec.sakura.ne.jp> <2513594.0dHE6SNnxz@z240> Organization: Junchoon corps X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.1) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:7684, ipnet:153.125.128.0/18, country:JP] X-Rspamd-Queue-Id: 4Wdn621Jtxz4cL7 Confirmed git: e01ecc142044. Thanks! On Tue, 6 Aug 2024 20:49:36 +0300 Vladimir Druzenko wrote: > Hello! > > It's my fault - added it for testing and forgot to remove before commit. > Fixed in: > https://cgit.freebsd.org/ports/commit/?id=e01ecc14204430b0799d5c4c9bcc77b5599672b4 > > 06.08.2024 20:30, Florian Walpen пишет: > > Hi Tomoaki, > > > > you're right, the SOSSO option is not meant to be default. And I just double- > > checked, it's not set as default in the PR. Vladimir, could you please correct > > that? > > > > Thanks everybody! > > > > Florian > > > > > > On Tuesday, August 6, 2024 7:19:50 PM CEST Tomoaki AOKI wrote: > >> Hi. > >> The newly added option "SOSSO" is added to OPTIONS_DEFAULT, too. > >> Should be forgotton to drop before committing, right? > >> > >> Regards. > >> > >>> The branch main has been updated by vvd: > >>> URL: > >> https://cgit.FreeBSD.org/ports/commit/?id=183213847e99429b8b297db54029fd9e80 > >> 741ced > >>> commit 183213847e99429b8b297db54029fd9e80741ced > >>> Author: Florian Walpen > >>> AuthorDate: 2024-08-06 14:53:06 +0000 > >>> Commit: Vladimir Druzenko > >>> CommitDate: 2024-08-06 14:53:06 +0000 > >>> > >>> audio/jack: Option for new OSS driver backend > >>> > >>> Add a non-default option to build the new OSS driver backend coming > >> in > >> > >>> the next JACK release. The backend is a complete rewrite based on the > >>> sosso library, with improved stability and low latency > >> capabilities. Let > >> > >>> users preview and test the new backend before it becomes default. > >>> Builds with default options are not affected, thus no PORTREVISION > >>> bump. > >>> > >>> While here, cleanup two checks in the RC service script, one of them > >>> deprecated, the other was ineffective by mistake. > >>> > >>> PR: 280611 > >>> > >>> --- > >>> > >>> audio/jack/Makefile | 9 +++++++-- > >>> audio/jack/distinfo | 4 +++- > >>> audio/jack/files/jackd.in | 6 ++---- > >>> 3 files changed, 12 insertions(+), 7 deletions(-) > >>> > >>> diff --git a/audio/jack/Makefile b/audio/jack/Makefile > >>> index b0f34b0f5572..ce432acbef53 100644 > >>> --- a/audio/jack/Makefile > >>> +++ b/audio/jack/Makefile > >>> @@ -30,8 +30,8 @@ SHEBANG_LANG= python3 > >>> > >>> CONFIGURE_ARGS= --celt=no --samplerate=yes > >>> > >>> -OPTIONS_DEFINE= ALSA DBUS OPUS PROFILING > >>> -OPTIONS_DEFAULT= DBUS OPUS > >>> +OPTIONS_DEFINE= ALSA DBUS OPUS PROFILING SOSSO > >>> +OPTIONS_DEFAULT= DBUS OPUS SOSSO > >> (snip) > > > > > > > > -- > Best regards, > Vladimir Druzenko > -- Tomoaki AOKI