Re: git: 183213847e99 - main - audio/jack: Option for new OSS driver backend

Hello!

It's my fault - added it for testing and forgot to remove before commit.
Fixed in:
https://cgit.freebsd.org/ports/commit/?id=e01ecc14204430b0799d5c4c9bcc77b5599672b4

06.08.2024 20:30, Florian Walpen пишет:
> Hi Tomoaki,
>
> you're right, the SOSSO option is not meant to be default. And I just double-
> checked, it's not set as default in the PR. Vladimir, could you please correct
> that?
>
> Thanks everybody!
>
> Florian
>
>
> On Tuesday, August 6, 2024 7:19:50 PM CEST Tomoaki AOKI wrote:
>> Hi.
>> The newly added option "SOSSO" is added to OPTIONS_DEFAULT, too.
>> Should be forgotton to drop before committing, right?
>>
>> Regards.
>>
>>> The branch main has been updated by vvd:
>>> URL:
>> https://cgit.FreeBSD.org/ports/commit/?id=183213847e99429b8b297db54029fd9e80
>> 741ced
>>> commit 183213847e99429b8b297db54029fd9e80741ced
>>> Author:     Florian Walpen <dev@submerge.ch>
>>> AuthorDate: 2024-08-06 14:53:06 +0000
>>> Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
>>> CommitDate: 2024-08-06 14:53:06 +0000
>>>
>>>      audio/jack: Option for new OSS driver backend
>>>      
>>>      Add a non-default option to build the new OSS driver backend coming
>> in
>>
>>>      the next JACK release. The backend is a complete rewrite based on the
>>>      sosso library, with improved stability and low latency
>> capabilities. Let
>>
>>>      users preview and test the new backend before it becomes default.
>>>      Builds with default options are not affected, thus no PORTREVISION
>>>      bump.
>>>      
>>>      While here, cleanup two checks in the RC service script, one of them
>>>      deprecated, the other was ineffective by mistake.
>>>      
>>>      PR:     280611
>>>
>>> ---
>>>
>>>   audio/jack/Makefile       | 9 +++++++--
>>>   audio/jack/distinfo       | 4 +++-
>>>   audio/jack/files/jackd.in | 6 ++----
>>>   3 files changed, 12 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/audio/jack/Makefile b/audio/jack/Makefile
>>> index b0f34b0f5572..ce432acbef53 100644
>>> --- a/audio/jack/Makefile
>>> +++ b/audio/jack/Makefile
>>> @@ -30,8 +30,8 @@ SHEBANG_LANG=	python3
>>>
>>>   CONFIGURE_ARGS=	--celt=no --samplerate=yes
>>>
>>> -OPTIONS_DEFINE=		ALSA DBUS OPUS PROFILING
>>> -OPTIONS_DEFAULT=	DBUS OPUS
>>> +OPTIONS_DEFINE=		ALSA DBUS OPUS PROFILING SOSSO
>>> +OPTIONS_DEFAULT=	DBUS OPUS  SOSSO
>>       (snip)
>
>
>

-- 
Best regards,
Vladimir Druzenko