From nobody Tue Aug 06 17:30:30 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WdgLp2YVCz5SLVZ for ; Tue, 06 Aug 2024 17:30:42 +0000 (UTC) (envelope-from dev@submerge.ch) Received: from pianosa.iway.ch (pianosa.iway.ch [IPv6:2001:8e0:40:325::37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4WdgLn1qcyz45jh; Tue, 6 Aug 2024 17:30:40 +0000 (UTC) (envelope-from dev@submerge.ch) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of dev@submerge.ch designates 2001:8e0:40:325::37 as permitted sender) smtp.mailfrom=dev@submerge.ch Received: from pianosa.iway.ch (localhost [127.0.0.1]) by localhost (Postfix) with ESMTP id E92BDE0C86; Tue, 6 Aug 2024 19:30:30 +0200 (CEST) X-Iway-Path: 0 Received: from localhost (localhost [127.0.0.1]) by localhost (ACF/11471.22686); Tue, 6 Aug 2024 19:30:30 +0200 (CEST) Received: from interway.li (sendai-sued.iway.ch [212.25.24.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pianosa.iway.ch (Postfix) with ESMTPS; Tue, 6 Aug 2024 19:30:30 +0200 (CEST) Received: from [145.40.196.39] (account fw@submerge.ch HELO z240.localnet) by sendai-sued.interway.li (CommuniGate Pro SMTP 7.1.0) with ESMTPSA id 247399508; Tue, 06 Aug 2024 19:30:30 +0200 From: Florian Walpen To: Vladimir Druzenko , Tomoaki AOKI Cc: dev-commits-ports-main@freebsd.org Subject: Re: git: 183213847e99 - main - audio/jack: Option for new OSS driver backend Date: Tue, 06 Aug 2024 19:30:30 +0200 Message-ID: <2513594.0dHE6SNnxz@z240> In-Reply-To: <20240807021950.4049f07f9690d88f72392216@dec.sakura.ne.jp> References: <20240807021950.4049f07f9690d88f72392216@dec.sakura.ne.jp> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.13 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.83)[-0.825]; CTE_CASE(0.50)[]; MID_RHS_NOT_FQDN(0.50)[]; R_SPF_ALLOW(-0.20)[+ip6:2001:8e0::/32]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; ASN(0.00)[asn:8758, ipnet:2001:8e0::/32, country:CH]; RCVD_TLS_ALL(0.00)[]; R_DKIM_NA(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-ports-main@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MISSING_XM_UA(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; DMARC_NA(0.00)[submerge.ch]; RCPT_COUNT_THREE(0.00)[3] X-Rspamd-Queue-Id: 4WdgLn1qcyz45jh Hi Tomoaki, you're right, the SOSSO option is not meant to be default. And I just double- checked, it's not set as default in the PR. Vladimir, could you please correct that? Thanks everybody! Florian On Tuesday, August 6, 2024 7:19:50 PM CEST Tomoaki AOKI wrote: > Hi. > The newly added option "SOSSO" is added to OPTIONS_DEFAULT, too. > Should be forgotton to drop before committing, right? > > Regards. > > > The branch main has been updated by vvd: > > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=183213847e99429b8b297db54029fd9e80 > 741ced > > commit 183213847e99429b8b297db54029fd9e80741ced > > Author: Florian Walpen > > AuthorDate: 2024-08-06 14:53:06 +0000 > > Commit: Vladimir Druzenko > > CommitDate: 2024-08-06 14:53:06 +0000 > > > > audio/jack: Option for new OSS driver backend > > > > Add a non-default option to build the new OSS driver backend coming > > in > > > the next JACK release. The backend is a complete rewrite based on the > > sosso library, with improved stability and low latency > > capabilities. Let > > > users preview and test the new backend before it becomes default. > > Builds with default options are not affected, thus no PORTREVISION > > bump. > > > > While here, cleanup two checks in the RC service script, one of them > > deprecated, the other was ineffective by mistake. > > > > PR: 280611 > > > > --- > > > > audio/jack/Makefile | 9 +++++++-- > > audio/jack/distinfo | 4 +++- > > audio/jack/files/jackd.in | 6 ++---- > > 3 files changed, 12 insertions(+), 7 deletions(-) > > > > diff --git a/audio/jack/Makefile b/audio/jack/Makefile > > index b0f34b0f5572..ce432acbef53 100644 > > --- a/audio/jack/Makefile > > +++ b/audio/jack/Makefile > > @@ -30,8 +30,8 @@ SHEBANG_LANG= python3 > > > > CONFIGURE_ARGS= --celt=no --samplerate=yes > > > > -OPTIONS_DEFINE= ALSA DBUS OPUS PROFILING > > -OPTIONS_DEFAULT= DBUS OPUS > > +OPTIONS_DEFINE= ALSA DBUS OPUS PROFILING SOSSO > > +OPTIONS_DEFAULT= DBUS OPUS SOSSO > > (snip)