Re: git: fe13eae316f8 - main - devel/libada: new port, WHATWG-compliant and fast URL parser

From: Daniel Engberg <daniel.engberg.lists_at_pyret.net>
Date: Sun, 04 Aug 2024 17:30:35 UTC
On 2024-08-04T18:39:47.000+02:00, Sergey A. Osokin <osa@FreeBSD.org>
wrote:

> The branch main has been updated by osa:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=fe13eae316f8d7f038d8e79bd2b61c7d2f2add78
> 
> commit fe13eae316f8d7f038d8e79bd2b61c7d2f2add78
> 
> Author:     Sergey A. Osokin <osa@FreeBSD.org>
> 
> AuthorDate: 2024-08-04 16:39:03 +0000
> 
> Commit:     Sergey A. Osokin <osa@FreeBSD.org>
> 
> CommitDate: 2024-08-04 16:39:03 +0000
> 
>     devel/libada: new port, WHATWG-compliant and fast URL parser
> 
>     
> 
>     Ada is a fast and spec-compliant URL parser written in C++.
> 
>     Specification for URL parser can be found from the WHATWG website.
> 
>     
> 
>     Connect to the build.
> 
> ---
> 
>  devel/Makefile         |  1 +
> 
>  devel/libada/Makefile  | 23 +++++++++++++++++++++++
> 
>  devel/libada/distinfo  |  3 +++
> 
>  devel/libada/pkg-descr |  2 ++
> 
>  devel/libada/pkg-plist | 37 +++++++++++++++++++++++++++++++++++++
> 
>  5 files changed, 66 insertions(+)
> 
> diff --git a/devel/Makefile b/devel/Makefile
> 
> index 5d996c8889f1..9cf314f5db3f 100644
> 
> --- a/devel/Makefile
> 
> +++ b/devel/Makefile
> 
> @@ -1176,6 +1176,7 @@
> 
>      SUBDIR += libPropList
> 
>      SUBDIR += libabigail
> 
>      SUBDIR += libac
> 
> +    SUBDIR += libada
> 
>      SUBDIR += libafterbase
> 
>      SUBDIR += libantlr3c
> 
>      SUBDIR += libantlr4
> 
> diff --git a/devel/libada/Makefile b/devel/libada/Makefile
> 
> new file mode 100644
> 
> index 000000000000..63aa8e2c0e65
> 
> --- /dev/null
> 
> +++ b/devel/libada/Makefile
> 
> @@ -0,0 +1,23 @@
> 
> +PORTNAME=    libada
> 
> +DISTVERSIONPREFIX=    v
> 
> +DISTVERSION=    2.9.0
> 
> +CATEGORIES=    devel www
> 
> +
> 
> +MAINTAINER=    osa@FreeBSD.org
> 
> +COMMENT=    WHATWG-compliant and fast URL parser
> 
> +WWW=        https://ada-url.com/
> 
> +
> 
> +LICENSE=    APACHE20
> 
> +LICENSE_FILE=    ${WRKSRC}/LICENSE-APACHE
> 
> +
> 
> +USES=        cmake localbase:ldflags
> 
> +USE_LDCONFIG=    yes
> 
> +
> 
> +CMAKE_OFF=    ADA_TESTING ADA_BENCHMARKS ADA_TOOLS
> 
> +CMAKE_ON=    BUILD_SHARED_LIBS
> 
> +
> 
> +USE_GITHUB=    yes
> 
> +GH_ACCOUNT=    ada-url
> 
> +GH_PROJECT=    ada
> 
> +
> 
> +.include <bsd.port.mk> [http://bsd.port.mk>];

Hi,

Build uses Python (apart from ninja) but is missing dependency listing
in port makefile or add CMAKE_DISABLE_FIND_PACKAGE_Python3 to
CMAKE_ON. You might also want to add CMAKE_DISABLE_FIND_PACKAGE_Git to
avoid any unintentional behaviour

Best regards,

Daniel (diizzy@)