From nobody Mon Apr 22 07:36:01 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VNH9d435fz5JXJb; Mon, 22 Apr 2024 07:36:05 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VNH9d3Vb7z44K1; Mon, 22 Apr 2024 07:36:05 +0000 (UTC) (envelope-from bapt@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713771365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wQtV7JKdGXdVY1j5mIV03hvhtSU3CKzPWxjUSdu/6DY=; b=s8XN9pkiX+vwJMfwyu/l4Ee6WrYdwQEVR7k5nzqV4KWqnS6BxFEjvacnzcHiHeNnGp7H8f zsZi+bufEN092jnqW5r0R4/gv5hYPG/xKGg0eKLYH9nMWb7V0wt8b+yCvYgdfeLf1e6u88 kY1BdUhe9bjfWf2VvFA8kP7NG785U29/pSWl9H6K2tdNu8vQxPrwdS5TiKm9E/9M6qbQlE a9N40xLF5WU/QvJznIKiE+oSRF6/IvnuDfCPK+/qkIq4CiQxhczITyMEHN9oaFPsKBb4Tt 1DLP4leXEnEsE1d/jCHpe7JeQ6KIwdNQCcHb+IrVFpHv00Icl75xgg8YIoAXWA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1713771365; a=rsa-sha256; cv=none; b=jSaISInZosKMx+Z7payGg/Wt/aARhpWRCg+d4UsVvmwOvGqc9ogF+7NSIK8eraprpSxSN4 KF+7oJrVl5eY7IlpJxHuOGvvwXZjRF5N53dEZUtFG8B+rJhcxfvtWMyUOpBidzaYnJjgh6 y3ohmvJsmbFEwsWY0SgIAgFPgb25NQiJhg8U3ydF9w7uqMxqKBQy8qWRK1Mx1QqQDtl/WW 1MgCBimX0/EtnONTh6WujGhYZ0kzI3rmVr1KFAuMec4o+v4kawdAx7ZEvsEJDznFJk/ylw kcH8xBmy+Pt+mF+0mDAoKW2p47JoJsusu0tJnTmMBMoWcjfoPBlCcRoLJcoDHQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713771365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wQtV7JKdGXdVY1j5mIV03hvhtSU3CKzPWxjUSdu/6DY=; b=eLRHn/iaSOCeZ+2pea6sAtwVMCwAWbpOJSDL2b+3tZRTKOs1vwl9pZw4b7AWx8gCyRa0D3 fBEnmdAib4Meiatqlxo0GGp4hhEoiDeGWVSCtVb2ymU5Ncp3fiATFvy8kZxl+Q31k07NKg +IhbVbBDvuxv5u9hT7di4n3A4sA1s4rjGDqnzJh2t3D/fEBwPsPdqUK2CYPn7mJmq7fSvA AqokoO4xPxqypsdptFNl2mXQTg9SJWcAzvgEBVvGDS6/PFUd5KYlMGtpco9++wNf9Ajkrh RXWrZflVH+XmIton0C81dpevCa2HyCE+xHpKAz0KKA7iB9uOYmGtmBU6WpUXtg== Received: from aniel.nours.eu (nours.eu [IPv6:2001:41d0:8:3a4d::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VNH9d2NPPz1DK3; Mon, 22 Apr 2024 07:36:05 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: by aniel.nours.eu (Postfix, from userid 1001) id 351AD1A4DC8; Mon, 22 Apr 2024 09:36:02 +0200 (CEST) Date: Mon, 22 Apr 2024 09:36:01 +0200 From: Baptiste Daroussin To: Emmanuel Vadot Cc: Jan Beich , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 171cdaf295e3 - main - graphics/mesa-libs: Fix LIB_DEPENDS Message-ID: <7ffgiv2du5qr3bugukwkg72mftocqqzwxc2wwzo77qohy6hqwz@oa5bk6ydlpva> References: <202404181222.43ICMgTf017930@gitrepo.freebsd.org> <20240420185554.b2e2e5e8c037f706684d5167@bidouilliste.com> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240420185554.b2e2e5e8c037f706684d5167@bidouilliste.com> On Sat 20 Apr 18:55, Emmanuel Vadot wrote: > On Sat, 20 Apr 2024 02:12:18 +0200 > Jan Beich wrote: > > > Emmanuel Vadot writes: > > > > > The branch main has been updated by manu: > > > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=171cdaf295e37c781f9a4999b05ea74da0bcd0f0 > > > > > > commit 171cdaf295e37c781f9a4999b05ea74da0bcd0f0 > > > Author: Emmanuel Vadot > > > AuthorDate: 2024-04-18 08:54:08 +0000 > > > Commit: Emmanuel Vadot > > > CommitDate: 2024-04-18 12:22:27 +0000 > > > > > > graphics/mesa-libs: Fix LIB_DEPENDS > > > > > > Mesa itself does not depend on libOpenGL.so from libglvnd but it needs > > > libglvnd at build stage. > > > Also it doesn't not depend on libwayland-egl.so but on libwayland-server.so > > > and libwayland-client.so > > > > > > Differential Revision: https://reviews.freebsd.org/D44831 > > > PR: 278324 > > > Reported by: autodep > > > Reviewed by: bapt > > > Sponsored by: Beckhoff Automation GmbH & Co. KG > > > > This partial revert of https://cgit.freebsd.org/ports/commit/?id=1a86bea35222 > > introduces inconsistency with other OpenGL providers. Also, consumers may[1] > > depend on mesa-libs but not libglvnd, breaking minimalistic jails e.g., > > > > $ trap 'poudriere jails -kj 132amd64' EXIT INT TERM > > $ poudriere jails -sj 132amd64 > > $ jail=132amd64-default > > $ prefix=$(jls -j $jail path) > > # prefer local packages > > $ sed -i '' -Ee '/url/s,".*","file:///packages",' \ > > -e '/mirror|signat|finger/d' \ > > $prefix/etc/pkg/FreeBSD.conf > > # Vulkan/OpenGL/OpenCL acceleration > > $ for p in 'dr[im]' 'dr[im]/*' 'pci'; do > > devfs -m $prefix/dev rule apply path $p unhide; > > done > > # pass through Wayland socket > > $ mkdir -p $prefix/$XDG_RUNTIME_DIR > > $ mount -t nullfs $XDG_RUNTIME_DIR $prefix/$XDG_RUNTIME_DIR > > # mirror local user > > $ jexec $jail pw user add $(id -un) -m -G wheel,video > > $ jexec $jail login -fp $(id -un) > > $ su root -c 'pkg install -qy glmark2 mesa-dri' > > $ glmark2-wayland > > Error: Error loading EGL library > > Error: main: Could not initialize canvas > > Isn't the problem that glmark2 does dlopen on libEGL ? > https://github.com/glmark2/glmark2/blob/master/src/gl-state-egl.cpp#L316 > I think that in this case libglvnd should be added to RUN_DEPENDS, > maybe we could add a USE_GL= egl:run or something like that. > The autodep features shows a lot of problem like that in the ports > tree. It does cause problems for example like you showed but in reality > most of this problem will be hidden because not having libglvnd on a > system is very rare. > Bapt, do you think I should revert this one or should we start fixing > ports for the autodep feature ? > > Cheers, > > > [1] $ comm -13 <(pkg rquery %ro libglvnd | sort) <(pkg rquery %ro mesa-libs | sort) > > benchmarks/glmark2 > > benchmarks/vkmark > > emulators/qemu-devel > > graphics/libosmesa > > graphics/mesa-dri > > multimedia/wf-recorder > > net-im/tg_owt > > net/neatvnc > > net/waypipe > > net/wayvnc > > x11-drivers/xf86-video-amdgpu > > x11-wm/cosmic-comp > > x11-wm/niri > > x11/virglrenderer > > x11/xdg-desktop-portal-hyprland > > x11/xdg-desktop-portal-hyprland > > x11/xdg-desktop-portal-wlr My view on it is LIB_DEPENDS is not for dlopened depencencies those should be provided via RUN_DEPENDS (and BUILD_DEPENDS if tested at build time) USE_GL=egl:run sounds like a good idea to me. Best regards, Bapt