Re: git: 28472e9722d8 - main - Revert "x11-fonts/noto*: Restructure and update"

Reply: Tĳl Coosemans : "Re: git: 28472e9722d8 - main - Revert "x11-fonts/noto*: Restructure and update""
In reply to: Tĳl Coosemans : "Re: git: 28472e9722d8 - main - Revert "x11-fonts/noto*: Restructure and update""
Go to: [ bottom of page ] [ top of archives ] [ this month ]
From: Po-Chuan Hsieh <sunpoet_at_freebsd.org>
Date: Mon, 08 Apr 2024 21:08:10 UTC
On Mon, Apr 1, 2024 at 5:46 AM Tĳl Coosemans <tijl@freebsd.org> wrote:

> On Mon, 1 Apr 2024 04:17:09 +0800 Po-Chuan Hsieh wrote:
> > On Mon, Mar 25, 2024 at 3:27 AM Tĳl Coosemans <tijl@freebsd.org> wrote:
> >> - You are using upstream distfiles that are quite large.  The distfiles
> >>   for the common (Latin, Greek, Cyrillic) fonts Sans, Sans Mono, and
> >>   Serif add up to 234MB.  These fonts will be installed by almost every
> >>   user that uses FreeBSD as a desktop now that DejaVu appears to have
> >>   been abandoned.  My proposal was to create our own distfiles and I
> >>   integrated that into makesum so the only extra step compared to a
> >>   normal version update was to upload the generated distfile to
> >>   freefall.  I was willing to take over maintainership in case you
> >>   didn't want to deal with that.  These distfiles add up to 27MB.  And
> >>   if we put the extra weights (ExtraBold,...) and widths (Condensed,...)
> >>   in a separate port like you did it would be only 2MB.
> >
> > The committed one is my second version of noto fonts update.
> > The previous version is to use the individual file from github.com just
> > like those Noto CJK ports.
> > I changed to upstream tarball because it's clearer/simpler and easier to
> > track.
> > I could change it back to the previous version for a smaller distfile
> > footprint.
> > Give me several days to clean up the Makefiles.
>
> Okay.
>
> >> - Some fonts have been split into x11-fonts/<font>-basic providing Bold,
> >>   BoldItalic, Italic, and Regular, and x11-fonts/<font>-extra providing
> >>   additional styles.  Only some of these have x11-fonts/<font> as a
> >>   metaport currently.  This needs to be made consistent.  I think it
> >>   would be best to drop the metaports and move x11-fonts/<font>-basic to
> >>   x11-fonts/<font>.  That way pkg install <font> installs the common
> >>   styles for all fonts.  I think that this would be the most
> >>   intuitive/convenient.
> >>   (I was hoping to use subpackages for this instead of extra ports.)
> >
> > The -basic/-extra structure was kept for minimal change.
> > I agree with you that it would be better to be consistent with all other
> > noto ports.
> > I could merge the following ports:
> > - noto-sans-basic/-extra
> > - noto-sans-mono-basic/-extra
> > - noto-sans-symbols-basic/-extra
> > - noto-serif-basic/-extra
> > However, what should be noto-basic's dependencies after the merge?
>
> It's okay to keep the -extra ports.  What I meant was to rename the
> -basic ports so noto-sans-basic becomes noto-sans for example.
>

I've prepared a patch [1] for the following changes:
- Merge x11-fonts/noto-sans-{basic,extra} to x11-fonts/noto-sans
- Merge x11-fonts/noto-sans-mono-{basic,extra} to x11-fonts/noto-sans-mono
- Merge x11-fonts/noto-sans-symbols-{basic,extra} to
x11-fonts/noto-sans-symbols
- Merge x11-fonts/noto-serif-{basic,extra} to x11-fonts/noto-serif
- Update x11-fonts/noto-basic to depend on the 4 merged ports
- Update x11-fonts/noto-extra by removing the 4 -extra ports from
RUN_DEPENDS

[1]  https://people.freebsd.org/~sunpoet/patch/noto.txt


> >> - x11/noto-emoji now installs the COLRv1 version of Noto Color Emoji but
> >>   this isn't supported yet by graphics/cairo so emoji are broken now in
> >>   gtk applications.  I think Ghostscript doesn't support it either.  It
> >>   has to be removed again for now.
> >
> > It is handled in PR 278019 and
> > ports 2878ca490586207c3cd7bb3ff94d1274f52013b0.
>
> Okay.
>
> >> - Besides Noto Color Emoji there's also the monochrome Noto Emoji that
> >>   can be useful in print.  I think we should let x11-fonts/noto-emoji
> >>   install the monochrome font and move the existing x11-fonts/noto-emoji
> >>   to x11-fonts/noto-color-emoji so the names match.
> >
> > How about putting all emoji in the existing port (x11-fonts/noto-emoji)?
>
> That's up to you as maintainer.  I would keep them apart because they
> have different releases, version numbers and different upstreams.  For
> NotoEmoji there are also additional weights you could put in an -extra
> port:
>
> NotoEmoji-Light.ttf (extra)
>
> https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs-ar6uWaGWuob_10jwvS-FGJCMY.ttf
> NotoEmoji-Regular.ttf
> <https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs-ar6uWaGWuob_10jwvS-FGJCMY.ttfNotoEmoji-Regular.ttf>
> (basic)
>
> https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs-ar6uWaGWuob-r0jwvS-FGJCMY.ttf
> NotoEmoji-Medium.ttf
> <https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs-ar6uWaGWuob-r0jwvS-FGJCMY.ttfNotoEmoji-Medium.ttf>
> (extra)
>
> https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs-ar6uWaGWuob-Z0jwvS-FGJCMY.ttf
> NotoEmoji-SemiBold.ttf
> <https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs-ar6uWaGWuob-Z0jwvS-FGJCMY.ttfNotoEmoji-SemiBold.ttf>
> (extra)
>
> https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs-ar6uWaGWuob911TwvS-FGJCMY.ttf
> NotoEmoji-Bold.ttf
> <https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs-ar6uWaGWuob911TwvS-FGJCMY.ttfNotoEmoji-Bold.ttf>
> (basic)
>
> https://fonts.gstatic.com/s/notoemoji/v47/bMrnmSyK7YY-MEu6aWjPDs-ar6uWaGWuob9M1TwvS-FGJCMY.ttf
>