From nobody Sat Sep 16 08:29:54 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rnkkz4Gfdz4sccF; Sat, 16 Sep 2023 08:30:03 +0000 (UTC) (envelope-from diizzy@FreeBSD.org) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::222]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rnkky1DDsz4PKX; Sat, 16 Sep 2023 08:30:02 +0000 (UTC) (envelope-from diizzy@FreeBSD.org) Authentication-Results: mx1.freebsd.org; dkim=none; spf=softfail (mx1.freebsd.org: 2001:4b98:dc4:8::222 is neither permitted nor denied by domain of diizzy@FreeBSD.org) smtp.mailfrom=diizzy@FreeBSD.org; dmarc=none Received: by mail.gandi.net (Postfix) with ESMTPA id A36D14000A; Sat, 16 Sep 2023 08:29:54 +0000 (UTC) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Date: Sat, 16 Sep 2023 10:29:54 +0200 From: Daniel Engberg To: Jan Beich Cc: Po-Chuan Hsieh , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 616e8c13a4ce - main - devel/utf8cpp: Update to 3.2.4 In-Reply-To: <3740bc927d27be9617ea40809a7a91fd@pyret.net> References: <202308161944.37GJifUD062454@gitrepo.freebsd.org> <5be35ca3e7ac2390fdbce2e4792223b5@pyret.net> <3740bc927d27be9617ea40809a7a91fd@pyret.net> Message-ID: <4a06ad33002ef078bcdb53029568e09e@FreeBSD.org> X-Sender: diizzy@FreeBSD.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-GND-Sasl: daniel.engberg@pyret.net X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.97 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.77)[-0.774]; MIME_GOOD(-0.10)[text/plain]; RCVD_IN_DNSWL_LOW(-0.10)[2001:4b98:dc4:8::222:from]; MLMMJ_DEST(0.00)[dev-commits-ports-all@freebsd.org,dev-commits-ports-main@freebsd.org]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:29169, ipnet:2001:4b98::/32, country:FR]; FROM_EQ_ENVFROM(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all]; MID_RHS_MATCH_FROM(0.00)[]; FREEFALL_USER(0.00)[diizzy]; ARC_NA(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_SOME(0.00)[]; DMARC_NA(0.00)[freebsd.org]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspamd-Queue-Id: 4Rnkky1DDsz4PKX On 2023-08-19 09:40, Daniel Engberg wrote: > On 2023-08-19 09:09, Jan Beich wrote: >> Daniel Engberg writes: >> >>> On 2023-08-16 21:44, Po-Chuan Hsieh wrote: >>>> --- a/devel/utf8cpp/Makefile >>>> +++ b/devel/utf8cpp/Makefile >>>> @@ -1,9 +1,9 @@ >>>> PORTNAME= utf8cpp >>>> +PORTVERSION= 3.2.4 >>>> DISTVERSIONPREFIX= v >>>> -DISTVERSION= 3.2.3 >> [...] >>> Can you please revert you changes so the port don't deviate from >>> Porters Handbook? >>> https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github >>> - Example 16 >> >> Did you overquote the whole commit just for DISTVERSION vs. >> PORTVERSION ? >> Neither portlint nor portclippy warn about mixing PORTVERSION with >> DISTVERSIONPREFIX. >> >>>> @@ -11,20 +11,14 @@ LICENSE= BSL >>>> LICENSE_FILE= ${WRKSRC}/LICENSE >>>> USES= cmake >>>> -USE_GITHUB= yes >>>> -GH_ACCOUNT= nemtrif >>>> -GH_PROJECT= utfcpp >>>> + >>>> +CMAKE_ON= UTF8_INSTALL >>>> +CMAKE_OFF= UTF8_SAMPLES UTF8_TESTS >>>> NO_ARCH= yes >>>> -PLIST_FILES= include/utf8cpp/utf8.h \ >>>> - include/utf8cpp/utf8/checked.h \ >>>> - include/utf8cpp/utf8/core.h \ >>>> - include/utf8cpp/utf8/cpp11.h \ >>>> - include/utf8cpp/utf8/cpp17.h \ >>>> - include/utf8cpp/utf8/unchecked.h \ >>>> - lib/cmake/utf8cpp/utf8cppConfig.cmake \ >>>> - lib/cmake/utf8cpp/utf8cppConfigVersion.cmake \ >>>> - lib/cmake/utf8cpp/utf8cppTargets.cmake >>>> +USE_GITHUB= yes >>>> +GH_ACCOUNT= nemtrif >>>> +GH_PROJECT= utfcpp >> >> Another style regression: out of order USE_GITHUB group of variables. >> https://docs.freebsd.org/en/books/porters-handbook/order/#porting-order-uses >> Noticed via portclippy from ports-mgmt/portfmt. > > > ...and ordering indeed > > DISTVERSIONPREFIX after DISTVERSION, > USE_GITUB - Example 19,20 etc > > Just as you noted > > Best regards, > Daniel Friendly ping Best regards, Daniel