From nobody Fri Sep 08 15:01:52 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rhzpq0zP9z4sJKZ; Fri, 8 Sep 2023 15:01:55 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rhzpq0TrWz3TDC; Fri, 8 Sep 2023 15:01:55 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1694185315; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UWWh1WY+ClcQ8yFd1F6aAmqkckKO0XMo6Z9g5N6D+X4=; b=DvrkP3+DiLKWtoF/66x8LTnGCIGAakGTg2DCpTi7FlMcQs7ut3IvmZ+RFKxs+QOS6kE9k7 sdU7t4krqXEuUafvce8NAVn3IMKBPuzAzZuCadXcrdRefZDWw7Od3xDOhxj/T1n+vdauoq nQ6NdlYB5QvpYDmdjzvgcay23x9yquehla/WpZBpLkf9QoDAxABmVKVjWXZwVZwtChW1M7 HmEY/RJt2BPN9y1/TJ86XWrpSvjZCyxt9bxNVEqbpv/CJYeErk+XU0oyqmN0l9om11p4vR q0+EBn5StDyM5uSNctQgaYeYCkb+jSQXhU5JF4NauNOVM0VGaLdJJn1ceoz20A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1694185315; a=rsa-sha256; cv=none; b=JDMY1tw8L1r6f+N0YqTGafHKgQog59A0FKN8u4AN9FzwczOXybtzjOXmeOxZbGea3uixYR uunJVBvI/EdaoNz3uU2lgNT3YzUvAWrCQBHrboD0oCmD4HC64U3ayHZfo8HI1ULtXiKnfo PMCErAm33WRKK1GmLdhaSVxWruhegUodPcuLJBhLOd7JcC42qm2RdoBzVOVW9yjNMbUP5K FHTTj6GpS3jrJWiJ2ktwSkEpkFaWQmr0PTpzkTRR6WxMR7sHiqqKT/fNC9JeXFXdV+GbWR 7xPaGJ7N0hNj82JxIyzWoK8QHd/yHjxNtoEvSfmPa+eki/ERw3g2muiAAT/qPw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1694185315; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UWWh1WY+ClcQ8yFd1F6aAmqkckKO0XMo6Z9g5N6D+X4=; b=BIJQHryQCprsUUo5SlP4nw+V0Q6+YH4EH5IrXW28yrhn8XXpBTb6OwhxmeG92U2MjwWhOt UUcX/p9D8eyfUt3wjmrW0bbrnxWOh5cugruxDow5oiUMVyPjpx7MYL5fg3pmMtoGKwtlss tr6MhOQmNzmmvpwnVIgOOfjVpntSM4QBVWIbGlTHVcMDYhDWzyzmjmalasEkmJxVdD/dsS n5PWxBJ43JD0Jr8ycbOZg4Osi3G7SWaWX0zG84NOAs6Oip+ma82WQcB1QsRN/gjhzsG7mw 15/h6hzXc70bxeMVpqSloGqC8MbfHPIsL3Xhg8wtUgdcGiJutCFdcZswaaJAxQ== Received: from [IPV6:2a01:e11:2002:4280::13:1] (unknown [IPv6:2a01:e11:2002:4280::13:1]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: madpilot/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Rhzpp1F3YzCPG; Fri, 8 Sep 2023 15:01:54 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Message-ID: Date: Fri, 8 Sep 2023 17:01:52 +0200 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: git: f11ed4160472 - main - devel/libgit2: update to 1.6.4 Content-Language: en-US To: Charlie Li , Matthias Fechner , ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org References: <202309081035.388AZWKP075486@gitrepo.freebsd.org> <6e61cd7f-fa81-a6e9-f601-996a3a21162b@FreeBSD.org> <360a5750-d765-0ef3-99fc-30997e997abd@freebsd.org> From: Guido Falsi In-Reply-To: <360a5750-d765-0ef3-99fc-30997e997abd@freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 08/09/23 16:09, Charlie Li wrote: > Guido Falsi wrote: >> The commit which added the patch to fix this is here: >> >> https://cgit.freebsd.org/ports/commit/devel/libgit2?id=a62f1b5796b641bb502b33f7f073238a49dc4d0c >> >> >> Looking at upstream it looks like this fix is included there only >> starting from version 1.7.0 (correct me if I'm wrong) >> >> I'll take a look at adding back the patch. >> > I have 1.7.1 locally without any additional patching. However, we may > need an additional ${CMAKE_ARGS} to pass ${OPENSSLBASE} so that CMake > picks up the correct USES=ssl implementation, because it's > unconditionally picking up the base system one. > Updating to an even newer version would be good too. Hoping getting it to take the correct ssl library is that easy and does not require cmake changes. Anyway I'm testing adding back the patch keeping version 1.6.4 for now, which looks like the safest and quickest path to fixing things. -- Guido Falsi