From nobody Fri Sep 08 14:06:58 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RhybV3xDcz4svJ0; Fri, 8 Sep 2023 14:07:02 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RhybV3Tlgz4bvH; Fri, 8 Sep 2023 14:07:02 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1694182022; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RyOrE3RiSoOBfWR/poiez2034lpgbRgrjif78/IY6Hs=; b=mcfVlE6L8FLIdBTrwW9WDs8N4LPDmgK5xqp5F98APddEEDIcYdEtCaLAa7VKPJTQ7IyHPM KB/lhUyrM+vgeuBXvCoAr738zIomm6vE//rv2X1QKZB/+LYB822NzaAqrbyyNHDU0A3mLV +W/q1KZnvCDfYVQVdOhW029EHN6sqBo+yLBVHhT4ARYKjRABA3dJuTV1wOgMfmeBy4H6Av MA91iHR/MvgjCTt8zNZlPyi6pIftQigpm+sEczIoebRghUd9bQZliHw+zRQZ5zAPUGGJqq NYfnrMwtmKiyV7C3qEjLl/0amI4waVBLuR1xqkuAWKG42UHRSCDzAmJfo2JxlA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1694182022; a=rsa-sha256; cv=none; b=k0cSADAzfitVR+4nkYHS8Teeq8thLRqjK1ldxsSrTNMTF9Ihr8pxsDnpgZ6nfvvK+twR5w nxN76FV0N2r0z3DOdxNTWiJF/d3PbpM8V8WnvFbJImRDzXOQGiYC1jh9QSD4JqhCDpKjLJ eKlrYMnAl4QHeNcW0CAk6GGzcduGMbxKBLf+I2kgVa1DexZq24KL2GeZmgOzzwS6DsYfR3 5GXz8iaknKnF6XLrFNPdQMlTHS2ds+ddZ+jSgRHqYghUG6peKyjrQk51cbb9ZsVIfr6cH4 KQDtGlWfXOqpITNrkBveRiBs8iLy4BSwbNWOyDh4H0hUWTtLP9gBw916knAxuA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1694182022; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RyOrE3RiSoOBfWR/poiez2034lpgbRgrjif78/IY6Hs=; b=LM87UxsU9lbH/lU2ZUzesD0KlmzV34Phvfjm/YW8JqjeYg9D184pHvPZH08aSQEjgIjxnu fUjSa4Qpg9oA+YFksmxCmS3GfGcVMBAX/IXXWptbKsddSGD++qadCnGkB1jBSqb6Fr+fcG R7P13nbbaMAvHRQ0zdLpWbXNx6It+yc6Yu18SPvoFE/OBkqXYQlJ5yO9XKlG3X+xjpuU24 IhxfyKEI6xNffNs5ng+YggxZru5NkdyI+AMONnKkcvn1CY5BUt1ZwP50z4e2oJRk9dR1Wu PUa6y8kYx0+lFCeC3nOL9MSJt0nVntKw9tVCNKIvnf/oGuF59IORIsf/j1eKyA== Received: from [IPV6:2a01:e11:2002:4280::13:1] (unknown [IPv6:2a01:e11:2002:4280::13:1]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: madpilot/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4RhybT5hg2z8w8; Fri, 8 Sep 2023 14:07:01 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Message-ID: <6e61cd7f-fa81-a6e9-f601-996a3a21162b@FreeBSD.org> Date: Fri, 8 Sep 2023 16:06:58 +0200 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 To: Matthias Fechner , ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org References: <202309081035.388AZWKP075486@gitrepo.freebsd.org> Content-Language: en-US From: Guido Falsi Subject: Re: git: f11ed4160472 - main - devel/libgit2: update to 1.6.4 In-Reply-To: <202309081035.388AZWKP075486@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 08/09/23 12:35, Matthias Fechner wrote: > The branch main has been updated by mfechner: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=f11ed41604723ab3c75c6a108850858b7efd4f10 > > commit f11ed41604723ab3c75c6a108850858b7efd4f10 > Author: Matthias Fechner > AuthorDate: 2023-09-02 09:07:59 +0000 > Commit: Matthias Fechner > CommitDate: 2023-09-08 10:34:38 +0000 > > devel/libgit2: update to 1.6.4 > > Required for gitlab-ce 16.3. > Bump of pending ports will be done in another commit. > > Changelog: > https://github.com/libgit2/libgit2/tags Hi, This commit removed a patch required to make it build with clang 16 (default in FreeBSD 14 and 15/head). This version fails with errors: /wrkdirs/usr/ports/devel/libgit2/work/libgit2-1.6.4/src/util/util.c:731:28: error: incompatible function pointer types passing 'int (void *, const void *, const void *)' to parameter of type 'int (*)(const void *, const void *, void *)' [-Wincompatible-function-pointer-types] qsort_s(els, nel, elsize, git__qsort_r_glue_cmp, &glue); ^~~~~~~~~~~~~~~~~~~~~ /usr/include/stdlib.h:396:11: note: passing argument to parameter here int (*)(const void *, const void *, void *), void *); ^ 1 error generated. The commit which added the patch to fix this is here: https://cgit.freebsd.org/ports/commit/devel/libgit2?id=a62f1b5796b641bb502b33f7f073238a49dc4d0c Looking at upstream it looks like this fix is included there only starting from version 1.7.0 (correct me if I'm wrong) I'll take a look at adding back the patch. -- Guido Falsi