From nobody Sat Sep 02 16:44:01 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RdLMS5sRtz4sBtp; Sat, 2 Sep 2023 16:44:04 +0000 (UTC) (envelope-from cmt@burggraben.net) Received: from smtp.burggraben.net (smtp.burggraben.net [88.198.69.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.burggraben.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RdLMR6gSvz4WWx; Sat, 2 Sep 2023 16:44:03 +0000 (UTC) (envelope-from cmt@burggraben.net) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of cmt@burggraben.net designates 88.198.69.140 as permitted sender) smtp.mailfrom=cmt@burggraben.net; dmarc=none Received: from elch.exwg.net (elch.exwg.net [IPv6:2001:470:7120:1:127b:44ff:fe4f:148d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "elch.exwg.net", Issuer "R3" (not verified)) by smtp.burggraben.net (Postfix) with ESMTPS id A219DC00313; Sat, 2 Sep 2023 18:44:01 +0200 (CEST) Received: by elch.exwg.net (Postfix, from userid 1000) id 4CD113AB03; Sat, 2 Sep 2023 18:44:01 +0200 (CEST) Date: Sat, 2 Sep 2023 18:44:01 +0200 From: Christoph Moench-Tegeder To: Baptiste Daroussin Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 8e3a5d951eb8 - main - devel/pkgconf: update to 2.0.2 Message-ID: References: <202309011338.381DcplN040273@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <202309011338.381DcplN040273@gitrepo.freebsd.org> User-Agent: Mutt/2.2.11 (2023-08-18) X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.38 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-0.998]; NEURAL_HAM_SHORT(-0.88)[-0.884]; RCVD_IN_DNSWL_MED(-0.20)[88.198.69.140:from]; R_SPF_ALLOW(-0.20)[+ip4:88.198.69.140]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; BLOCKLISTDE_FAIL(0.00)[2001:470:7120:1:127b:44ff:fe4f:148d:server fail]; FROM_EQ_ENVFROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-ports-all@freebsd.org,dev-commits-ports-main@freebsd.org]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; TO_DN_SOME(0.00)[]; DMARC_NA(0.00)[burggraben.net]; FREEFALL_USER(0.00)[cmt]; ARC_NA(0.00)[]; ASN(0.00)[asn:24940, ipnet:88.198.0.0/16, country:DE]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Queue-Id: 4RdLMR6gSvz4WWx Hi, ## Baptiste Daroussin (bapt@FreeBSD.org): This patch causes a regression: > diff --git a/devel/pkgconf/files/patch-modversion-comparison b/devel/pkgconf/files/patch-modversion-comparison > new file mode 100644 > index 000000000000..a8d4c26e6c0a > --- /dev/null > +++ b/devel/pkgconf/files/patch-modversion-comparison > @@ -0,0 +1,13 @@ > +diff --git cli/main.c cli/main.c > +index 25ff5ca..d75bbb7 100644 > +--- cli/main.c > ++++ cli/main.c > +@@ -306,7 +306,7 @@ apply_modversion(pkgconf_client_t *client, pkgconf_pkg_t *world, void *data, int > + pkgconf_dependency_t *dep = world_iter->data; > + pkgconf_pkg_t *pkg = dep->match; > + > +- if (strncmp(pkg->id, queue_node->package, strlen(pkg->id))) > ++ if (strcmp(pkg->id, queue_node->package)) > + continue; > + > + if (pkg->version != NULL) { Because: from source 1.8.1 pkgconf-1.8.1$ ./pkgconf --modversion 'gtk+-2.0 >= 2.0.0' 2.24.33 and from source 2.0.2: pkgconf-2.0.2$ ./pkgconf --modversion 'gtk+-2.0 >= 2.0.0' 2.24.33 but as installed (with patch): tmp$ /usr/local/bin/pkgconf --modversion 'gtk+-2.0 >= 2.0.0' tmp$ That's bad because perl's ExtUtils::PkgConfig (from devel/p5-ExtUtils-PkgConfig p5-ExtUtils-PkgConfig-1.16) relies on the old behaviour - and at least x11-toolkits/p5-Gtk2 now fails. Regards, Christoph -- Spare Space