Re: git: 9263318fd2cc - main - math/blahtexml: revert/redo previous bogus build "fix" against Clang 16

From: Gunther Nikl <gnikl_at_justmail.de>
Date: Fri, 01 Sep 2023 15:22:20 UTC
On Thu, 31 Aug 2023 02:08:56 GMT Alexey Dokuchaev <danfe@FreeBSD.org>
wrote:
> The branch main has been updated by danfe:
> 
> URL:
> https://cgit.FreeBSD.org/ports/commit/?id=9263318fd2cce6e185f721d0e1f50c2818ada19f
> 
> commit 9263318fd2cce6e185f721d0e1f50c2818ada19f
> Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
> AuthorDate: 2023-08-31 02:08:10 +0000
> Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
> CommitDate: 2023-08-31 02:08:10 +0000
> 
>     math/blahtexml: revert/redo previous bogus build "fix" against
> Clang 16 
>     - Patch the makefile to respect CXXFLAGS so that USE_CXXSTD=c++11
> works as intended and remove the whole `USES+=llvm:max=15' abomination

Thank you for doing it right!
The way the llvm16 "mess" was tackled in the ports tree is quite
surprising :-/ Checking the system version felt wrong, since it would
ignore user choices, either on the commandline or from /etc/make.conf. 

>     - While here, convert to USES+=iconv, and drop MAKE_ARGS and
> LDFLAGS as we need to patch that line in the makefile anyway

So the libiconv port is not required anymore? Good!

Gunther