From nobody Sat Oct 07 11:51:26 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S2kCj1jqDz4wqnC; Sat, 7 Oct 2023 11:51:29 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S2kCj1FwZz3f9t; Sat, 7 Oct 2023 11:51:29 +0000 (UTC) (envelope-from mat@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696679489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8AQRE0PtO0TJTsD3bD8v1wtJxBxC6QdwjDx3Em67jeA=; b=nwdIwJeo3X0g/hSuw1dx9yNz4Ry+qvkHwAIUL8nD7RvVObfefOpsnsSfHMxDo0wGcUW8q2 O04LGlIMl88qFNAkC4PX7QgQci99sZmsoE2z6aw+fHiCYBMcUsWy7idGsQOIkZjwo2c0O6 tPBbFN9Kc14vEbIPT0jVKnQk661wLKh103IFYMmuzuJuVP7HPSl9FHz6hL5iqCKtfHSzCV U08EYgtjzCW3vY5k2S5XM0MykRA4w7utrgVi3r7pKSgdBEkfgglg0bxijF0300Yj0Ihf9S nH9Fy37I0qs9O4Xt7EnpOiUyA5jRx1gxRj+Tj1R7og3R5BEXRnLO12WPhwqQ/A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1696679489; a=rsa-sha256; cv=none; b=qz5++55AH+sMGN2MrY3gOaXGxGVxQMJZTubmL1ELWQBAVx+I4oTP6vSGMDaVQoG4FyGg9Q csiv1+o2074IoL+xe7zdFK/u5QDuttHfUCsPmAYE4tdWRwCFngpUfINVJ5atD8cV77Tg/I mEOoPWHJjiYmE+iQuyxrDSBxYQlhIN8q7at9G7PrX7SEfZ/u/yDN3chyVKke0mO2AbDsw9 G5003B8Xv2HUlUFBPpsOa16ZW1HpIPHOgj2eqADmcMgGUfLbtvEFcVeytGb/8K9vLQ1wLK SXcg6wCwc5LnzxW6+InN6bIGsqM3M90Ied+DnJEGRicad4CNx7jcZcyMHkeyGA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696679489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8AQRE0PtO0TJTsD3bD8v1wtJxBxC6QdwjDx3Em67jeA=; b=i+P3giqEfE2UwWDFILNgKefT5JH6Z3+gsf+BTBAHZGaeokNCGkjlccuqGgdc+Q+Sz43RX2 SVkJ+7JAnWx968jafmvZIEcErOeEBg7JSp5qPei+gZrBvakIoLl6Sm+ppcOck0jT3J3PaJ jmLbdqc3bTA/WJwxe8nRXERDAKxo2qkW4u1g6GXFB7jCst7J7Ih4RBjSUAYwa5SRzTfhEo Gm812UMpGVFjbiKPyEfPwVWL3b89z3fd7PpDp4Pj6zBblFWOYGLAd8Kvbd3dHQ72uToV9N RF6CaQS/7X0ok5N1neKjGUxkCDwHXD3oLMURbeWtGb82dLLNxjcfwwIqi5xO2A== Received: from mail.j.mat.cc (owncloud.cube.mat.cc [IPv6:2a01:678:4:1::228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail.mat.cc", Issuer "R3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4S2kCh6pfwzljp; Sat, 7 Oct 2023 11:51:28 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from aching.in.mat.cc (unknown [IPv6:2a01:e0a:836:f670:e9e0:559a:2db6:6cd]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mat@mat.cc) by mail.j.mat.cc (Postfix) with ESMTPSA id AE618942D9D; Sat, 7 Oct 2023 11:51:27 +0000 (UTC) Date: Sat, 7 Oct 2023 13:51:26 +0200 From: Mathieu Arnold To: Muhammad Moinur Rahman Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 28374e2250ce - main - lang/php83: Add non-default NOASLR option Message-ID: References: <202310071101.397B1Beq050941@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hgdxvcpcrvomg5fl" Content-Disposition: inline In-Reply-To: <202310071101.397B1Beq050941@gitrepo.freebsd.org> --hgdxvcpcrvomg5fl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 07, 2023 at 11:01:11AM +0000, Muhammad Moinur Rahman wrote: > The branch main has been updated by bofh: >=20 > URL: https://cgit.FreeBSD.org/ports/commit/?id=3D28374e2250ce52ea7f88bef2= e62c6e56181f573b >=20 > commit 28374e2250ce52ea7f88bef2e62c6e56181f573b > Author: Muhammad Moinur Rahman > AuthorDate: 2023-10-07 10:56:44 +0000 > Commit: Muhammad Moinur Rahman > CommitDate: 2023-10-07 11:00:34 +0000 >=20 > lang/php83: Add non-default NOASLR option So this should be an ASLR option that is on by default. > In certain corner cases php-fpm is creating zombie processes specially > from 13.2-RELEASE onwards. The exact reason has not been pin-pointed = but > it looks like disabling ASLR solves the problem. So add a non-default > option NOASLR to allow the user build without ASLR. > =20 > This patch will not go into lang/php80 but will go in lang/php81 and > lang/php82 after some more extensive tests. > =20 > PR: 274135 > Reported by: ports@thelanman.net > --- > lang/php83/Makefile | 26 +++++++++++++++++++++----- > 1 file changed, 21 insertions(+), 5 deletions(-) >=20 > diff --git a/lang/php83/Makefile b/lang/php83/Makefile > index 90ca4ef3b915..bf150d592329 100644 > --- a/lang/php83/Makefile > +++ b/lang/php83/Makefile > @@ -31,17 +31,15 @@ CONFIGURE_ARGS+=3D --disable-all \ > --with-password-argon2=3D${LOCALBASE} > DESTDIRNAME=3D INSTALL_ROOT > =20 > -USES+=3D autoreconf:build ssl > +USES+=3D autoreconf:build localbase ssl > USE_GNOME=3D libxml2 > =20 > -CPPFLAGS=3D -I${LOCALBASE}/include > - > -LDFLAGS=3D -L${OPENSSLLIB} -lcrypto -lssl > +LDFLAGS+=3D -L${OPENSSLLIB} -lcrypto -lssl > # PR230207 Allow relocations against read-only segments (override lld de= fault) > LDFLAGS_i386=3D -Wl,-z,notext > =20 > OPTIONS_DEFINE+=3D CGI CLI DEBUG DTRACE EMBED FPM IPV6 LINKTHR \ > - MYSQLND PHPDBG ZTS > + MYSQLND NOASLR PHPDBG ZTS > OPTIONS_DEFAULT=3D CGI CLI DTRACE EMBED FPM LINKTHR MYSQLND > OPTIONS_EXCLUDE_DragonFly=3D DTRACE > # ld(1) fails to link probes: Relocations in generic ELF (EM: 0) > @@ -83,6 +81,7 @@ FPM_VARS=3D PHP_SAPI+=3Dfpm \ > USE_RC_SUBR+=3Dphp-fpm > IPV6_CONFIGURE_OFF=3D --disable-ipv6 > LINKTHR_LIBS=3D -lpthread > +NOASLR_USES=3D elfctl > MYSQLND_CONFIGURE_ON=3D --enable-mysqlnd > PHPDBG_CONFIGURE_ON=3D --enable-phpdbg > PHPDBG_VARS=3D PHP_SAPI+=3Dphpdbg > @@ -98,6 +97,23 @@ SHORTMODNAME=3D php > WARNING=3D "!!! If you have a threaded Apache, you must build ${PHP_POR= T} with ZTS support to enable thread-safety in extensions !!!" > .endif > =20 > +.include > + > +.if ${PORT_OPTIONS:NOASLR} > +.if ${PORT_OPTIONS:MCLI} > +ELF_FEATURES+=3D+noaslr:sapi/cli/php > +.endif > +.if ${PORT_OPTIONS:MCGI} > +ELF_FEATURES+=3D+noaslr:sapi/cgi/php-cgi > +.endif > +.if ${PORT_OPTIONS:MPHPDBG} > +ELF_FEATURES+=3D+noaslr:sapi/phpdbg/phpdbg > +.endif > +.if ${PORT_OPTIONS:MFPM} > +ELF_FEATURES+=3D+noaslr:sapi/fpm/php-fpm > +.endif > +.endif > + > .include > =20 > .if ${ARCH} =3D=3D riscv64 >=20 --=20 Mathieu Arnold --hgdxvcpcrvomg5fl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmUhRj5fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb6UiAv/SOB26BmxPuJN0emIVqm0EMU6Dr1gPo398/7uqXKPj6uW3Z9qMyNhfvt2 z1WFv6vRJL8zZT+3Kgq95KVaQbeCSYmeAbKW845eVHY82gtSGhoQaZAL5wpvn2JQ 9fIYrkwHmVbWUxTaawbQb5zxA1rAXOpBgepztzD9wKLXY7pNRIJP+Tyqbr2vkQvH H6YJVJpMQEFMHI+dX73jiE6W2MHLnXkiJwQeXC9Ee0b89sFB9BwChawI6suGlQ2G ResGDW+R8L/E2lXiA8pj89mbdd6+ZFbNwmQ2YPRmzTgrRhBDPe/bOdLiEjE2LzJ0 IyYmrO7UFm0BtpYwZUUFZuumquyIkXIvd8nXUVDCSGC8s8JVjKgvVM1TpVNVVaZv lCrU1fSREwghCNlJgDZjHTinKA7wmpcuXT8q3RNGlWVAGGMKu8gGmgsyVnrTmFKg BCH2TdAKT66oy49Tn5X+68zmv8dpYSXc0T2r3ARQ4nW+b2J/FXdwTuAvJ6UU+ZFF tWi9JRWT =LCpG -----END PGP SIGNATURE----- --hgdxvcpcrvomg5fl--