From nobody Fri Oct 06 17:50:58 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S2GDz3Zdsz4w0bZ; Fri, 6 Oct 2023 17:50:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S2GDz0jZWz4ctR; Fri, 6 Oct 2023 17:50:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696614659; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LTi9m8rYI02uvBURRWnmADq8AAmP2po/KCBB1PrriA0=; b=LB9YMgAF45Tx5HD6wq0EOytjZjZ1BOw1nUO+XM4sTeFPIZi4wIKGAjxCyiL1whvSpCQu3z u3whvq9uB4N19eKLCT+NjsFmLehjPquhLb0CiF3L2IICUwjTqM8ouIFYO5Cn77mIN59h7R SM2g19loI22Njct0I6kS//fA5Qgd3obbou9NB1ziEwp0lYKXzGnZn/9L692NMeGAQGweSS bt3uvhmbmvLd22Xh8poz6QXA2ZNf3m0U6vPYZyoopismIMAPuTPtWDhrn0gQCFSmKAkcpH EyDw1/P3CTHyJ9GXGOqRBmkjWiTiZDk9eXjnmPKUT6Ekygc0d5EAGWXMW9O0ow== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1696614659; a=rsa-sha256; cv=none; b=v3KFsGvABrgjzoWIMkYVyN3+AlasmvOUSq9JhMwVsJr8jerg7OWQfFsaT6G3GW0pz9MbDY /HJlZcegwUMUsbm+fEYJKmLH3lqQZFe1vUAPTCBPNfjZAYMsukoKoVzt0fa7MdlHVzroPy zQ0JhhRGYmRjIeOybScd3/FSJ4E/DM346v4pFKttOm8On2YdpgG3y3vzidkXhkOPTsT9dF 2SMFpOnWzmWEjXJQtB3Gc5KOAvpO3EbrHvYTGJZJzILiujP9A2GNqdqAzbqlNaquRDgXeW jgM1dye9pQng+md/NhC+szlReNZ8TIDoqUG9UaHAzg1fNQdLpniKvPd2iJvv4w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696614659; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LTi9m8rYI02uvBURRWnmADq8AAmP2po/KCBB1PrriA0=; b=hKHhbCiC1kUZtwK/dtwWkNr5j3vp6WqQyV5QK1Ku8+/vyq8A7Go+Bj2yL4gs1QcLj77FeI vQEvNK8YTermXB40z2WNlBLOjceHJmUwZxJhp9SCkYR+TAtaXYod1STgzRu+YZKKiAx/K6 KzzCCmqya/+Zd+h+mWSwHTF184IAmDivHdp4egxrGK6LWLtVn4I8za2MrD+ehqJQiLP7Jg +qJ7z8lVxrEnTu+WebEx2iX6aPjl85OFcZ7kT0qUtXGZG50AvnQkfaa6CISksKaJjFdZV7 Tpoc10/Oq3REr/bQ2DAnGCvDRb7rM/s97OmTvcEspFODJgNlzs1ZCq6rppjhmA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S2GDy6RHMzxlD; Fri, 6 Oct 2023 17:50:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 396How0G039334; Fri, 6 Oct 2023 17:50:58 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 396HowH7039331; Fri, 6 Oct 2023 17:50:58 GMT (envelope-from git) Date: Fri, 6 Oct 2023 17:50:58 GMT Message-Id: <202310061750.396HowH7039331@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org From: Dimitry Andric Subject: git: 623262a13efb - main - devel/libnotify: fix build with lld 17 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: ports X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 623262a13efb4c659fda87783fb5e6164c24a774 Auto-Submitted: auto-generated The branch main has been updated by dim: URL: https://cgit.FreeBSD.org/ports/commit/?id=623262a13efb4c659fda87783fb5e6164c24a774 commit 623262a13efb4c659fda87783fb5e6164c24a774 Author: Dimitry Andric AuthorDate: 2023-09-26 14:19:09 +0000 Commit: Dimitry Andric CommitDate: 2023-10-06 17:48:54 +0000 devel/libnotify: fix build with lld 17 Building devel/libnotify with lld 17 results in the following link error: cc -o libnotify/libnotify.so.4.0.0 libnotify/libnotify.so.4.0.0.p/meson-generated_.._notify-enum-types.c.o libnotify/libnotify.so.4.0.0.p/meson-generated_.._notify-marshal.c.o libnotify/libnotify.so.4.0.0.p/notify.c.o libnotify/libnotify.so.4.0.0.p/notification.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,-O1 -shared -fPIC -Wl,--start-group -Wl,-soname,libnotify.so.4 -fstack-protector-strong -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -Wl,-rpath,/usr/local/lib -Wl,-rpath-link,/usr/local/lib -Wl,--version-script,/wrkdirs/share/dim/ports/devel/libnotify/work/libnotify-0.8.2/libnotify/libnotify.map /usr/local/lib/libgdk_pixbuf-2.0.so /usr/local/lib/libgobject-2.0.so /usr/local/lib/libglib-2.0.so /usr/local/lib/libintl.so /usr/local/lib/libgio-2.0.so -Wl,--end-group ld: error: version script assignment of 'global' to symbol '__progname' failed: symbol not defined ld: error: version script assignment of 'global' to symbol 'environ' failed: symbol not defined cc: error: linker command failed with exit code 1 (use -v to see invocation) This is because lld 17 defaults to errors when undefined symbols are referenced in linker version scripts. Apparently the __progname and environ symbols (which usually come from libc, not libnotify.so) were explicitly added in: commit 0b0b10cff8d7b5ed08d11c6fa4d66e1977d6eb79 Author: Baptiste Daroussin Date: 2019-12-16T19:40:37+01:00 Fix build with old binutils. Somehow linker scripts should not hide __progname and environ from symbols. Reported by: kib but it is unclear what the original error was, or how old "old" is, and there is no reference to a PR. In any case, I think the patch-libnotify_libnotify.map file can simply be deleted now. PR: 274108 Approved by: maintainer timeout (10 days) MFH: 2023Q4 --- devel/libnotify/files/patch-libnotify_libnotify.map | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/devel/libnotify/files/patch-libnotify_libnotify.map b/devel/libnotify/files/patch-libnotify_libnotify.map deleted file mode 100644 index bdc318de8dec..000000000000 --- a/devel/libnotify/files/patch-libnotify_libnotify.map +++ /dev/null @@ -1,11 +0,0 @@ ---- libnotify/libnotify.map.orig 2019-04-05 19:06:19 UTC -+++ libnotify/libnotify.map -@@ -1,6 +1,8 @@ - { - global: - notify_*; -+ __progname; -+ environ; - local: - *; - };