From nobody Fri Oct 06 17:50:50 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S2GDq1g8Gz4w0hL; Fri, 6 Oct 2023 17:50:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S2GDq17zcz4cFC; Fri, 6 Oct 2023 17:50:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696614651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nOFlq25wNVaCcj6TuAfzwetMx2nO4LWBkeTOMztBv0w=; b=Ip+zM9yaaIdQDoaLXsjA0dYKNVvBJKWM+/cQz/x4EMHozH/AeP0wszO7vY9NXuL321A4ty 2T9pioYnm9cV5h3A51gXadJ/nCt0GYM2cJrdpDJ7ESigwnfUTQcIw2ifR0HGQITIB9m5Ss e+vd+vrHL7Q+w0SqcolQzjUme0d5Dx9ihjRTRFoC6oTwpTaph34aeR1EmZfKu1BPi38TeJ b8GiUe4HCcmWopfldaCftg4lDPonc/rpoEWC9/Ltddfcu6zR2zwYK4KpIQyKL10dJvTEQz j+PlJEMjzkuo1XYlnPuRctDVWhJKBhIOpDy+QNJvsqx5oaxg8EhpzLQ4EV9Q5A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1696614651; a=rsa-sha256; cv=none; b=ficgoR+UZMj+/9mpbZxolAbfAC21Q6Xxmbo9caMMLYcBU5dE9V4mQn8r58qlBseYGTz7cF 2CZonjZvLaNPpdJnUsNsGGFjTepRgkSw6driCbuaiDg6jwkJHwTYNYKadlcrEqadtmWOvu 1xOIYLbyeB8fhZiiRj1rSBzSnTt3L7Oq2pz6GiACmkRPxx3iNjpp0X11aTf9aHTa4A3VXR lf7Wm/ISenoOtDbf8feHcJpueepSl3587Td4vBwDzgpXrQQGiDjljVYVTKA0TvjhZ5ytFf 9cMorlhPd1Ml4KU4DsYRIBPn9AMPOsrUuYO8AxdyXC51nDHGsFmOMb0dyyNmng== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696614651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nOFlq25wNVaCcj6TuAfzwetMx2nO4LWBkeTOMztBv0w=; b=R528cgoSx8VWoWutvXpddENbbO/LjWl6jEpQfS5gE14gyTujjj6F0qkKgIWW6Nm1psfYli soGKzOZIWiKvvBArIhdade4xS3PdZUg6KCXbwFCs/7mqTbtH/UdlrXn2PBeLxBnPKIs+RZ IQ5oev0ziC25YqY3s5Z81cf+rh7Uxdw91bfT+H3RKjZ99MY7eiPfIQ+Y6NuPBmhUAP7NEP eRmv8o+x+KAhxeHzfds3gjZTFJrhCYG3mwPmtCXV8HektCgA9BdV3VPdYHTPqFn324ypW9 tL2Q2vjwD6upWGrB4fc2OXGUWrQjzQww39N5wzypsDZwU5uLUI5hLyjEiESzvw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S2GDq0DFVzxNT; Fri, 6 Oct 2023 17:50:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 396Hoos6038983; Fri, 6 Oct 2023 17:50:50 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 396Hoo4g038980; Fri, 6 Oct 2023 17:50:50 GMT (envelope-from git) Date: Fri, 6 Oct 2023 17:50:50 GMT Message-Id: <202310061750.396Hoo4g038980@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org From: Dimitry Andric Subject: git: 3e5360df3584 - main - qt-dist.mk: suppress linker version script errors with lld >= 17 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: ports X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3e5360df35848a1ad8c5edae83a0a9cdfd6bb775 Auto-Submitted: auto-generated The branch main has been updated by dim: URL: https://cgit.FreeBSD.org/ports/commit/?id=3e5360df35848a1ad8c5edae83a0a9cdfd6bb775 commit 3e5360df35848a1ad8c5edae83a0a9cdfd6bb775 Author: Dimitry Andric AuthorDate: 2023-09-21 08:40:09 +0000 Commit: Dimitry Andric CommitDate: 2023-10-06 17:48:52 +0000 qt-dist.mk: suppress linker version script errors with lld >= 17 Qt uses generated linker version scripts which always have a qt_version_tag symbol, but that symbol is only defined in the main Qt shared library. For other Qt components, this leads to lld >= 17 erroring out due to the symbol being undefined. Suppress these errors from qt-dist.mk, so we don't have to patch each individual port. This affects at least: * devel/qt5-dbus * net/qt5-network * databases/qt5-sql which were the first ones to fall over with a clang+lld 17 poudriere bulk run. For reference, the error you would see looks like: ... c++ -Wl,--as-needed -fstack-protector-strong -Wl,--no-undefined -Wl,--version-script,QtDBus.version -pthread -Wl,-rpath,/usr/local/lib/qt5 -shared -Wl,-Bsymbolic-functions -Wl,-soname,libQt5DBus.so.5 -o libQt5DBus.so.5.15.8 .obj/qdbusconnection.o .obj/qdbusconnectioninterface.o .obj/qdbuserror.o .obj/qdbusintegrator.o .obj/qdbusmessage.o .obj/qdbusserver.o .obj/qdbusabstractinterface.o .obj/qdbusinterface.o .obj/qdbusxmlparser.o .obj/qdbusutil.o .obj/qdbusintrospection.o .obj/qdbusabstractadaptor.o .obj/qdbusinternalfilters.o .obj/qdbusmetaobject.o .obj/qdbusxmlgenerator.o .obj/qdbusmisc.o .obj/qdbusargument.o .obj/qdbusreply.o .obj/qdbusmetatype.o .obj/qdbusextratypes.o .obj/qdbuscontext.o .obj/qdbuspendingcall.o .obj/qdbuspendingreply.o .obj/qdbus_symbols.o .obj/qdbusservicewatcher.o .obj/qdbusunixfiledescriptor.o .obj/qdbusvirtualobject.o .obj/moc_qdbusconnectioninterface.o .obj/moc_qdbuserror.o .obj/moc_qdbusconnection.o .obj/moc_qdbusabstracta daptor.o .obj/moc_qdbusvirtualobject.o .obj/moc_qdbusconnection_p.o .obj/moc_qdbusconnectionmanager_p.o .obj/moc_qdbuspendingcall_p.o -L/wrkdirs/usr/ports/devel/qt5-dbus/work/kde-qtbase-5.15.8p157/lib /usr/local/lib/qt5/libQt5Core.so -L/usr/local/lib -ldbus-1 ld: error: version script assignment of 'Qt_5.15' to symbol 'qt_version_tag' failed: symbol not defined c++: error: linker command failed with exit code 1 (use -v to see invocation) PR: 273992 Approved by: maintainer timeout (2 weeks) MFH: 2023Q4 --- Mk/Uses/qt-dist.mk | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Mk/Uses/qt-dist.mk b/Mk/Uses/qt-dist.mk index 40ae305bdbb1..868eed099a6b 100644 --- a/Mk/Uses/qt-dist.mk +++ b/Mk/Uses/qt-dist.mk @@ -181,6 +181,12 @@ EXTRACT_AFTER_ARGS?= ${DISTNAME:S,$,/examples,:S,^,--exclude ,} \ --no-same-owner --no-same-permissions . endif # ! ${_QT_VER:M5} +# Qt uses generated linker version scripts which always have a qt_version_tag +# symbol, but that symbol is only defined in the main Qt shared library. For +# other Qt components, this leads to lld >= 17 erroring out due to the symbol +# being undefined. Supress these errors. +LDFLAGS+= -Wl,--undefined-version + # Build setup for Qt6 . if ${_QT_VER:M6} CMAKE_ARGS+= -DCMAKE_INSTALL_PREFIX=${PREFIX} \