From nobody Tue Nov 14 18:02:33 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SVDfS3VR8z50S2B; Tue, 14 Nov 2023 18:02:40 +0000 (UTC) (envelope-from jrm@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SVDfS2q33z3fPw; Tue, 14 Nov 2023 18:02:40 +0000 (UTC) (envelope-from jrm@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699984960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=va3l6K9R24aS+N1wY+1kbbNZm67sgoe5lkJ+7EzetIw=; b=SBrqLRDSudL+k5Zlo2hxDjjLzggrye9nhT+uMTTkeVPeoAALctop7qi6xqUUJYa8BJ4Kml A2A0o1isjfDBGVPus80l8TxuZUZfuheGQi2xW4H2VpsEM9ekHSCwatgfltnfHKDLQUqCuk HoCi+YzTVqkZJssHPGmSC1BxCrzVT5RXSHC+sW0GNcHewXrU5+tCEbvKq09wdbtUbYDTqD Z3+aBdeTsAyELbKPWx7iSHcMPpfYTutxm9ppTt8mfNyfzC9yuOj6KC4JG2I8cIF0ajc7Gq xMQ2oDrnBMHef7xydAWOPZYONh7cV7yvBBCEp/6cRrIASP8Vl+M9ITBaK22v8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699984960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=va3l6K9R24aS+N1wY+1kbbNZm67sgoe5lkJ+7EzetIw=; b=AFlqg4fnwVk+seKU+hjl3D7MpaLYP/DVtnJ8vZ5eYNfWbqfrwdqduR3jp9EzK/rZ6QmJIA 8xwR27SXr9hYGSXU8BeLzeIEXZyx7FoXDR5/67jaWj2Bt38iKcSH0/ZPdldOR8IAc08OE/ DJgWF+wKDxLdt4cuOjE6hnqkvMjGHR0LPVK2uVk90L1yjkRJzV6o3Fjlm5aUgLEbq2JqEY 7PJoZYbT4mGwXUvJcfXaRUdxgQ9nhsl4odntgkZu/4ocxEpXerTHVF5sJGh7xvwb/difGK uPY3qIBC3vsncQhbmYyFles2d1ScuKL2ZuHSX5cEHXqq8GwZc6boSxmuAYg8Nw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1699984960; a=rsa-sha256; cv=none; b=LWMBYdB4iRdHYMwdPNMK5pKkd1ncP+l0wwc8+DwcT1qcFME3GS/D28hF/fuStVv4KX0u8C Mq/MUSZF02EbraQoNetxhH18Ws595wOnUnd7lAZPJYOPeY2KhZSndu8V3GetqEMuZxh4G6 /BarLzk0Q/DExZjVD85Sw4hyCTIMzfxFkgrRFgtljEKIjve8ApeQNgWqM+DyiKv4VcYI0Q T8tnqmIpFC3txCg1xFBUPNwvGSs/ffGkxl21VOBEJCfVhbMlVx/MvsCR/o5flFHbEKwXQA jd67f2rQC5J3bsVzIN2TMvGwK7vivvBCNzsW8Un+wG0v0bdrQrqp3zeHa51UxA== Received: from phe.ftfl.ca.ftfl.ca (drmons0544w-156-34-175-127.dhcp-dynamic.fibreop.ns.bellaliant.net [156.34.175.127]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: jrm/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4SVDfS0NCFz15wJ; Tue, 14 Nov 2023 18:02:39 +0000 (UTC) (envelope-from jrm@freebsd.org) From: Joseph Mingrone To: Marius Strobl Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: d12bc36e7698 - main - cpu-microcode-intel: Add knobs for RC RUN_DEPENDS and split files In-Reply-To: (Marius Strobl's message of "Tue, 14 Nov 2023 18:11:06 +0100") References: <202311092025.3A9KPJhe049861@gitrepo.freebsd.org> <867cmld31m.fsf@phe.ftfl.ca> Date: Tue, 14 Nov 2023 14:02:33 -0400 Message-ID: <865y24mcw6.fsf@phe.ftfl.ca> User-Agent: Gnus/5.13 (Gnus v5.13) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain On Tue, 2023-11-14 at 18:11, Marius Strobl wrote: > On Mon, Nov 13, 2023 at 12:35:33PM -0400, Joseph Mingrone wrote: >> On Thu, 2023-11-09 at 20:25, Marius Strobl wrote: >> > The branch main has been updated by marius: >> > URL: https://cgit.FreeBSD.org/ports/commit/?id=d12bc36e7698f3737de1ac228bd49eab10cf1bb0 >> > commit d12bc36e7698f3737de1ac228bd49eab10cf1bb0 >> > Author: Marius Strobl >> > AuthorDate: 2023-11-09 20:20:53 +0000 >> > Commit: Marius Strobl >> > CommitDate: 2023-11-09 20:20:53 +0000 >> > cpu-microcode-intel: Add knobs for RC RUN_DEPENDS and split files >> > Split UCODE files as well as dependency on sysutils/cpu-microcode-rc >> > are only required for use with cpucontrol(8) and update method two >> > respectively. The first method needs neither so we can spare a few >> > MiB and a superfluous port. >> > Given that the automatic update method one is superior, the RC knob >> > should be deprecated and removed eventually. At that point, split >> > UCODE files still will be useful for developers and if users want >> > to update the microcode without a reboot (but otherwise rely on the >> > loader for automatic updates, i. e. method one). >> For the reasons you described, I proposed removing the RC script for the >> Intel CPU microcode updates [1]. However, there was a reasonable >> argument for keeping it. As you say, users may still want to update >> their Intel CPU microcode this way because updates can be applied on a >> running system without requiring downtime for a reboot. >> With your commit, I think we have a good compromise. Users who really >> want to save a bit of space and have one fewer port installed can turn >> off these two knobs. Maybe we could make that the default. >> Joe >> [1] See the comments in https://reviews.freebsd.org/D32349 for details. > Hi Joe, > it's probably a matter of taste but when it does come to something > like updating UCODE on a running - likely critical as otherwise I'd > simply reboot with the new firmware in place - system, I typically > feel uneasy and want to know exactly what's going to be done. For > me, this translates to - as mentioned earlier - using cpucontrol(8) > directly, i. e. issuing: > # echo /dev/cpuctl* | xargs -n 1 cpucontrol -u > instead of a 77 lines of code for microcode_update on top of 175 > lines of script for service(8). IMO that's also not particularly > more cryptic of harder to remember than: > # service microcode_update onestart > In any case, as previously stated there's no need to employ the > RC script for manual updates either and least as far as I'm > concerned, running cpucontrol(8) directly instead is preferable. > Thus, I propose to at least switch the default. But I leave that > decision up to you. > Marius Hi Marius, Those are valid points. Let's leave this thread open for about a month and if no one objects to turning those knobs off by default, I'll make the change. Thanks, Joe --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKkBAEBCgCOFiEEVbCTpybDiFVxIrrVNqQMg7DW754FAmVTtjlfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU1 QjA5M0E3MjZDMzg4NTU3MTIyQkFENTM2QTQwQzgzQjBENkVGOUUQHGpybUBmcmVl YnNkLm9yZwAKCRA2pAyDsNbvnokFD/4uLW4u22q2AEnjGb0nUuu6fLm7Hl3ydQHN 8AoaMs3xUsbqoY2cnalvBgWt7OltZkvkUOe+HVxXa2/xv0wwZInJDTwfVyDaXL8O f95OGhmYyjdFD8+13mJMSRjzpLOO32Lgkp78teQB2SpM5VwiGklJrpqpZA6kLmz/ 5OP9FStZ2EFnI9f2p8G5NWOSxM8OII0Fux19/UEb71d8ygEPj1Ear60Srzz35I+Z Y8NIBHyK19athuPXS3ZWoGwG5mF8fqPa/24BncobfVfMdjrEIpUjLa/wLcVvrGJL IGC+yVOfiRYwgHJVt7oo+R4A2A1qah/QfL+ASno3U7HoR/VVqDOE5k6VCpj09cGA AY+kODAbc2LKe++4tbakrX2jERTW9fwuMCcWoxrL1cVlDF8rTDN2sxg2JthoEo8t 4Dow68Kc1n5mcnW2c8dy23eJIxeRg9+9sOe8MV8+WNC4B02GWvUPg9SISQbsekFr vJcYl7WV/3oI91EE4nzoyNAtaa8wLCODNWQSgblUWiC0qBs8fCPi6YxVT58rjHzk VMwuCYm1CG2cemYRpeqO/nq8EgJKz3VgpvBdv7yjIbaPhetvdRSGrqhYWQu6qo4j B5DxxIBglPDjb7J1F8nButaLCaGI4SH0+QEK1IFwVIMBIWqtrqYhXbgeZpFFcjoO fMOv9wpgAw== =svo8 -----END PGP SIGNATURE----- --=-=-=--