From nobody Fri Mar 31 14:30:52 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Pp2lX6y38z42q0H for ; Fri, 31 Mar 2023 14:31:04 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from mail-qv1-xf29.google.com (mail-qv1-xf29.google.com [IPv6:2607:f8b0:4864:20::f29]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Pp2lX57ycz46CN for ; Fri, 31 Mar 2023 14:31:04 +0000 (UTC) (envelope-from adamw@adamw.org) Authentication-Results: mx1.freebsd.org; none Received: by mail-qv1-xf29.google.com with SMTP id o44so16463123qvo.4 for ; Fri, 31 Mar 2023 07:31:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamw-org.20210112.gappssmtp.com; s=20210112; t=1680273064; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:from:to:cc:subject:date:message-id :reply-to; bh=RClobpQ/UWp7DaopAbS4lL+9jHlBJ9Bym9PCUFV6qgw=; b=zQx5e2yIrNajlZDXDJutpkjOzW70tp8BQyYhsrhekRl1mgkzTocnb3303EUAwv+ipJ n07vVCmcY8C/MxrEcMAaMHRHh94z68ca0AFtcwL22UnoueWMpyQbtZxF8piPA68yY8K+ Mvv9I8KiL33kRLQ4yfFxAAnueZCrTut8AaFUX03jYeoV52/5+3Hp5oVVRrQ+HYyHEr7a MnQkui+KTiJepjarOA+ffAQJ4gMBjFpjqbA2WzZXgQeU0qgfNCkf6QFfR3tZa31wWv4e Zy3LWF8nH43lvOFsEntPmWTloQ4moZEbjdDkr3Y2mRFhGjA8PW8oTkeC1KxhBEUq++4I YUog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680273064; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RClobpQ/UWp7DaopAbS4lL+9jHlBJ9Bym9PCUFV6qgw=; b=hqOD9XQSr6mgFrN2g8TdxNuuLqbyS8BhHg91mzHu12P8TFX6J26pyX2lRe/AZxbZMf U3Vy8wdSL90/TlEpbDjORC69fi2UHdDuiLMcPu6Zkz4l8i8+9W0g2FJZ8APsagemB6Is 1UlyB64aDhjVm9GYpD6TPJ87roukx1ZWaNLJR3oD2ciiLyaI/olIOBDNj80mRI4m9evu p62GAp4cRDRM4wixuMb013eD7bkM2L7wC7L5yM7caFrEg2U3FV75oAkCJ4rq9gxbxPjk Bjnz0wo2oBE/3jTNPsH97m983aSHIe/c2Jl0Q30/fuWJk/XXXoLXhQNnyqYTEJ+RyhpF vAlA== X-Gm-Message-State: AAQBX9eBBYwxubASLKfPl8HrXBk83t48xSxSCJWqqPhfPTihAmVCoQsV f3rI5srhmtiyVUJkG4wptO1GJA== X-Google-Smtp-Source: AKy350YlvfUN7dhCItghRSs9u0Fo0CcUcer1oWCSoDp8UdUxa9jbUQ0Ns753JveKgR7qQr6/ImR02w== X-Received: by 2002:a05:6214:2628:b0:5df:4d3e:b8da with SMTP id gv8-20020a056214262800b005df4d3eb8damr17545581qvb.10.1680273063809; Fri, 31 Mar 2023 07:31:03 -0700 (PDT) Received: from smtpclient.apple (071-010-147-170.res.spectrum.com. [71.10.147.170]) by smtp.gmail.com with ESMTPSA id nd13-20020a056214420d00b005dd8b9345absm624266qvb.67.2023.03.31.07.31.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Mar 2023 07:31:03 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Adam Weinberger List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org Mime-Version: 1.0 (1.0) Subject: Re: git: de841b40d24d - main - sysutils/xxd: New port Date: Fri, 31 Mar 2023 10:30:52 -0400 Message-Id: <440103A8-A773-4B4E-BEB1-28C49D1B9CB5@adamw.org> References: <03eb85e1-14fa-24f4-dcb3-84caeef82a24@FreeBSD.org> Cc: gmarco@giovannelli.it, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org In-Reply-To: <03eb85e1-14fa-24f4-dcb3-84caeef82a24@FreeBSD.org> To: Guido Falsi X-Mailer: iPhone Mail (20D67) X-Rspamd-Queue-Id: 4Pp2lX57ycz46CN X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N > On Mar 31, 2023, at 10:28, Guido Falsi wrote: >=20 > =EF=BB=BFOn 31/03/23 15:49, Adam Weinberger wrote: >> On Thu, Mar 30, 2023 at 4:45=E2=80=AFPM Guido Falsi > wrote: >> The branch main has been updated by madpilot: >> URL: >> https://cgit.FreeBSD.org/ports/commit/?id=3Dde841b40d24d22ab51ad05ed63= 2e025903fbb41f >> commit de841b40d24d22ab51ad05ed632e025903fbb41f >> Author: Guido Falsi >> AuthorDate: 2023-03-30 20:42:54 +0000 >> Commit: Guido Falsi >> CommitDate: 2023-03-30 20:42:54 +0000 >> sysutils/xxd: New port >> This is the standalone version of the xxd tool provided by vim. >> Submitted by: Gianmarco Giovannelli > > >> diff --git a/sysutils/xxd/Makefile b/sysutils/xxd/Makefile >> new file mode 100644 >> index 000000000000..378f364cf4bf >> --- /dev/null >> +++ b/sysutils/xxd/Makefile >> @@ -0,0 +1,26 @@ >> +PORTNAME=3D xxd >> +DISTVERSIONPREFIX=3D v >> +DISTVERSION=3D 9.0.1366 >> +CATEGORIES=3D sysutils >> + >> +MAINTAINER=3D gmarco@giovannelli.it >> +COMMENT=3D Hexdump and reverse hexdump utility >> +WWW=3D https://github.com/mew-cx/xxd >> + >> +CONFLICTS_INSTALL=3D vim-[0-9]* vim-gtk2 vim-gtk3 vim-motif vim-x= 11 >> + >> +ALL_TARGET=3D ${PORTNAME} >> +PORTSCOUT=3D ignore:1 >> +EXTRACT_AFTER_ARGS=3D --include=3D'*/src/xxd*' >> +WRKSRC_SUBDIR=3D src/xxd >> + >> +PLIST_FILES=3D bin/xxd >> + >> +USE_GITHUB=3D yes >> +GH_ACCOUNT=3D vim >> +GH_PROJECT=3D vim >> + >> +do-install: >> + ${INSTALL_PROGRAM} ${WRKSRC}/xxd ${STAGEDIR}${PREFIX}/bin >> + >> +.include > >> The WWW is odd here. The source files are coming from github.com/vim/vim <= http://github.com/vim/vim>, but the WWW is for a related but unused project.= >=20 > Oops, you're right. Submitter proposed to use a fork, but later I decided g= rabbing the original vim distribution was better, I must have forgotten upda= ting the WWW line. >=20 > Will fix it! >=20 >> I update vim at the beginning of every month plus whenever new minors are= released, and whenever there are patches that it's important for us to down= stream. Rather than pinning xxd to a version that will be old literally tomo= rrow, why not pull the DISTVERSION and distinfo from editors/vim/Makefile? >=20 > That would be a good idea, but while using vim distinfo is trivial, I'm no= t sure how to import DISTVERSION from another port. Including the Makefile w= ould override a bunch of other variables. ${MAKE_CMD} -V DISTVERSION :-) =E2=80=94 Adam Weinberger adamw@adamw.org https://www.adamw.org >=20 > --=20 > Guido Falsi >=20