From nobody Sun Mar 26 14:45:10 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PkzJP1Gxbz41vSX; Sun, 26 Mar 2023 14:45:25 +0000 (UTC) (envelope-from luca.pizzamiglio@gmail.com) Received: from mail-vs1-f51.google.com (mail-vs1-f51.google.com [209.85.217.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PkzJN2r6Kz3Fm9; Sun, 26 Mar 2023 14:45:24 +0000 (UTC) (envelope-from luca.pizzamiglio@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of luca.pizzamiglio@gmail.com designates 209.85.217.51 as permitted sender) smtp.mailfrom=luca.pizzamiglio@gmail.com; dmarc=none Received: by mail-vs1-f51.google.com with SMTP id h15so5418289vsh.0; Sun, 26 Mar 2023 07:45:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679841923; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YblHllCubpFXFGUJfMao2TPQhOSjOh9ZbaqZ2jhXQ/0=; b=B58TjIqtuNSq+oiaU82qNqVB3i424ITY2ZT95FVEo3+N1zkWItoF0AXJZMgj1lwAmv vDGYfiIqjEewtW4q61ydmC4+8s/o/o5wi6GC47+ATSGoiuXJ9eMfc6/8dLcTafZiezyS Z8BmQwBzZ/2W0HqRhWKVESIQTnrZfOghjbSkx7PeZJsD4OhN7JbWsYFipluN/65SDAHy EdKRozYSYYCjdjUhBnAEeFgzfWtH4B1EsfV5xAF6lXvED8Hl1c6GKBQXsAsNeLHjq9JM ob7XIXlD/lLZiOxf8/v6sM4prwZyloFtS+7oo58O6ACAb9zXuSNV1nOTF1cwMIv8fUwl 47Mw== X-Gm-Message-State: AAQBX9cXmG5SE7srmlvweDPahk4VZr/HFp2nYLRMJeMYu06WtX3zzzSd Yarm3yO+izUuKOmsjl1jO7sAXDhngmwIyg== X-Google-Smtp-Source: AKy350bE8+rAyjFrtHedyrkasqbZ3kS5fn2lXGaDOu7ByjRI0qU+iEVmFVvULcFb5SFl3do6ztRasg== X-Received: by 2002:a67:f6d7:0:b0:426:6737:38ff with SMTP id v23-20020a67f6d7000000b00426673738ffmr3798432vso.6.1679841923168; Sun, 26 Mar 2023 07:45:23 -0700 (PDT) Received: from mail-vs1-f47.google.com (mail-vs1-f47.google.com. [209.85.217.47]) by smtp.gmail.com with ESMTPSA id j5-20020a0561023e0500b0042613e12409sm2246896vsv.34.2023.03.26.07.45.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Mar 2023 07:45:23 -0700 (PDT) Received: by mail-vs1-f47.google.com with SMTP id cu36so5358967vsb.7; Sun, 26 Mar 2023 07:45:22 -0700 (PDT) X-Received: by 2002:a67:d215:0:b0:412:5424:e58e with SMTP id y21-20020a67d215000000b004125424e58emr5241833vsi.0.1679841922704; Sun, 26 Mar 2023 07:45:22 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202303261149.32QBnc5d024941@gitrepo.freebsd.org> <906fc94ce07248d8aa56678fcc1b178b@FreeBSD.org> In-Reply-To: From: Luca Pizzamiglio Date: Sun, 26 Mar 2023 16:45:10 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 1453ec9ec99d - main - benchmarks/unixbench: Fix arm64 build To: Daniel Engberg Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="00000000000014eea205f7ceadfb" X-Spamd-Result: default: False [-2.87 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-0.996]; NEURAL_HAM_SHORT(-0.88)[-0.878]; FORGED_SENDER(0.30)[pizzamig@freebsd.org,lucapizzamiglio@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; RCVD_IN_DNSWL_NONE(0.00)[209.85.217.51:from,209.85.217.47:received]; MLMMJ_DEST(0.00)[dev-commits-ports-all@freebsd.org,dev-commits-ports-main@freebsd.org]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.217.51:from]; FREEMAIL_ENVFROM(0.00)[gmail.com]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; RCVD_TLS_LAST(0.00)[]; ARC_NA(0.00)[]; TAGGED_FROM(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FROM_HAS_DN(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DMARC_NA(0.00)[freebsd.org]; MIME_TRACE(0.00)[0:+,1:+,2:~]; TO_DN_SOME(0.00)[]; FROM_NEQ_ENVFROM(0.00)[pizzamig@freebsd.org,lucapizzamiglio@gmail.com] X-Rspamd-Queue-Id: 4PkzJN2r6Kz3Fm9 X-Spamd-Bar: -- X-ThisMailContainsUnwantedMimeParts: N --00000000000014eea205f7ceadfb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Changed my mind. going to remove mtune as default. Only leaving the option to enable march (disabled by default). Best regards, Luca On Sun, Mar 26, 2023 at 4:43=E2=80=AFPM Luca Pizzamiglio wrote: > Thanks for the suggestions! > I'm leaving mtune as default, and adding an option to enable march. > > mtune is expected to not create broken packages. > Am I correct? > > Best regards, > Luca > > > On Sun, Mar 26, 2023 at 1:58=E2=80=AFPM Daniel Engberg wrote: > >> On 2023-03-26 13:49, Luca Pizzamiglio wrote: >> > The branch main has been updated by pizzamig: >> > >> > URL: >> > >> https://cgit.FreeBSD.org/ports/commit/?id=3D1453ec9ec99d5025678acb403c9f= 84c7beb6dbd5 >> > >> > commit 1453ec9ec99d5025678acb403c9f84c7beb6dbd5 >> > Author: Luca Pizzamiglio >> > AuthorDate: 2023-03-26 11:49:14 +0000 >> > Commit: Luca Pizzamiglio >> > CommitDate: 2023-03-26 11:49:14 +0000 >> > >> > benchmarks/unixbench: Fix arm64 build >> > >> > On arm64, some cflags are not supported. >> > --- >> > benchmarks/unixbench/files/patch-Makefile | 21 +++++++-------------- >> > 1 file changed, 7 insertions(+), 14 deletions(-) >> > >> > diff --git a/benchmarks/unixbench/files/patch-Makefile >> > b/benchmarks/unixbench/files/patch-Makefile >> > index 282945fef972..3c2539dc046d 100644 >> > --- a/benchmarks/unixbench/files/patch-Makefile >> > +++ b/benchmarks/unixbench/files/patch-Makefile >> > @@ -1,5 +1,5 @@ >> > --- Makefile.orig 2023-02-07 23:18:07.000000000 +0100 >> > -+++ Makefile 2023-02-09 21:57:42.966634000 +0100 >> > ++++ Makefile 2023-03-26 13:40:57.699042000 +0200 >> > @@ -46,7 +46,7 @@ >> > # X11 libraries on your system. (e.g. libX11-devel mesa-libGL-devel) >> > # >> > @@ -18,22 +18,15 @@ >> > >> > # OPTIMISATION SETTINGS: >> > # Use gcc option if defined UB_GCC_OPTIONS via "Environment >> > variable" or "Command-line arguments". >> > -@@ -87,7 +87,7 @@ >> > - ## (-ffast-math) disables strict IEEE or ISO rules/specifications >> > for math funcs >> > - OPTON =3D -O3 -ffast-math >> > - >> > -- ## OS detection. Comment out if gmake syntax not supported by >> > other 'make'. >> > -+ ## OS detection. Comment out if gmake syntax not supported by >> > other 'make'. >> > - OSNAME:=3D$(shell uname -s) >> > - ARCH :=3D $(shell uname -p) >> > - ifeq ($(OSNAME),Linux) >> > -@@ -113,6 +113,9 @@ >> > +@@ -113,6 +113,13 @@ >> > CFLAGS +=3D -Wa,-q >> > endif >> > >> > + ifeq ($(OSNAME),FreeBSD) >> > -+ OPTON +=3D -march=3Dnative -mtune=3Dnative -fomit-frame-pointer >> > ++ ifeq ($(ARCH),aarch64) >> > ++ OPTON +=3D -fomit-frame-pointer >> > ++ else >> > ++ OPTON +=3D -march=3Dnative -mtune=3Dnative -fomit-frame-pointe= r >> > ++ endif >> > + endif >> > endif >> > - >> > - >> >> Hi, >> >> Please remove -march=3Dnative as it will break on x86/amd64 for packagin= g. >> Either add it as a menu option or just rely on ports framework (CPUTYPE >> in make.conf). >> >> Best regards, >> Daniel >> > --00000000000014eea205f7ceadfb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Changed my mind. going to remove mtune as default.
Only leaving the option to enable march (disabled by default).<= /div>

Best regards,
Luca

On Sun, Mar = 26, 2023 at 4:43=E2=80=AFPM Luca Pizzamiglio <pizzamig@freebsd.org> wrote:
Thanks for the suggestio= ns!
I'm leaving mtune as default, and adding an option to enable mar= ch.

mtune is expected to not create broken packages.=
Am I correct?

Best regards,
Luca=


On Sun, Mar 26, 2023 at 1:58=E2=80=AFPM Daniel Eng= berg <diizzy@fre= ebsd.org> wrote:
On 2023-03-26 13:49, Luca Pizzamiglio wrote:
> The branch main has been updated by pizzamig:
>
> URL:
> https://cgi= t.FreeBSD.org/ports/commit/?id=3D1453ec9ec99d5025678acb403c9f84c7beb6dbd5
>
> commit 1453ec9ec99d5025678acb403c9f84c7beb6dbd5
> Author:=C2=A0 =C2=A0 =C2=A0Luca Pizzamiglio <pizzamig@FreeBSD.org&g= t;
> AuthorDate: 2023-03-26 11:49:14 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Luca Pizzamiglio <pizzamig@FreeBSD.org&g= t;
> CommitDate: 2023-03-26 11:49:14 +0000
>
>=C2=A0 =C2=A0 =C2=A0benchmarks/unixbench: Fix arm64 build
>
>=C2=A0 =C2=A0 =C2=A0On arm64, some cflags are not supported.
> ---
>=C2=A0 benchmarks/unixbench/files/patch-Makefile | 21 +++++++----------= ----
>=C2=A0 1 file changed, 7 insertions(+), 14 deletions(-)
>
> diff --git a/benchmarks/unixbench/files/patch-Makefile
> b/benchmarks/unixbench/files/patch-Makefile
> index 282945fef972..3c2539dc046d 100644
> --- a/benchmarks/unixbench/files/patch-Makefile
> +++ b/benchmarks/unixbench/files/patch-Makefile
> @@ -1,5 +1,5 @@
>=C2=A0 --- Makefile.orig=C2=A0 =C2=A0 2023-02-07 23:18:07.000000000 +01= 00
> -+++ Makefile 2023-02-09 21:57:42.966634000 +0100
> ++++ Makefile 2023-03-26 13:40:57.699042000 +0200
>=C2=A0 @@ -46,7 +46,7 @@
>=C2=A0 =C2=A0# X11 libraries on your system. (e.g. libX11-devel mesa-li= bGL-devel)
>=C2=A0 =C2=A0#
> @@ -18,22 +18,15 @@
>
>=C2=A0 =C2=A0# OPTIMISATION SETTINGS:
>=C2=A0 =C2=A0# Use gcc option if defined UB_GCC_OPTIONS via "Envir= onment
> variable" or "Command-line arguments".
> -@@ -87,7 +87,7 @@
> -=C2=A0 =C2=A0## (-ffast-math) disables strict IEEE or ISO rules/speci= fications
> for math funcs
> -=C2=A0 =C2=A0OPTON =3D -O3 -ffast-math
> -
> --=C2=A0 ## OS detection.=C2=A0 Comment out if gmake syntax not suppor= ted by
> other 'make'.
> -+=C2=A0 ## OS detection.=C2=A0 Comment out if gmake syntax not suppor= ted by
> other 'make'.
> -=C2=A0 =C2=A0OSNAME:=3D$(shell uname -s)
> -=C2=A0 =C2=A0ARCH :=3D $(shell uname -p)
> -=C2=A0 =C2=A0ifeq ($(OSNAME),Linux)
> -@@ -113,6 +113,9 @@
> +@@ -113,6 +113,13 @@
>=C2=A0 =C2=A0 =C2=A0 =C2=A0CFLAGS +=3D -Wa,-q
>=C2=A0 =C2=A0 =C2=A0endif
>
>=C2=A0 +=C2=A0 ifeq ($(OSNAME),FreeBSD)
> -+=C2=A0 =C2=A0 OPTON +=3D -march=3Dnative -mtune=3Dnative -fomit-fram= e-pointer
> ++=C2=A0 =C2=A0 ifeq ($(ARCH),aarch64)
> ++=C2=A0 =C2=A0 =C2=A0 OPTON +=3D -fomit-frame-pointer
> ++=C2=A0 =C2=A0 else
> ++=C2=A0 =C2=A0 =C2=A0 OPTON +=3D -march=3Dnative -mtune=3Dnative -fom= it-frame-pointer
> ++=C2=A0 =C2=A0 endif
>=C2=A0 +=C2=A0 endif
>=C2=A0 =C2=A0endif
> -
> -

Hi,

Please remove -march=3Dnative as it will break on x86/amd64 for packaging. =
Either add it as a menu option or just rely on ports framework (CPUTYPE in make.conf).

Best regards,
Daniel
--00000000000014eea205f7ceadfb--