From nobody Sun Mar 26 14:43:23 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PkzGM1n23z41vkC; Sun, 26 Mar 2023 14:43:39 +0000 (UTC) (envelope-from luca.pizzamiglio@gmail.com) Received: from mail-ua1-f53.google.com (mail-ua1-f53.google.com [209.85.222.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PkzGL6yWyz3FLb; Sun, 26 Mar 2023 14:43:38 +0000 (UTC) (envelope-from luca.pizzamiglio@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ua1-f53.google.com with SMTP id x33so4525318uaf.12; Sun, 26 Mar 2023 07:43:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679841817; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=azMHLYIQapdo+lkJC9HWn7/Q9HlTp2g7i/TQ6lR9hCw=; b=ITM+LeJ/VptmiGQ/GsfXDDdFb5BUCLNL8fb5AtMfbDcSiJh0KFmFv7sjCH6QgTOosz HR8lJvl3CMW7vj/8Bxot2Da5P1NBTIILr7jUyJPRSyPG+7XdhAhku0eD+r+xVZEdNhyc YGwgiNdJMMt672r6lqMz2uneEJNEbusPO+mP7x/27l8c2uCr7r1myxM9Kg7HTmEcGu23 Qw2xVCulYhY5xUQPXDK86xDdiP3QWgxjt5ul4utEYJajv38Qj+ZT807+xYg+cJUtTCaW yzFvq5aW9pImVUwgGzHkKYrNcza14IRcbOoF07YYjXU8MMu2l7vzttXTMgFrtJNdoZNi lILA== X-Gm-Message-State: AAQBX9dJXgTWQ0CZ8AZwsSnfjVPd6/WA3HBMYU90iCyJSs1JO1wePSn2 TurS30MuSoCpo5cw8dn4YRI6+Na+v2c= X-Google-Smtp-Source: AKy350YhL0/iv6rtMwfvgbj4MFiVl1VmOy5bUh9UvJYokMN7zdgdA2Gesytq/xu0mrOus0NqxBD2oQ== X-Received: by 2002:a1f:3890:0:b0:431:eb68:41b with SMTP id f138-20020a1f3890000000b00431eb68041bmr3225305vka.11.1679841816604; Sun, 26 Mar 2023 07:43:36 -0700 (PDT) Received: from mail-ua1-f53.google.com (mail-ua1-f53.google.com. [209.85.222.53]) by smtp.gmail.com with ESMTPSA id f9-20020a1f1f09000000b00432e396ced8sm1738319vkf.11.2023.03.26.07.43.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Mar 2023 07:43:36 -0700 (PDT) Received: by mail-ua1-f53.google.com with SMTP id r7so4563413uaj.2; Sun, 26 Mar 2023 07:43:36 -0700 (PDT) X-Received: by 2002:a1f:9043:0:b0:433:7ae0:6045 with SMTP id s64-20020a1f9043000000b004337ae06045mr4792042vkd.0.1679841816002; Sun, 26 Mar 2023 07:43:36 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202303261149.32QBnc5d024941@gitrepo.freebsd.org> <906fc94ce07248d8aa56678fcc1b178b@FreeBSD.org> In-Reply-To: <906fc94ce07248d8aa56678fcc1b178b@FreeBSD.org> From: Luca Pizzamiglio Date: Sun, 26 Mar 2023 16:43:23 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 1453ec9ec99d - main - benchmarks/unixbench: Fix arm64 build To: Daniel Engberg Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000b8c75305f7cea69a" X-Rspamd-Queue-Id: 4PkzGL6yWyz3FLb X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --000000000000b8c75305f7cea69a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks for the suggestions! I'm leaving mtune as default, and adding an option to enable march. mtune is expected to not create broken packages. Am I correct? Best regards, Luca On Sun, Mar 26, 2023 at 1:58=E2=80=AFPM Daniel Engberg = wrote: > On 2023-03-26 13:49, Luca Pizzamiglio wrote: > > The branch main has been updated by pizzamig: > > > > URL: > > > https://cgit.FreeBSD.org/ports/commit/?id=3D1453ec9ec99d5025678acb403c9f8= 4c7beb6dbd5 > > > > commit 1453ec9ec99d5025678acb403c9f84c7beb6dbd5 > > Author: Luca Pizzamiglio > > AuthorDate: 2023-03-26 11:49:14 +0000 > > Commit: Luca Pizzamiglio > > CommitDate: 2023-03-26 11:49:14 +0000 > > > > benchmarks/unixbench: Fix arm64 build > > > > On arm64, some cflags are not supported. > > --- > > benchmarks/unixbench/files/patch-Makefile | 21 +++++++-------------- > > 1 file changed, 7 insertions(+), 14 deletions(-) > > > > diff --git a/benchmarks/unixbench/files/patch-Makefile > > b/benchmarks/unixbench/files/patch-Makefile > > index 282945fef972..3c2539dc046d 100644 > > --- a/benchmarks/unixbench/files/patch-Makefile > > +++ b/benchmarks/unixbench/files/patch-Makefile > > @@ -1,5 +1,5 @@ > > --- Makefile.orig 2023-02-07 23:18:07.000000000 +0100 > > -+++ Makefile 2023-02-09 21:57:42.966634000 +0100 > > ++++ Makefile 2023-03-26 13:40:57.699042000 +0200 > > @@ -46,7 +46,7 @@ > > # X11 libraries on your system. (e.g. libX11-devel mesa-libGL-devel) > > # > > @@ -18,22 +18,15 @@ > > > > # OPTIMISATION SETTINGS: > > # Use gcc option if defined UB_GCC_OPTIONS via "Environment > > variable" or "Command-line arguments". > > -@@ -87,7 +87,7 @@ > > - ## (-ffast-math) disables strict IEEE or ISO rules/specifications > > for math funcs > > - OPTON =3D -O3 -ffast-math > > - > > -- ## OS detection. Comment out if gmake syntax not supported by > > other 'make'. > > -+ ## OS detection. Comment out if gmake syntax not supported by > > other 'make'. > > - OSNAME:=3D$(shell uname -s) > > - ARCH :=3D $(shell uname -p) > > - ifeq ($(OSNAME),Linux) > > -@@ -113,6 +113,9 @@ > > +@@ -113,6 +113,13 @@ > > CFLAGS +=3D -Wa,-q > > endif > > > > + ifeq ($(OSNAME),FreeBSD) > > -+ OPTON +=3D -march=3Dnative -mtune=3Dnative -fomit-frame-pointer > > ++ ifeq ($(ARCH),aarch64) > > ++ OPTON +=3D -fomit-frame-pointer > > ++ else > > ++ OPTON +=3D -march=3Dnative -mtune=3Dnative -fomit-frame-pointer > > ++ endif > > + endif > > endif > > - > > - > > Hi, > > Please remove -march=3Dnative as it will break on x86/amd64 for packaging= . > Either add it as a menu option or just rely on ports framework (CPUTYPE > in make.conf). > > Best regards, > Daniel > --000000000000b8c75305f7cea69a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks for the suggestions!
I'm leaving mtune as de= fault, and adding an option to enable march.

mtune i= s expected to not create broken packages.
Am I correct?

Best regards,
Luca

On Sun, M= ar 26, 2023 at 1:58=E2=80=AFPM Daniel Engberg <diizzy@freebsd.org> wrote:
On 2023-03-26 13:49, Luca Pizzamiglio wrot= e:
> The branch main has been updated by pizzamig:
>
> URL:
> https://cgi= t.FreeBSD.org/ports/commit/?id=3D1453ec9ec99d5025678acb403c9f84c7beb6dbd5
>
> commit 1453ec9ec99d5025678acb403c9f84c7beb6dbd5
> Author:=C2=A0 =C2=A0 =C2=A0Luca Pizzamiglio <pizzamig@FreeBSD.org&g= t;
> AuthorDate: 2023-03-26 11:49:14 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Luca Pizzamiglio <pizzamig@FreeBSD.org&g= t;
> CommitDate: 2023-03-26 11:49:14 +0000
>
>=C2=A0 =C2=A0 =C2=A0benchmarks/unixbench: Fix arm64 build
>
>=C2=A0 =C2=A0 =C2=A0On arm64, some cflags are not supported.
> ---
>=C2=A0 benchmarks/unixbench/files/patch-Makefile | 21 +++++++----------= ----
>=C2=A0 1 file changed, 7 insertions(+), 14 deletions(-)
>
> diff --git a/benchmarks/unixbench/files/patch-Makefile
> b/benchmarks/unixbench/files/patch-Makefile
> index 282945fef972..3c2539dc046d 100644
> --- a/benchmarks/unixbench/files/patch-Makefile
> +++ b/benchmarks/unixbench/files/patch-Makefile
> @@ -1,5 +1,5 @@
>=C2=A0 --- Makefile.orig=C2=A0 =C2=A0 2023-02-07 23:18:07.000000000 +01= 00
> -+++ Makefile 2023-02-09 21:57:42.966634000 +0100
> ++++ Makefile 2023-03-26 13:40:57.699042000 +0200
>=C2=A0 @@ -46,7 +46,7 @@
>=C2=A0 =C2=A0# X11 libraries on your system. (e.g. libX11-devel mesa-li= bGL-devel)
>=C2=A0 =C2=A0#
> @@ -18,22 +18,15 @@
>
>=C2=A0 =C2=A0# OPTIMISATION SETTINGS:
>=C2=A0 =C2=A0# Use gcc option if defined UB_GCC_OPTIONS via "Envir= onment
> variable" or "Command-line arguments".
> -@@ -87,7 +87,7 @@
> -=C2=A0 =C2=A0## (-ffast-math) disables strict IEEE or ISO rules/speci= fications
> for math funcs
> -=C2=A0 =C2=A0OPTON =3D -O3 -ffast-math
> -
> --=C2=A0 ## OS detection.=C2=A0 Comment out if gmake syntax not suppor= ted by
> other 'make'.
> -+=C2=A0 ## OS detection.=C2=A0 Comment out if gmake syntax not suppor= ted by
> other 'make'.
> -=C2=A0 =C2=A0OSNAME:=3D$(shell uname -s)
> -=C2=A0 =C2=A0ARCH :=3D $(shell uname -p)
> -=C2=A0 =C2=A0ifeq ($(OSNAME),Linux)
> -@@ -113,6 +113,9 @@
> +@@ -113,6 +113,13 @@
>=C2=A0 =C2=A0 =C2=A0 =C2=A0CFLAGS +=3D -Wa,-q
>=C2=A0 =C2=A0 =C2=A0endif
>
>=C2=A0 +=C2=A0 ifeq ($(OSNAME),FreeBSD)
> -+=C2=A0 =C2=A0 OPTON +=3D -march=3Dnative -mtune=3Dnative -fomit-fram= e-pointer
> ++=C2=A0 =C2=A0 ifeq ($(ARCH),aarch64)
> ++=C2=A0 =C2=A0 =C2=A0 OPTON +=3D -fomit-frame-pointer
> ++=C2=A0 =C2=A0 else
> ++=C2=A0 =C2=A0 =C2=A0 OPTON +=3D -march=3Dnative -mtune=3Dnative -fom= it-frame-pointer
> ++=C2=A0 =C2=A0 endif
>=C2=A0 +=C2=A0 endif
>=C2=A0 =C2=A0endif
> -
> -

Hi,

Please remove -march=3Dnative as it will break on x86/amd64 for packaging. =
Either add it as a menu option or just rely on ports framework (CPUTYPE in make.conf).

Best regards,
Daniel
--000000000000b8c75305f7cea69a--