From nobody Sun Mar 12 08:52:22 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PZD7Z0229z3xc1V; Sun, 12 Mar 2023 08:52:26 +0000 (UTC) (envelope-from matthias.andree@tu-dortmund.de) Received: from unimail.uni-dortmund.de (mx1.hrz.uni-dortmund.de [129.217.128.51]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "unimail.tu-dortmund.de", Issuer "GEANT OV RSA CA 4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PZD7Y3hDYz4Cv4; Sun, 12 Mar 2023 08:52:25 +0000 (UTC) (envelope-from matthias.andree@tu-dortmund.de) Authentication-Results: mx1.freebsd.org; none Received: from mandree.no-ip.org (p54a03c23.dip0.t-ipconnect.de [84.160.60.35]) (authenticated bits=0) by unimail.uni-dortmund.de (8.17.1.26/8.17.1.26) with ESMTPSA id 32C8qM1x020383 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Sun, 12 Mar 2023 09:52:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tu-dortmund.de; s=unimail; t=1678611143; bh=DR6jayf3vGSPzA18EcgajJHFtNYrGxbMQQsdMEmchGo=; h=Date:To:Cc:References:From:Subject:In-Reply-To; b=l2zMhG1vFnpa4tA94OsV8PJ2n4GoL1eXm8UqNMMG8GPCtyzPExpNwkI4Lq+DJ87i+ EeW02sJVF2eaqcwEhLjkl4QJJXXqz8QUlttoN8P85ehnNITUr4UDj6LR34gDwHWzEG r1riqBdLr72Lj7C37R/TKHqE0bEwOSJa+0To0xdE= Received: from [127.0.0.1] (localhost [127.0.0.1]) by ryzen.an3e.de (Postfix) with ESMTP id 7D441D6CBDC; Sun, 12 Mar 2023 09:52:22 +0100 (CET) Message-ID: <8434f57b-b916-8767-b24e-74064683a47b@tu-dortmund.de> Date: Sun, 12 Mar 2023 09:52:22 +0100 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: Charlie Li , Jan Beich Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org, portmgr References: <202303111636.32BGavvS071833@gitrepo.freebsd.org> <09d7cd35-0e90-c465-71bc-5267807b0d46@freebsd.org> From: Matthias Andree Subject: Re: git: b883eac8e32d - main - devel/meson: enable FLAVORs In-Reply-To: <09d7cd35-0e90-c465-71bc-5267807b0d46@freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4PZD7Y3hDYz4Cv4 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:680, ipnet:129.217.0.0/16, country:DE] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N Am 12.03.23 um 03:04 schrieb Charlie Li: > Jan Beich wrote: >> Charlie Li writes: >> >>> -BUILD_DEPENDS=    meson>=0.63.3:devel/meson \ >>> +BUILD_DEPENDS=    meson:devel/meson@${PY_FLAVOR} \ >> >> Looks non-deterministic as "meson" maybe provided by default flavor >> instead of the requested (via FLAVOR + USES=python -> PY_FLAVOR) e.g., >> > Continuing to use the version specifier wasn't exactly tenable due to > the conditional PKGNAME change. Unfortunately this also means those not > using isolated build environments get the short end of the stick for > now, until USE_PYTHON=concurrent is tackled (so that the versioned entry > point can be used instead). >>    $ pkg install meson >>    $ make clean all FLAVOR=py310 BUILD_ALL_PYTHON_FLAVORS=y -C >> devel/meson-python >>    [...] >>    ===>  Building for py310-meson-python-0.12.1 >>    * Getting build dependencies for wheel... >> >>    ERROR Missing dependencies: >>            meson>=0.63.3 >>    *** Error code 1 >> >>> +.if ${PYTHON_VER} != ${PYTHON_DEFAULT} >>> +PKGNAMESUFFIX=    ${PYTHON_PKGNAMESUFFIX} >>> +.endif >> >> Avoiding USE_PYTHON=concurrent without hiding non-module files? >> >>    $ pkg install meson >>    $ pkg install meson-py311 >>    [...] >>    Checking integrity... done (1 conflicting) >>      - meson-py311-1.0.1 conflicts with meson-1.0.1 on >> /usr/local/bin/meson >>    Checking integrity... done (0 conflicting) >>    The following 4 package(s) will be affected (of 0 checked): >> >>    Installed packages to be REMOVED: >>            meson: 1.0.1 >>    [...] > The man pages are part of the sdist and catalogued as data_files in the > bdist, so despite them getting installed in the appropriate directory, > are part of the module. USE_PYTHON=concurrent should take care of these > but need to double check. > Charlie, PLEASE stop rushing in commits of half-baked junk, and either fix this within a week, or even better, back it out today, until this is complete. It would also be better to get the things you'd started earlier fixed and in, before starting on new things (I am thinking of the __pycache__ and bytecode trigger from ). Else we have a non-fitting collection of half-baked Python brokenness. https://reviews.freebsd.org/D39004 also documents that you experiment in the live public ports tree and rush things out long before they're even review worthy. It also was not reviewed. The __pycache__ cleanup Your current approach to ports@ quality is not sustainable. Regards Matthias