From nobody Wed Mar 01 10:48:38 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PRWDq0Yb2z3vjPD; Wed, 1 Mar 2023 10:48:43 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PRWDp6gSzz4Ny1; Wed, 1 Mar 2023 10:48:42 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677667722; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=flvun+oGKnrxwK2zxAMt1CSgffg7ovTu/M6einT6c/A=; b=ofFq3NXGsXEs3sgDfi1sXgeKUQAu9JU0wh23MiFjGkVO7DmL+ebJk5vHluPvQ4XEC38CUO L0+Q6WhLXGQDLk9SYhkv3Z5agvFOUlfaEHHCS/yaLmV/w8ZKaVtlVTCCfIC/DCpiWTnuSa tWw5va/X0sA3RNZM6U8mF869snuMat0FT9ZpLi2Qsm1tVnuio7bb78YR5GcQvMC3SsYvNZ N48st4yiEpc5TebC3FuKllNJFoaaHMuwDwI1kwnIf5wUmgbB4aPuLWH0MoiSIBGdJrC2rr ft232vA34fSUplBw3eMD6Ra9KMjeMG5BbB322ix7tuDbrLqzTUup+8mbVyZu5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677667722; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=flvun+oGKnrxwK2zxAMt1CSgffg7ovTu/M6einT6c/A=; b=vKpFNCHXpTSEzj+ogTI3Y76oexrC9r6sUZ1hSvIc/pAY7zzISozt6F/GtUi2UWsQNVtj/U 7uHkoHz/OSP8ODNyHTNHD2nkvDa7UbzXOVqF3HI5m15ZkvwIcLtH15bQvhmc5Xe1HIzjdo dhlADoKuNsnXEluU6HjX7j6DqRiifaaZFliCBBwDIG0QjuMAA2/NdxOnEGOEBKKkGEGFjY XA3ao35Nzm9RxvXZBKan5q1KjG+oyvzeclJKcwBYHHe7Zi4XP5VBZ2G1hUCapkeP7iSfTv F+44CH3L3lKGMuRk/1fhTg/m00uXPKvQDeX2WJGReK1tmPz36db6LYEHCxWmNw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1677667722; a=rsa-sha256; cv=none; b=HgVXIho0glIE2ZgDfr24xpqxh7/u+YYuI6TTb19anE3FJbqgmFQOoiKTE/mkOQTiAWEFaK uFZTRkPHJDXlkYvyTUeVNplKvUKA6qxtdnkR0ZzwvfaOb9B1QRT5qyG636fm0H/0/76lDB RY5r0eXvPq54qchUdWEQW7IP+YPCgLnCLTyZ1ziBRcYrgAGGeke5bs6dlqA4ThLnmzTKkR zdwHKcHJGJfvcwg0otHm9AppomYoEansJhai7JBPTrooljN92vgOKOjGI6o8VO2qHtV8UK dIMqG68rRPvU+Iu8iL/F3LbMF9nHBFuipDzxjFEAm6JSxDypGSF6pq00E4WOJA== Received: from [172.24.42.13] (host-82-61-176-187.retail.telecomitalia.it [82.61.176.187]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: madpilot/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PRWDp0lBrzwS3; Wed, 1 Mar 2023 10:48:41 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Message-ID: <8a595f2f-ee12-c462-b3bc-6fcbfca566a2@FreeBSD.org> Date: Wed, 1 Mar 2023 11:48:38 +0100 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: git: 47912ce2e613 - main - databases/sqlite3: update to 3.41.0 Content-Language: en-US To: Florian Smeets Cc: Robert Clausecker , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org References: <202302272249.31RMnYh9078107@gitrepo.freebsd.org> <240c5332-fb8b-0162-2a53-c73c6b9ab1f8@FreeBSD.org> From: Guido Falsi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N On 01/03/23 10:36, Florian Smeets wrote: > On Tue, Feb 28, 2023 at 11:40:13PM +0100, Guido Falsi wrote: >> On 27/02/23 23:49, Robert Clausecker wrote: >>> The branch main has been updated by fuz: >>> >>> URL: https://cgit.FreeBSD.org/ports/commit/?id=47912ce2e613211aecf6ecdfc58681b7aca0df33 >>> >>> commit 47912ce2e613211aecf6ecdfc58681b7aca0df33 >>> Author: Pavel Volkov >>> AuthorDate: 2023-02-24 09:23:48 +0000 >>> Commit: Robert Clausecker >>> CommitDate: 2023-02-27 22:46:24 +0000 >>> >>> databases/sqlite3: update to 3.41.0 >>> >>> Disable option DQS by default. >>> Add a note to UPDATING about this. >>> >> > > I'm answering as I'm the one that approved the commit. > >> While I understand your motives this is a dangerous choice. There will >> be a lot of runtime breakage in ports using sqlite3. > > We are following upstream on this one, it's in the release notes. > > https://www.sqlite.org/releaselog/3_41_0.html > > 6.f. The double-quoted string misfeature is now disabled by default for CLI > builds. Legacy use cases can reenable the misfeature at run-time using the > ".dbconfig dqs_dml on" and ".dbconfig dqs_ddl on" commands. > > Accoring to https://www.sqlite.org/quirks.html#dblquote there has been a > warning for 4 years warning about use of double quoted strings. > I have no objection, as I stated I understand the situation, and don't disapprove of the change itself. >> >> I just discovered that deskutils/calibre in some parts of the code falls >> for this. >> >> This is relatively easy to fix and I am testing patches. I'll also >> submit it upstream: >> >> https://github.com/madpilot78/calibre/commit/e79cfdd3c6ab232fefa78dc185261ced7a209ae7 >> >> but I'm sure a lot of ports will start acting up for no apparent reason >> due to this. > > Can someone back this up with some numbers? If I underestimated the > consequences and this does indeed break more stuff we can/should revert, > but we would deviate from upstream. I did not mean to ask for a revert. I only wanted to cast a friendly warning that there will be some fallout. I can't give you exact numbers, I have calibre failing (fix coming shortly), and have seen the bug report you also noticed (below) > > I see we have a PR with at least two more broken ports 269889. -- Guido Falsi