From nobody Tue Jun 13 06:28:17 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QgJY460zjz4dMJp; Tue, 13 Jun 2023 06:28:56 +0000 (UTC) (envelope-from eugen@freebsd.org) Received: from hz.grosbein.net (hz.grosbein.net [IPv6:2a01:4f8:c2c:26d8::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "hz.grosbein.net", Issuer "hz.grosbein.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QgJY40xgCz3qCt; Tue, 13 Jun 2023 06:28:56 +0000 (UTC) (envelope-from eugen@freebsd.org) Authentication-Results: mx1.freebsd.org; none Received: from eg.sd.rdtc.ru (root@eg.sd.rdtc.ru [62.231.161.221] (may be forged)) by hz.grosbein.net (8.17.1/8.17.1) with ESMTPS id 35D6Sl3L063541 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Jun 2023 06:28:48 GMT (envelope-from eugen@freebsd.org) X-Envelope-From: eugen@freebsd.org X-Envelope-To: arrowd@freebsd.org Received: from [10.58.0.11] (dadvw [10.58.0.11] (may be forged)) by eg.sd.rdtc.ru (8.16.1/8.16.1) with ESMTPS id 35D6SjVq058415 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Tue, 13 Jun 2023 13:28:45 +0700 (+07) (envelope-from eugen@freebsd.org) Subject: Re: git: f89fd0980a5c - main - databases/mysql57-client: be ready for OpenSSL 3.0 in base To: Gleb Popov References: <202306130516.35D5GXM1015646@gitrepo.freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org From: Eugene Grosbein Message-ID: <4c244417-9439-dbb0-beea-75ed7672b869@freebsd.org> Date: Tue, 13 Jun 2023 13:28:17 +0700 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT autolearn=disabled version=3.4.6 X-Spam-Report: * -0.0 SHORTCIRCUIT No description available. * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on hz.grosbein.net X-Rspamd-Queue-Id: 4QgJY40xgCz3qCt X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/32, country:DE] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N 13.06.2023 13:05, Gleb Popov wrote: > On Tue, Jun 13, 2023 at 8:16 AM Eugene Grosbein wrote: >> >> IF(OPENSSL_INCLUDE_DIR) >> ++ FOREACH(version_part >> ++ OPENSSL_VERSION_MAJOR >> ++ OPENSSL_VERSION_MINOR >> ++ OPENSSL_VERSION_PATCH >> ++ ) >> ++ FILE(STRINGS "${OPENSSL_INCLUDE_DIR}/openssl/opensslv.h" ${version_part} > > I don't quite see how it is supposed to work. The result of the > "file(STRINGS ...)" call overwrites your loop variable. > > Anyways, more canonical way to solve this is > https://cmake.org/cmake/help/latest/module/CheckSymbolExists.html That's not my code. I just got it from MySQL 8.0 distribution file and tested. And it works for both cases of OpenSSL 3.0 in base and OpenSSL 1.1.1 in base.